Skip to content

Commit 3dcdcda

Browse files
committed
docs: state generic recipe invariants
1 parent 715d22d commit 3dcdcda

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

‎src/eb_parse.rs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1428,7 +1428,7 @@ pub fn candidate_matches_dep(c: &Candidate, dep: &ResolvedDep) -> bool {
14281428
/// toolchain pin, only candidates whose toolchain is a member of `hierarchy`
14291429
/// count (e.g. CapnProto on GCCcore-14.x does not satisfy foss-2026.1 which
14301430
/// needs GCCcore-15.2.0). Explicit fourth-tuple pins still match exactly,
1431-
/// including cross-generation residuals (`xtb`/gfbf-2024a).
1431+
/// including explicitly selected cross-generation dependencies.
14321432
pub fn candidate_matches_dep_for_recipe(
14331433
c: &Candidate,
14341434
dep: &ResolvedDep,
@@ -2377,9 +2377,8 @@ builddependencies = [
23772377

23782378
#[test]
23792379
fn checksum_lint_flags_patch_checksum_in_source_slot() {
2380-
// The eOn-2026.1 incident: the patch checksum inserted at position 1
2381-
// (a source slot). Counts match, so only positional key matching
2382-
// catches it before eb aborts a build with "Missing checksum for X".
2380+
// Counts match, so only positional key matching catches a patch
2381+
// checksum occupying a source slot before EasyBuild starts the build.
23832382
let r = checksum_recipe(
23842383
"[{'app-1.0.tar.gz': 'aa11'}, {'App-1.0_fix.patch': 'dd44'},\n \
23852384
{'sub-2.0.tar.gz': 'bb22'}, {'core-3.0.tar.gz': 'cc33'}]",

‎src/hierarchy.rs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -840,10 +840,8 @@ mod tests {
840840

841841
#[test]
842842
fn known_foss_2026_1_includes_required_levels() {
843-
// foss-2026.1 is the landable target generation used across the eOn /
844-
// QMCPACK fixtures and skills. It must be a known hierarchy so `plan`
845-
// resolves dependency versions without a full easyconfigs robot that
846-
// carries the foss-2026.1 toolchain-definition recipe.
843+
// An embedded generation lets `plan` resolve dependency versions when
844+
// the supplied robot lacks the matching toolchain-definition recipe.
847845
let h = known_hierarchy(&foss("2026.1")).expect("embedded foss-2026.1");
848846
let labels = h.member_labels();
849847
for need in [

0 commit comments

Comments
 (0)