Skip to content

Commit a92390e

Browse files
authored
Merge pull request #14 from sqlstack-io/fix/header-logo-lockup
feat: use the SQLStack logo lockup in the header
2 parents a2386a9 + 14b18a7 commit a92390e

6 files changed

Lines changed: 9 additions & 8 deletions

File tree

‎README.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ Open `http://localhost:4173`. No build step or package installation is required
1414

1515
The page uses self-hosted Inter and Space Grotesk fonts. Their licenses are included in
1616
`assets/fonts/`. Product icons are optimized PNG derivatives of the original brand artwork.
17+
The header uses the SQLStack logo lockup (mark and wordmark) as transparent light and dark PNGs in
18+
`assets/icons/sqlstack-lockup.png` and `assets/icons/sqlstack-lockup-dark.png`.
1719

1820
The theme defaults to the system preference. The accessible header toggle saves an explicit
1921
light/dark preference in the browser. Without JavaScript, the page remains usable in light mode.
11.8 KB
Loading

‎assets/icons/sqlstack-lockup.png‎

11.9 KB
Loading

‎index.html‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,8 @@
3434
<header class="site-header">
3535
<div class="shell header-inner">
3636
<a class="brand" href="./" aria-label="SQLStack home">
37-
<img class="logo-for-light" src="assets/icons/sqlstack.png" width="40" height="34" alt="">
38-
<img class="logo-for-dark" src="assets/icons/sqlstack-dark.png" width="40" height="34" alt="">
39-
<span>SQLStack</span>
37+
<img class="logo-for-light" src="assets/icons/sqlstack-lockup.png" width="144" height="34" alt="SQLStack">
38+
<img class="logo-for-dark" src="assets/icons/sqlstack-lockup-dark.png" width="144" height="34" alt="SQLStack">
4039
</a>
4140
<div class="header-actions">
4241
<a class="nav-icon" href="https://github.com/sqlstack-io" aria-label="SQLStack on GitHub">

‎styles.css‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ img { display: block; object-fit: contain; }
6060
.site-header { border-bottom: 1px solid var(--line); }
6161
.header-inner { min-height: 58px; display: flex; align-items: center; justify-content: space-between; gap: 24px; }
6262
.brand { display: inline-flex; align-items: center; gap: 3px; color: var(--ink); text-decoration: none; }
63-
.brand span { font-family: "Space Grotesk", sans-serif; font-size: 22px; font-weight: 700; letter-spacing: 0; }
6463
.nav-icon { display: inline-grid; place-items: center; width: 44px; height: 44px; color: var(--muted); }
6564
.nav-icon:hover { color: var(--ink); }
6665
.nav-icon:focus-visible { outline-offset: 3px; }

‎tests/website.spec.mjs‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,9 @@ test('approved products, sharing assets and responsive navigation work in both t
5050
await expect(page.getByRole('heading', { level: 1 })).toHaveText('Your data stack. Engineered for safer change.');
5151
await expect(page.locator('.hero .lede')).toHaveText('Rust-backed SQL and Python tools for data engineers.');
5252
await expect(page.getByRole('heading', { level: 3 })).toHaveText(names);
53-
const wordmark = page.locator('.brand span');
54-
for (const [property, value] of [['font-family', '"Space Grotesk", sans-serif'], ['font-weight', '700'], ['letter-spacing', 'normal'], ['font-size', '22px']]) {
55-
await expect(wordmark).toHaveCSS(property, value);
56-
}
53+
const logo = page.getByRole('link', { name: 'SQLStack home', exact: true }).locator('img:visible');
54+
await expect(logo).toHaveAttribute('src', `assets/icons/sqlstack-lockup${theme === 'dark' ? '-dark' : ''}.png`);
55+
await expect(logo).toHaveAttribute('alt', 'SQLStack');
5756
await expect(page.getByRole('link', { name: 'SQLStack on GitHub', exact: true })).toHaveAttribute('href', 'https://github.com/sqlstack-io');
5857
for (const [name, website] of [['SQLBuild', 'https://sqlbuild.com'], ['SQLTide', 'https://sqltide.io/'], ['SQLClean', 'https://sqlclean.io'], ['Fensu', 'https://fensu.io/'], ['SQLLoad', 'https://sqlload.io'], ['SQLQuack', 'https://sqlquack.io']]) {
5958
const card = page.getByRole('article', { name, exact: true });
@@ -103,6 +102,8 @@ test('approved products, sharing assets and responsive navigation work in both t
103102
}
104103
for (const [path, width, height] of [
105104
['/assets/og-sqlstack-dark.png', 1200, 630],
105+
['/assets/icons/sqlstack-lockup.png', 432, 102],
106+
['/assets/icons/sqlstack-lockup-dark.png', 432, 102],
106107
['/assets/favicon-16.png', 16, 16],
107108
['/assets/favicon-32.png', 32, 32],
108109
['/assets/favicon-dark-32.png', 32, 32],

0 commit comments

Comments
 (0)