From fa06a6643d7f81769823346e0c69265a87876d7c Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 07:28:28 +0000 Subject: [PATCH 01/10] fix(syntax): read SHOW WITH PRIVILEGES as documented privileges A SHOW privilege list now names the privileges a GRANT takes, each followed by a comma or the statement end, so a plain name is refused as the recorded receipts show. --- .../src/parser/_helpers/ddl/snowflake_show.rs | 28 +++++++++--- .../test_snowflake_receipted_objects.rs | 44 +++++++++++++++++++ 2 files changed, 65 insertions(+), 7 deletions(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs index 050da7a86..8ab5336c3 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs @@ -4,8 +4,9 @@ use crate::parser::constants::ACCOUNT; use crate::parser::constants::ON_ACCOUNT; use crate::parser::constants::USER; use crate::parser::constants::{ - SHARED_SHOW_KINDS, SNOWFLAKE_SHOW_CONTAINERS, SNOWFLAKE_SHOW_EXTRA_CONTAINERS, - SNOWFLAKE_SHOW_GENERAL_CONTAINERS, SNOWFLAKE_SHOW_KINDS, SNOWFLAKE_SHOW_REQUIRED_CONTAINERS, + SHARED_SHOW_KINDS, SNOWFLAKE_GRANT_PRIVILEGES, SNOWFLAKE_SHOW_CONTAINERS, + SNOWFLAKE_SHOW_EXTRA_CONTAINERS, SNOWFLAKE_SHOW_GENERAL_CONTAINERS, SNOWFLAKE_SHOW_KINDS, + SNOWFLAKE_SHOW_REQUIRED_CONTAINERS, }; use crate::parser::models::Parser; use sqlquack_syntax::expressions::queries::models::Limit; @@ -263,7 +264,7 @@ impl Parser { Ok(show) } - /// `WITH PRIVILEGES [ , ... ]`, or `WITH PRIMARY .`. + /// `WITH PRIVILEGES [ , ... ]` with documented privileges, or `WITH PRIMARY .`. fn parse_show_with(&mut self, kind: &str, mut show: Show) -> Result { if matches!(kind, "REPLICATION DATABASES") && self.match_text_seq(&["PRIMARY"]) { show.target = Some(self.parse_show_name()?); @@ -273,11 +274,24 @@ impl Parser { return Err(self.parse_error("Expected PRIVILEGES after WITH")); } loop { - if !(self.is_identifier_token() || self.check_keyword()) { + let found = SNOWFLAKE_GRANT_PRIVILEGES + .iter() + .map(|name| name.split(' ').collect::>()) + .filter(|parts| { + self.check_text_seq(parts) + && (self.peek_nth(parts.len()).is_some_and(|token| { + matches!( + token.token_type, + TokenType::Comma | TokenType::RParen | TokenType::DArrow + ) + }) || self.is_statement_end_at(parts.len())) + }) + .max_by_key(Vec::len); + let Some(parts) = found else { return Err(self.parse_error("Expected a privilege")); - } - show.privileges - .push(self.advance_text()?.to_ascii_uppercase()); + }; + self.match_text_seq(&parts); + show.privileges.push(parts.join(" ")); if !self.match_token(TokenType::Comma) { return Ok(show); } diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs index 650d7e345..8ca4f5ae5 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs @@ -671,3 +671,47 @@ fn given_a_snowflake_external_agent_or_filtered_show_when_parsing_then_the_tree_ ); } } + +#[test] +fn given_a_snowflake_show_with_privileges_when_parsing_then_recorded_verdicts_hold() { + let test_cases = [ + SnowflakeVerdictTestCase { + description: "a documented privilege (recorded acceptance)", + sql: "SHOW DATABASES WITH PRIVILEGES USAGE , USAGE ;", + expected_kind: Some("show"), + }, + SnowflakeVerdictTestCase { + description: "a privilege of several words", + sql: "SHOW SCHEMAS WITH PRIVILEGES USAGE , CREATE TABLE ;", + expected_kind: Some("show"), + }, + SnowflakeVerdictTestCase { + description: "a name that is no privilege (recorded errno 1003)", + sql: "SHOW WAREHOUSES WITH PRIVILEGES v1 ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a trailing comma (recorded errno 1003)", + sql: "SHOW SCHEMAS WITH PRIVILEGES USAGE , ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a privilege list may end a RESULTSET's query", + sql: "BEGIN LET r1 RESULTSET := ( SHOW DATABASES WITH PRIVILEGES USAGE ) ; END ;", + expected_kind: Some("scripting_block"), + }, + SnowflakeVerdictTestCase { + description: "a privilege list may flow into the next statement", + sql: "SHOW DATABASES WITH PRIVILEGES USAGE ->> SELECT 1 ;", + expected_kind: Some("operator"), + }, + ]; + for test_case in test_cases { + assert_eq!( + snowflake_kind(test_case.sql), + test_case.expected_kind.map(str::to_owned), + "{}", + test_case.description + ); + } +} From b3a10ceacf0586215b6ff56cac1936163d92be25 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 07:30:58 +0000 Subject: [PATCH 02/10] fix(syntax): check a CREATE VARIABLE's type, default and comment A variable needs an unquoted type after its name, DEFAULT needs a value and COMMENT takes a string, as the recorded receipts show. --- .../parser/_helpers/ddl/snowflake_opaque.rs | 26 ++++++++++- .../test_snowflake_receipted_objects.rs | 44 +++++++++++++++++++ 2 files changed, 69 insertions(+), 1 deletion(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs index 0a6ba3c37..370085358 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs @@ -32,7 +32,7 @@ impl Parser { checked } - /// After a CREATE's name, the shape its kind needs: FROM for a code bundle or notebook project, a snapshot's service volume, an external agent's version, AS COPY for a pipe's body, and an Openflow connector's added version; the cursor stays after the name. + /// After a CREATE's name, the shape its kind needs: FROM for a code bundle or notebook project, a snapshot's service volume, an external agent's version, a variable's type, AS COPY for a pipe's body, and an Openflow connector's added version; the cursor stays after the name. fn check_opaque_shape(&mut self, create: bool, kind_at: usize) -> Result<()> { let after_name = self.current; let kind = self.tokens[kind_at].text.to_ascii_uppercase(); @@ -49,6 +49,7 @@ impl Parser { let project = matches!(second.as_str(), "PROJECT"); let checked = match kind.as_str() { "EXTERNAL" if matches!(second.as_str(), "AGENT") => self.check_external_agent_tail(), + "VARIABLE" => self.check_variable_tail(), "SNAPSHOT" if !matches!(second.as_str(), "SET" | "POLICY") => { self.check_snapshot_source() } @@ -101,6 +102,29 @@ impl Parser { } } + /// A variable's ` [ DEFAULT ] [ COMMENT = '' ]` after its name. + fn check_variable_tail(&mut self) -> Result<()> { + if self.check(TokenType::String) || self.is_statement_end_at(0) { + return Err(self.parse_error("Expected the variable's type")); + } + self.parse_data_type()?; + if self.match_token(TokenType::Default) { + if self.is_statement_end_at(0) { + return Err(self.parse_error("Expected a default value")); + } + self.parse_expression()?; + } + if self.match_text_seq(&["COMMENT"]) + && !(self.match_token(TokenType::Eq) && self.match_token(TokenType::String)) + { + return Err(self.parse_error("Expected = and a string after COMMENT")); + } + match self.is_statement_end_at(0) || self.check(TokenType::DArrow) { + true => Ok(()), + false => Err(self.parse_error("Expected the end of the variable")), + } + } + /// An external agent's `[ WITH VERSION ]`, the only clause after its name. fn check_external_agent_tail(&mut self) -> Result<()> { if self.match_token(TokenType::With) { diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs index 8ca4f5ae5..0e3217da6 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs @@ -715,3 +715,47 @@ fn given_a_snowflake_show_with_privileges_when_parsing_then_recorded_verdicts_ho ); } } + +#[test] +fn given_a_snowflake_variable_when_parsing_then_recorded_verdicts_hold() { + let test_cases = [ + SnowflakeVerdictTestCase { + description: "a variable with its type, default and comment (recorded semantic error)", + sql: "CREATE OR REPLACE VARIABLE IF NOT EXISTS v1 INT DEFAULT 1 COMMENT = 'm' ;", + expected_kind: Some("raw"), + }, + SnowflakeVerdictTestCase { + description: "a variable needs a type (recorded errno 1003)", + sql: "CREATE VARIABLE v1 ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a type is not a string (recorded errno 1003)", + sql: "CREATE VARIABLE v1 'INT' ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "DEFAULT needs a value (recorded errno 1003)", + sql: "CREATE VARIABLE v1 INT DEFAULT ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a comment is a string (recorded errno 1003)", + sql: "CREATE VARIABLE v1 INT COMMENT = m1 ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a variable kept as text may flow into the next statement", + sql: "CREATE VARIABLE v1 INT DEFAULT 1 ->> SELECT 1 ;", + expected_kind: Some("raw"), + }, + ]; + for test_case in test_cases { + assert_eq!( + snowflake_kind(test_case.sql), + test_case.expected_kind.map(str::to_owned), + "{}", + test_case.description + ); + } +} From b8bd953faa984dd7aa4ced2d6979f59c83a36bdc Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 07:35:35 +0000 Subject: [PATCH 03/10] fix(syntax): check DESCRIBE FUNCTION TABLE arguments A DESCRIBE argument may not open with a bare parenthesis, and a TABLE argument needs at least one column type, as the recorded receipts show. --- .../src/parser/_helpers/ddl/scripting.rs | 3 ++ .../_helpers/ddl/snowflake_statements.rs | 13 +++++++++ .../test_snowflake_receipted_objects.rs | 29 +++++++++++++++++++ 3 files changed, 45 insertions(+) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/scripting.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/scripting.rs index 3a50f9899..78aa1b375 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/scripting.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/scripting.rs @@ -260,6 +260,9 @@ impl Parser { let mut type_args: Vec = Vec::new(); if !self.check(TokenType::RParen) { loop { + if self.is_snowflake() { + self.check_describe_argument_start()?; + } let mut parts: Vec = Vec::new(); let mut paren_depth = 0usize; while !self.is_at_end() { diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_statements.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_statements.rs index 0c114fd04..8f445513d 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_statements.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_statements.rs @@ -156,6 +156,19 @@ impl Parser { })))) } + /// Refuse a Snowflake DESCRIBE argument that opens with a bare parenthesis, or a TABLE argument without column types. + pub(super) fn check_describe_argument_start(&self) -> Result<()> { + let empty_table = self.check(TokenType::Table) + && self.check_next(TokenType::LParen) + && self + .peek_nth(2) + .is_some_and(|token| token.token_type == TokenType::RParen); + match self.check(TokenType::LParen) || empty_table { + true => Err(self.parse_error("Expected an argument data type")), + false => Ok(()), + } + } + /// An optional ` = ` after a DESCRIBE target, as the shared DESCRIBE keeps one. fn parse_describe_choice( &mut self, diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs index 0e3217da6..a03acdd9b 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs @@ -759,3 +759,32 @@ fn given_a_snowflake_variable_when_parsing_then_recorded_verdicts_hold() { ); } } + +#[test] +fn given_a_snowflake_describe_of_a_metric_function_when_parsing_then_recorded_verdicts_hold() { + let test_cases = [ + SnowflakeVerdictTestCase { + description: "TABLE arguments with column types (recorded semantic error)", + sql: "DESC FUNCTION v1 ( TABLE ( INT ) , TABLE ( INT , INT ) ) ;", + expected_kind: Some("describe"), + }, + SnowflakeVerdictTestCase { + description: "a TABLE argument needs a column type (recorded errno 1003)", + sql: "DESC FUNCTION v1 ( TABLE ( INT ) , TABLE ( ) ) ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "an argument does not open with a parenthesis (recorded errno 1003)", + sql: "DESC FUNCTION v1 ( TABLE ( INT ) , ( INT ) ) ;", + expected_kind: None, + }, + ]; + for test_case in test_cases { + assert_eq!( + snowflake_kind(test_case.sql), + test_case.expected_kind.map(str::to_owned), + "{}", + test_case.description + ); + } +} From 5dd6d96360f93099f5fc225604c0db4db946bef9 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 07:39:09 +0000 Subject: [PATCH 04/10] fix(syntax): check warehouse table lists, ABORT, unnamed actions and connector PUSH ALTER WAREHOUSE ADD and DROP take TABLES and a list of named tables, ABORT needs ALL QUERIES, the current warehouse cannot add or drop tables, rename or tag itself, and UNSET takes names, not strings. An Openflow connector pushes to a location string, as the recorded receipts show. --- .../parser/_helpers/ddl/snowflake_opaque.rs | 69 +++++++++++++++++-- .../test_snowflake_receipted_objects.rs | 69 +++++++++++++++++++ 2 files changed, 134 insertions(+), 4 deletions(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs index 370085358..77e37bff9 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs @@ -32,16 +32,19 @@ impl Parser { checked } - /// After a CREATE's name, the shape its kind needs: FROM for a code bundle or notebook project, a snapshot's service volume, an external agent's version, a variable's type, AS COPY for a pipe's body, and an Openflow connector's added version; the cursor stays after the name. + /// After a CREATE's name, the shape its kind needs: FROM for a code bundle or notebook project, a snapshot's service volume, an external agent's version, a variable's type, AS COPY for a pipe's body, an Openflow connector's added version and push, and a warehouse's actions; the cursor stays after the name. fn check_opaque_shape(&mut self, create: bool, kind_at: usize) -> Result<()> { let after_name = self.current; let kind = self.tokens[kind_at].text.to_ascii_uppercase(); let second = self.tokens[kind_at + 1].text.to_ascii_uppercase(); if !create { let connector = matches!((kind.as_str(), second.as_str()), ("OPENFLOW", "CONNECTOR")); - let checked = match connector && self.check_text_seq(&["ADD"]) { - true => self.check_connector_version(), - false => Ok(()), + let warehouse = matches!(kind.as_str(), "WAREHOUSE"); + let checked = match (connector, warehouse) { + (true, _) if self.check_text_seq(&["ADD"]) => self.check_connector_version(), + (true, _) if self.check_text_seq(&["PUSH"]) => self.check_connector_push(), + (_, true) => self.check_warehouse_action(self.current == kind_at + 1), + _ => Ok(()), }; self.current = after_name; return checked; @@ -125,6 +128,64 @@ impl Parser { } } + /// A warehouse action after its name, which `unnamed` says was left out: ABORT ALL QUERIES, a named warehouse's tables, rename or tags, and unquoted names to UNSET. + fn check_warehouse_action(&mut self, unnamed: bool) -> Result<()> { + let tag = self + .peek_nth(1) + .is_some_and(|token| token.text.eq_ignore_ascii_case("TAG")) + && !self + .peek_nth(2) + .is_some_and(|token| token.token_type == TokenType::Eq); + let tables = self.check_text_seq(&["ADD"]) || self.check_text_seq(&["DROP"]); + let tagging = tag && (self.check_text_seq(&["SET"]) || self.check_text_seq(&["UNSET"])); + if unnamed && (tables || tagging || self.check_text_seq(&["RENAME"])) { + return Err(self.parse_error("Expected a warehouse name before the action")); + } + if self.match_text_seq(&["ABORT"]) && !self.match_text_seq(&["ALL", "QUERIES"]) { + return Err(self.parse_error("Expected ALL QUERIES after ABORT")); + } + if self.match_text_seq(&["UNSET"]) { + self.match_text_seq(&["TAG"]); + return match self.check(TokenType::String) { + true => Err(self.parse_error("Expected a name to unset, not a string")), + false => Ok(()), + }; + } + match tables { + true => self.check_warehouse_tables(), + false => Ok(()), + } + } + + /// `{ ADD | DROP } TABLES ( [ , ... ] )` after a warehouse's name. + fn check_warehouse_tables(&mut self) -> Result<()> { + self.skip(); + if !self.match_text_seq(&["TABLES"]) || !self.match_token(TokenType::LParen) { + return Err(self.parse_error("Expected TABLES and a parenthesised list")); + } + loop { + if self.check(TokenType::String) || self.check(TokenType::RParen) { + return Err(self.parse_error("Expected a table name")); + } + self.parse_object_name()?; + if !self.match_token(TokenType::Comma) { + return Ok(()); + } + } + } + + /// `PUSH [ TO '' ]` after an Openflow connector's name, which properties follow. + fn check_connector_push(&mut self) -> Result<()> { + self.skip(); + if self.match_token(TokenType::To) && !self.match_token(TokenType::String) { + return Err(self.parse_error("Expected a location string after TO")); + } + match self.check(TokenType::Eq) { + true => Err(self.parse_error("Expected a property name")), + false => Ok(()), + } + } + /// An external agent's `[ WITH VERSION ]`, the only clause after its name. fn check_external_agent_tail(&mut self) -> Result<()> { if self.match_token(TokenType::With) { diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs index a03acdd9b..7815c56b4 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs @@ -788,3 +788,72 @@ fn given_a_snowflake_describe_of_a_metric_function_when_parsing_then_recorded_ve ); } } + +#[test] +fn given_a_snowflake_warehouse_or_connector_action_when_parsing_then_recorded_verdicts_hold() { + let test_cases = [ + SnowflakeVerdictTestCase { + description: "a named warehouse adds tables (recorded semantic error)", + sql: "ALTER WAREHOUSE v1 ADD TABLES ( v1 ) ;", + expected_kind: Some("raw"), + }, + SnowflakeVerdictTestCase { + description: "the current warehouse aborts its queries (recorded acceptance)", + sql: "ALTER WAREHOUSE ABORT ALL QUERIES ;", + expected_kind: Some("raw"), + }, + SnowflakeVerdictTestCase { + description: "adding tables needs a warehouse name (recorded errno 1002)", + sql: "ALTER WAREHOUSE ADD TABLES ( v1 ) ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "dropping tables needs TABLES (recorded errno 1003)", + sql: "ALTER WAREHOUSE v1 DROP ( v1 ) ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a table list is not empty (recorded errno 1003)", + sql: "ALTER WAREHOUSE v1 ADD TABLES ( ) ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a table is named, not a string (recorded errno 1003)", + sql: "ALTER WAREHOUSE v1 DROP TABLES ( 'v1' ) ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "ABORT needs ALL QUERIES (recorded errno 1003)", + sql: "ALTER WAREHOUSE ABORT QUERIES ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "renaming needs a warehouse name (recorded errno 1003)", + sql: "ALTER WAREHOUSE RENAME TO v1 ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "an unset tag is named (recorded errno 1003)", + sql: "ALTER WAREHOUSE v1 UNSET TAG 'v1' ;", + expected_kind: None, + }, + SnowflakeVerdictTestCase { + description: "a connector pushes to a location (recorded semantic error)", + sql: "ALTER OPENFLOW CONNECTOR v1 PUSH TO 'm' USERNAME = 'm' PASSWORD = 'm' NAME = 'm' EMAIL = 'm' ;", + expected_kind: Some("raw"), + }, + SnowflakeVerdictTestCase { + description: "a push location is a string (recorded errno 1003)", + sql: "ALTER OPENFLOW CONNECTOR v1 PUSH TO m1 USERNAME = 'm' PASSWORD = 'm' NAME = 'm' EMAIL = 'm' ;", + expected_kind: None, + }, + ]; + for test_case in test_cases { + assert_eq!( + snowflake_kind(test_case.sql), + test_case.expected_kind.map(str::to_owned), + "{}", + test_case.description + ); + } +} From 2d8f72ca7358190d1171d18a4fbda48c7cc62098 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 07:41:30 +0000 Subject: [PATCH 05/10] fix(syntax): refuse CONTACT on an event table An event table takes the table properties after its name except WITH CONTACT, as the recorded receipts show. --- .../_helpers/ddl/snowflake_event_tables.rs | 5 +++- .../test_snowflake_receipted_objects.rs | 24 +++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs index 498b5d40d..4b6e189be 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs @@ -117,10 +117,13 @@ impl Parser { words == ["EVENT"] && ends(2) } - /// The properties of an event table: those a table takes after its columns. + /// The properties of an event table: those a table takes after its columns, except CONTACT. fn parse_event_table_properties(&mut self) -> Result> { let mut properties: Vec = Vec::new(); while !self.is_at_end() && !self.check(TokenType::Semicolon) { + if self.check_text_seq(&["WITH", "CONTACT"]) || self.check_text_seq(&["CONTACT"]) { + return Err(self.parse_error("An event table takes no CONTACT")); + } properties.extend(self.parse_checked_table_property(SnowflakeTableKind::Table)?); } Ok(properties) diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs index 7815c56b4..393650ddd 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs @@ -857,3 +857,27 @@ fn given_a_snowflake_warehouse_or_connector_action_when_parsing_then_recorded_ve ); } } + +#[test] +fn given_a_snowflake_event_table_with_a_contact_when_parsing_then_recorded_verdicts_hold() { + let test_cases = [ + SnowflakeVerdictTestCase { + description: "an event table copies grants (recorded acceptance)", + sql: "CREATE EVENT TABLE v1 COPY = ( GRANTS ) ;", + expected_kind: Some("create_object"), + }, + SnowflakeVerdictTestCase { + description: "an event table takes no CONTACT (recorded errno 1003)", + sql: "CREATE EVENT TABLE v1 WITH CONTACT ( STEWARD = v1 ) ;", + expected_kind: None, + }, + ]; + for test_case in test_cases { + assert_eq!( + snowflake_kind(test_case.sql), + test_case.expected_kind.map(str::to_owned), + "{}", + test_case.description + ); + } +} From 699964500a042dfac118f2cd1e791a6a39365b5f Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 07:45:42 +0000 Subject: [PATCH 06/10] chore(syntax-coverage): record what the privilege, variable, describe, warehouse and event table fixes cleared The receipt disagreements fall from 618 to 583 entries, none added. --- coverage/syntax/baseline.json | 132 ++++++++++----------- coverage/syntax/receipt-disagreements.toml | 51 -------- 2 files changed, 62 insertions(+), 121 deletions(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 3e5c801a6..4af7e60f5 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -13167,6 +13167,8 @@ "sf.ddl.alter-openflow-connector.pull.o007", "sf.ddl.alter-openflow-connector.push-username-password-name.o002", "sf.ddl.alter-openflow-connector.push-username-password-name.o004", + "sf.ddl.alter-openflow-connector.push-username-password-name.o007", + "sf.ddl.alter-openflow-connector.push-username-password-name.o009", "sf.ddl.alter-openflow-connector.push-username-password-name.o010", "sf.ddl.alter-openflow-connector.push-username-password-name.o013", "sf.ddl.alter-openflow-connector.push-username-password-name.o016", @@ -13175,6 +13177,7 @@ "sf.ddl.alter-openflow-connector.push-username-password-name.o027", "sf.ddl.alter-openflow-connector.push-username-password-name.o028", "sf.ddl.alter-openflow-connector.push-username-password-name.o029", + "sf.ddl.alter-openflow-connector.push-username-password-name.o030", "sf.ddl.alter-openflow-connector.push-username-password-name.o031", "sf.ddl.alter-openflow-connector.push-username-password-name.o032", "sf.ddl.alter-openflow-connector.push-username-password-name.o033", @@ -19565,23 +19568,33 @@ "sf.ddl.alter-warehouse.abort-all-queries.o007", "sf.ddl.alter-warehouse.abort-all-queries.o008", "sf.ddl.alter-warehouse.abort-all-queries.o010", + "sf.ddl.alter-warehouse.abort-all-queries.o011", "sf.ddl.alter-warehouse.abort-all-queries.o012", + "sf.ddl.alter-warehouse.add-tables.o004", "sf.ddl.alter-warehouse.add-tables.o006", + "sf.ddl.alter-warehouse.add-tables.o007", + "sf.ddl.alter-warehouse.add-tables.o009", "sf.ddl.alter-warehouse.add-tables.o012", "sf.ddl.alter-warehouse.add-tables.o013", "sf.ddl.alter-warehouse.add-tables.o014", + "sf.ddl.alter-warehouse.add-tables.o015", "sf.ddl.alter-warehouse.add-tables.o016", "sf.ddl.alter-warehouse.add-tables.o017", + "sf.ddl.alter-warehouse.drop-tables.o004", "sf.ddl.alter-warehouse.drop-tables.o006", + "sf.ddl.alter-warehouse.drop-tables.o007", + "sf.ddl.alter-warehouse.drop-tables.o009", "sf.ddl.alter-warehouse.drop-tables.o012", "sf.ddl.alter-warehouse.drop-tables.o013", "sf.ddl.alter-warehouse.drop-tables.o014", + "sf.ddl.alter-warehouse.drop-tables.o015", "sf.ddl.alter-warehouse.drop-tables.o016", "sf.ddl.alter-warehouse.drop-tables.o017", "sf.ddl.alter-warehouse.enable-disable.o006", "sf.ddl.alter-warehouse.enable-disable.o009", "sf.ddl.alter-warehouse.enable-disable.o010", "sf.ddl.alter-warehouse.enable-disable.o011", + "sf.ddl.alter-warehouse.rename-to.o004", "sf.ddl.alter-warehouse.rename-to.o006", "sf.ddl.alter-warehouse.rename-to.o007", "sf.ddl.alter-warehouse.rename-to.o009", @@ -19635,6 +19648,7 @@ "sf.ddl.alter-warehouse.set.o125", "sf.ddl.alter-warehouse.set.o126", "sf.ddl.alter-warehouse.set.o127", + "sf.ddl.alter-warehouse.set-tag.o004", "sf.ddl.alter-warehouse.set-tag.o006", "sf.ddl.alter-warehouse.set-tag.o009", "sf.ddl.alter-warehouse.set-tag.o010", @@ -19647,11 +19661,15 @@ "sf.ddl.alter-warehouse.suspend-resume.o015", "sf.ddl.alter-warehouse.suspend-resume.o019", "sf.ddl.alter-warehouse.unset.o006", + "sf.ddl.alter-warehouse.unset.o010", + "sf.ddl.alter-warehouse.unset.o012", "sf.ddl.alter-warehouse.unset.o015", "sf.ddl.alter-warehouse.unset.o016", "sf.ddl.alter-warehouse.unset.o017", "sf.ddl.alter-warehouse.unset.o018", + "sf.ddl.alter-warehouse.unset-tag.o004", "sf.ddl.alter-warehouse.unset-tag.o006", + "sf.ddl.alter-warehouse.unset-tag.o009", "sf.ddl.alter-warehouse.unset-tag.o012", "sf.ddl.alter-warehouse.unset-tag.o013", "sf.ddl.alter-warehouse.unset-tag.o014", @@ -41253,8 +41271,13 @@ "sf.ddl.create-type.o022", "sf.ddl.create-type.o023", "sf.ddl.create-type.o024", + "sf.ddl.create-variable.o006", "sf.ddl.create-variable.o008", + "sf.ddl.create-variable.o009", + "sf.ddl.create-variable.o011", + "sf.ddl.create-variable.o014", "sf.ddl.create-variable.o018", + "sf.ddl.create-variable.o020", "sf.ddl.create-variable.o021", "sf.ddl.create-variable.o023", "sf.ddl.create-variable.o024", @@ -42084,16 +42107,20 @@ "sf.ddl.desc-function-dmf.o006", "sf.ddl.desc-function-dmf.o007", "sf.ddl.desc-function-dmf.o008", + "sf.ddl.desc-function-dmf.o009", "sf.ddl.desc-function-dmf.o010", "sf.ddl.desc-function-dmf.o011", "sf.ddl.desc-function-dmf.o013", "sf.ddl.desc-function-dmf.o015", + "sf.ddl.desc-function-dmf.o016", "sf.ddl.desc-function-dmf.o018", "sf.ddl.desc-function-dmf.o020", "sf.ddl.desc-function-dmf.o021", "sf.ddl.desc-function-dmf.o022", "sf.ddl.desc-function-dmf.o023", + "sf.ddl.desc-function-dmf.o024", "sf.ddl.desc-function-dmf.o025", + "sf.ddl.desc-function-dmf.o026", "sf.ddl.desc-function-dmf.o027", "sf.ddl.desc-function-dmf.o028", "sf.ddl.desc-function-dmf.o030", @@ -120212,10 +120239,13 @@ "sf.ddl.alter-openflow-connector.pull.kf3bf9eab4083", "sf.ddl.alter-openflow-connector.pull.kf4162495d385", "sf.ddl.alter-openflow-connector.push-username-password-name.k0525157478ad", + "sf.ddl.alter-openflow-connector.push-username-password-name.k17cce82d6804", "sf.ddl.alter-openflow-connector.push-username-password-name.k196381fd3c07", "sf.ddl.alter-openflow-connector.push-username-password-name.k3c3ae4ae35da", "sf.ddl.alter-openflow-connector.push-username-password-name.k5ec5c23c2a8e", "sf.ddl.alter-openflow-connector.push-username-password-name.k76541f4239e0", + "sf.ddl.alter-openflow-connector.push-username-password-name.k848f558ff405", + "sf.ddl.alter-openflow-connector.push-username-password-name.k8d011b9d08e8", "sf.ddl.alter-openflow-connector.push-username-password-name.k8fe67d92cd9a", "sf.ddl.alter-openflow-connector.push-username-password-name.k9a91229f46e1", "sf.ddl.alter-openflow-connector.push-username-password-name.k9d8abb2e4109", @@ -122906,20 +122936,29 @@ "sf.ddl.alter-warehouse.abort-all-queries.k1d429f7ebbd6", "sf.ddl.alter-warehouse.abort-all-queries.k4c31af27d5bc", "sf.ddl.alter-warehouse.abort-all-queries.k60bc63d76b60", + "sf.ddl.alter-warehouse.abort-all-queries.k71191b2fbfe6", "sf.ddl.alter-warehouse.abort-all-queries.kb5ec8d5b0e43", "sf.ddl.alter-warehouse.add-tables.k03a3c4082fff", + "sf.ddl.alter-warehouse.add-tables.k0add3b7ab01d", "sf.ddl.alter-warehouse.add-tables.k0d8380a5561d", + "sf.ddl.alter-warehouse.add-tables.k22a4a06e0b15", "sf.ddl.alter-warehouse.add-tables.k42168bc94c03", "sf.ddl.alter-warehouse.add-tables.k4fbb9449c1ee", + "sf.ddl.alter-warehouse.add-tables.k82c79cc80548", "sf.ddl.alter-warehouse.add-tables.k8f27f00d2c11", "sf.ddl.alter-warehouse.add-tables.k9a52c8e82a7f", "sf.ddl.alter-warehouse.add-tables.ka914804e7034", + "sf.ddl.alter-warehouse.add-tables.kd23873c7924c", "sf.ddl.alter-warehouse.add-tables.kf94a691897f9", + "sf.ddl.alter-warehouse.drop-tables.k0467ae54bde3", + "sf.ddl.alter-warehouse.drop-tables.k18cd7b807795", "sf.ddl.alter-warehouse.drop-tables.k4739d5773b9f", "sf.ddl.alter-warehouse.drop-tables.k6b1cdba72b9f", "sf.ddl.alter-warehouse.drop-tables.k75b39332a334", + "sf.ddl.alter-warehouse.drop-tables.k83d39159180e", "sf.ddl.alter-warehouse.drop-tables.k8a6718a65dce", "sf.ddl.alter-warehouse.drop-tables.k8e6b0c5f8574", + "sf.ddl.alter-warehouse.drop-tables.kb199babc8141", "sf.ddl.alter-warehouse.drop-tables.kdab03ef4430a", "sf.ddl.alter-warehouse.drop-tables.kde71d49a03bd", "sf.ddl.alter-warehouse.enable-disable.k3606fd06e2d4", @@ -122932,11 +122971,13 @@ "sf.ddl.alter-warehouse.rename-to.k61fec019cc2f", "sf.ddl.alter-warehouse.rename-to.k6979469ec6b8", "sf.ddl.alter-warehouse.rename-to.k982e4bf3e215", + "sf.ddl.alter-warehouse.rename-to.kacbfb3c46117", "sf.ddl.alter-warehouse.rename-to.kc0ce43bdd4b7", "sf.ddl.alter-warehouse.rename-to.kdcefaa8b22c4", "sf.ddl.alter-warehouse.rename-to.ke64d791244df", "sf.ddl.alter-warehouse.set-tag.k21e1bf6e43c2", "sf.ddl.alter-warehouse.set-tag.k298a422cc4a9", + "sf.ddl.alter-warehouse.set-tag.k5929dd7f75d5", "sf.ddl.alter-warehouse.set-tag.k71a2be51e95d", "sf.ddl.alter-warehouse.set-tag.k8af7b635297a", "sf.ddl.alter-warehouse.set-tag.ka345e68c8516", @@ -122973,7 +123014,9 @@ "sf.ddl.alter-warehouse.suspend-resume.k8411a8616fff", "sf.ddl.alter-warehouse.suspend-resume.kd890231d883b", "sf.ddl.alter-warehouse.suspend-resume.ke3e27143e7ef", + "sf.ddl.alter-warehouse.unset-tag.k1d78d7976e06", "sf.ddl.alter-warehouse.unset-tag.k70d7cec28330", + "sf.ddl.alter-warehouse.unset-tag.k806f1c1561f7", "sf.ddl.alter-warehouse.unset-tag.k91a3a3a80075", "sf.ddl.alter-warehouse.unset-tag.kbe8895402555", "sf.ddl.alter-warehouse.unset-tag.kce5b7c4a3e75", @@ -122984,6 +123027,7 @@ "sf.ddl.alter-warehouse.unset.k6a5a0b1c06a3", "sf.ddl.alter-warehouse.unset.kd1532ababeb8", "sf.ddl.alter-warehouse.unset.kef1b67ad9230", + "sf.ddl.alter-warehouse.unset.kf2a072236596", "sf.ddl.comment.column-is.k4d0297ff2908", "sf.ddl.comment.column-is.k7d7ee01f497a", "sf.ddl.comment.column-is.kb3a732ef6782", @@ -124744,6 +124788,7 @@ "sf.ddl.create-event-table.table.k359eeedfa7db", "sf.ddl.create-event-table.table.k3ae57e51db14", "sf.ddl.create-event-table.table.k3bdb6bf7d5ec", + "sf.ddl.create-event-table.table.k3db3965dad10", "sf.ddl.create-event-table.table.k3e28e0df5845", "sf.ddl.create-event-table.table.k3e70ea71a829", "sf.ddl.create-event-table.table.k57a566efe54d", @@ -124767,15 +124812,19 @@ "sf.ddl.create-event-table.table.k904f242a48aa", "sf.ddl.create-event-table.table.ka36798c33073", "sf.ddl.create-event-table.table.ka3b23797fcb2", + "sf.ddl.create-event-table.table.ka4565655794b", "sf.ddl.create-event-table.table.ka75d5090124d", "sf.ddl.create-event-table.table.kafb92df98af9", + "sf.ddl.create-event-table.table.kb2b289150635", "sf.ddl.create-event-table.table.kb8443a3fd95f", "sf.ddl.create-event-table.table.kbb725610ada1", + "sf.ddl.create-event-table.table.kbeab4331574d", "sf.ddl.create-event-table.table.kc65988c56776", "sf.ddl.create-event-table.table.kca58640f3090", "sf.ddl.create-event-table.table.kd0631a46f73a", "sf.ddl.create-event-table.table.kd6769254a7c6", "sf.ddl.create-event-table.table.ke7e3da2e2d4c", + "sf.ddl.create-event-table.table.ke81a17d6f572", "sf.ddl.create-event-table.table.kec2839b42c59", "sf.ddl.create-event-table.table.keed455571aaa", "sf.ddl.create-event-table.table.kf40bc014a314", @@ -131086,12 +131135,17 @@ "sf.ddl.create-type.kc2081aad6457", "sf.ddl.create-type.kcf5fcae1b378", "sf.ddl.create-type.keb7da55a8282", + "sf.ddl.create-variable.k1a1d69c5fb25", "sf.ddl.create-variable.k50bb1ce2b0ef", "sf.ddl.create-variable.k609a2da1d0c3", + "sf.ddl.create-variable.k8b65a378a2fb", + "sf.ddl.create-variable.ka0c8ed100821", "sf.ddl.create-variable.kc0afd919c73e", + "sf.ddl.create-variable.kc4bd146749db", "sf.ddl.create-variable.kc55613629c2e", "sf.ddl.create-variable.ke1b3217b5209", "sf.ddl.create-variable.ke716257d63d0", + "sf.ddl.create-variable.kfe10f90fd69b", "sf.ddl.create-versioned-schema.k0f8a0d9319a6", "sf.ddl.create-versioned-schema.k26b317465ba2", "sf.ddl.create-versioned-schema.k31ca47c1aa2f", @@ -131404,12 +131458,16 @@ "sf.ddl.desc-function-dmf.k240484b1bc83", "sf.ddl.desc-function-dmf.k2607eb33872f", "sf.ddl.desc-function-dmf.k2f4d77e3a90e", + "sf.ddl.desc-function-dmf.k358fb74c2360", + "sf.ddl.desc-function-dmf.k42c557d0bde0", + "sf.ddl.desc-function-dmf.k437132777c20", "sf.ddl.desc-function-dmf.k4e714180eb92", "sf.ddl.desc-function-dmf.k51772a3008f4", "sf.ddl.desc-function-dmf.k5d95ef73313b", "sf.ddl.desc-function-dmf.k8f8a92a6d949", "sf.ddl.desc-function-dmf.k9bb4c9e456de", "sf.ddl.desc-function-dmf.k9c487588b515", + "sf.ddl.desc-function-dmf.kaa2c81b91f40", "sf.ddl.desc-function-dmf.kad9129dc99b1", "sf.ddl.desc-function-dmf.kbc5ac5be070d", "sf.ddl.desc-function-dmf.kbe644765674c", @@ -133224,7 +133282,11 @@ "sf.ddl.show-views.kc7126070110b", "sf.ddl.show-views.ke18c744f3dc1", "sf.ddl.show-warehouses.k10c37dcf7d25", + "sf.ddl.show-warehouses.k60bb276ffb47", + "sf.ddl.show-warehouses.k9b013a14443f", "sf.ddl.show-warehouses.ka21c8c0da6b6", + "sf.ddl.show-warehouses.ka3980f8f2cf6", + "sf.ddl.show-warehouses.kb3ccb1d89a97", "sf.ddl.show-warehouses.kd39cf9e19af6", "sf.ddl.show-warehouses.kdfd687c7082b", "sf.ddl.show-warehouses.kf2acb7891093", @@ -149001,9 +149063,6 @@ "sf.ddl.alter-database.unset-data-retention-time-in-days-max-data-extension-time-in-days-stage-undrop-retention-time-in-days.k4a5bcb72e4bd", "sf.ddl.alter-database.unset-data-retention-time-in-days-max-data-extension-time-in-days-stage-undrop-retention-time-in-days.k5c0f60c6cde2", "sf.ddl.alter-iceberg-table.unset.ke33c9a12af90", - "sf.ddl.alter-openflow-connector.push-username-password-name.k17cce82d6804", - "sf.ddl.alter-openflow-connector.push-username-password-name.k848f558ff405", - "sf.ddl.alter-openflow-connector.push-username-password-name.k8d011b9d08e8", "sf.ddl.alter-openflow-deployment.rename-to.k1dd7f9ba81fc", "sf.ddl.alter-openflow-deployment.terminate.kf3b26f2f6a13", "sf.ddl.alter-openflow-deployment.upgrade.k8f0dad70d584", @@ -149016,20 +149075,6 @@ "sf.ddl.alter-tag.set.k7fdfe7d53553", "sf.ddl.alter-task.set.k40c1b10b46dd", "sf.ddl.alter-task.set.k98072043c837", - "sf.ddl.alter-warehouse.abort-all-queries.k71191b2fbfe6", - "sf.ddl.alter-warehouse.add-tables.k0add3b7ab01d", - "sf.ddl.alter-warehouse.add-tables.k22a4a06e0b15", - "sf.ddl.alter-warehouse.add-tables.k82c79cc80548", - "sf.ddl.alter-warehouse.add-tables.kd23873c7924c", - "sf.ddl.alter-warehouse.drop-tables.k0467ae54bde3", - "sf.ddl.alter-warehouse.drop-tables.k18cd7b807795", - "sf.ddl.alter-warehouse.drop-tables.k83d39159180e", - "sf.ddl.alter-warehouse.drop-tables.kb199babc8141", - "sf.ddl.alter-warehouse.rename-to.kacbfb3c46117", - "sf.ddl.alter-warehouse.set-tag.k5929dd7f75d5", - "sf.ddl.alter-warehouse.unset-tag.k1d78d7976e06", - "sf.ddl.alter-warehouse.unset-tag.k806f1c1561f7", - "sf.ddl.alter-warehouse.unset.kf2a072236596", "sf.ddl.comment.is.ke40ebb8a5793", "sf.ddl.create-agent.k2d726daf323d", "sf.ddl.create-agent.k53c176a344e9", @@ -149050,11 +149095,6 @@ "sf.ddl.create-dataset.keb74c1e13fa8", "sf.ddl.create-dbt-project.k5122c8e1ce71", "sf.ddl.create-dbt-project.ka1910fdd6a39", - "sf.ddl.create-event-table.table.k3db3965dad10", - "sf.ddl.create-event-table.table.ka4565655794b", - "sf.ddl.create-event-table.table.kb2b289150635", - "sf.ddl.create-event-table.table.kbeab4331574d", - "sf.ddl.create-event-table.table.ke81a17d6f572", "sf.ddl.create-file-format.create-file-format.k157043357740", "sf.ddl.create-file-format.create-or-alter-file.k63c67a765cde", "sf.ddl.create-hybrid-table.table.k5069c51ae2f1", @@ -149098,18 +149138,9 @@ "sf.ddl.create-table.define-table.ke1f3c185cda6", "sf.ddl.create-task-graph.create-or-alter-task.k6122231c287a", "sf.ddl.create-task-graph.create-task-graph.ka874e1616f5f", - "sf.ddl.create-variable.k1a1d69c5fb25", - "sf.ddl.create-variable.k8b65a378a2fb", - "sf.ddl.create-variable.ka0c8ed100821", - "sf.ddl.create-variable.kc4bd146749db", - "sf.ddl.create-variable.kfe10f90fd69b", "sf.ddl.create-versioned-schema.ke67978ccde94", "sf.ddl.create-versioned-schema.kec07de1bbc4f", "sf.ddl.desc-external-table.kcc6e9e00e915", - "sf.ddl.desc-function-dmf.k358fb74c2360", - "sf.ddl.desc-function-dmf.k42c557d0bde0", - "sf.ddl.desc-function-dmf.k437132777c20", - "sf.ddl.desc-function-dmf.kaa2c81b91f40", "sf.ddl.desc-table.k377b2974e7ea", "sf.ddl.drop-iceberg-table.k0c6d88e813a7", "sf.ddl.show-cortex-search.k71bbf0e325e7", @@ -149119,10 +149150,6 @@ "sf.ddl.show-primary-keys.k2b9e878033da", "sf.ddl.show-primary-keys.k5e02277ae099", "sf.ddl.show-schema-variables.k9212c756ceed", - "sf.ddl.show-warehouses.k60bb276ffb47", - "sf.ddl.show-warehouses.k9b013a14443f", - "sf.ddl.show-warehouses.ka3980f8f2cf6", - "sf.ddl.show-warehouses.kb3ccb1d89a97", "sf.expressions.data-types-numeric.double.kcf1c9c4b00d8", "sf.expressions.data-types-text.string.kaa398b570613", "sf.expressions.session-variables.ka6236ae06564", @@ -149992,9 +150019,6 @@ "sf.ddl.alter-materialized-view.rename-to-cluster-by.k0b93e15e7deb", "sf.ddl.alter-online-feature-table.table-set-comment.ke7fec7c4938e", "sf.ddl.alter-online-feature-table.table-set.k56f6bb4df5ba", - "sf.ddl.alter-openflow-connector.push-username-password-name.k17cce82d6804", - "sf.ddl.alter-openflow-connector.push-username-password-name.k848f558ff405", - "sf.ddl.alter-openflow-connector.push-username-password-name.k8d011b9d08e8", "sf.ddl.alter-openflow-deployment.rename-to.k1dd7f9ba81fc", "sf.ddl.alter-openflow-deployment.terminate.kf3b26f2f6a13", "sf.ddl.alter-openflow-deployment.upgrade.k8f0dad70d584", @@ -150013,20 +150037,6 @@ "sf.ddl.alter-task.set.k98072043c837", "sf.ddl.alter-task.set.kcae5464fa8dc", "sf.ddl.alter-task.set.ke6170e5781ec", - "sf.ddl.alter-warehouse.abort-all-queries.k71191b2fbfe6", - "sf.ddl.alter-warehouse.add-tables.k0add3b7ab01d", - "sf.ddl.alter-warehouse.add-tables.k22a4a06e0b15", - "sf.ddl.alter-warehouse.add-tables.k82c79cc80548", - "sf.ddl.alter-warehouse.add-tables.kd23873c7924c", - "sf.ddl.alter-warehouse.drop-tables.k0467ae54bde3", - "sf.ddl.alter-warehouse.drop-tables.k18cd7b807795", - "sf.ddl.alter-warehouse.drop-tables.k83d39159180e", - "sf.ddl.alter-warehouse.drop-tables.kb199babc8141", - "sf.ddl.alter-warehouse.rename-to.kacbfb3c46117", - "sf.ddl.alter-warehouse.set-tag.k5929dd7f75d5", - "sf.ddl.alter-warehouse.unset-tag.k1d78d7976e06", - "sf.ddl.alter-warehouse.unset-tag.k806f1c1561f7", - "sf.ddl.alter-warehouse.unset.kf2a072236596", "sf.ddl.comment.is.k0e2c4f54c25f", "sf.ddl.comment.is.k1e03d7bb5560", "sf.ddl.comment.is.k3a07bff3053a", @@ -150051,11 +150061,6 @@ "sf.ddl.create-dataset.keb74c1e13fa8", "sf.ddl.create-dbt-project.k5122c8e1ce71", "sf.ddl.create-dbt-project.ka1910fdd6a39", - "sf.ddl.create-event-table.table.k3db3965dad10", - "sf.ddl.create-event-table.table.ka4565655794b", - "sf.ddl.create-event-table.table.kb2b289150635", - "sf.ddl.create-event-table.table.kbeab4331574d", - "sf.ddl.create-event-table.table.ke81a17d6f572", "sf.ddl.create-external-function.function-returns-api-integration-as.k007dcc7f5614", "sf.ddl.create-external-function.function-returns-api-integration-as.k4114dc0df61e", "sf.ddl.create-external-function.function-returns-api-integration-as.k96790db21363", @@ -150148,21 +150153,12 @@ "sf.ddl.create-task-graph.create-task-graph.kd13126acf55e", "sf.ddl.create-task-graph.define-task-graph.k5cd0dde827c9", "sf.ddl.create-task-graph.define-task-graph.k8e6162f9a5c1", - "sf.ddl.create-variable.k1a1d69c5fb25", - "sf.ddl.create-variable.k8b65a378a2fb", - "sf.ddl.create-variable.ka0c8ed100821", - "sf.ddl.create-variable.kc4bd146749db", - "sf.ddl.create-variable.kfe10f90fd69b", "sf.ddl.create-versioned-schema.ke67978ccde94", "sf.ddl.create-versioned-schema.kec07de1bbc4f", "sf.ddl.desc-artifact-repository.k9335d9e88b41", "sf.ddl.desc-external-table.kc7239ad11afd", "sf.ddl.desc-external-table.kcc6e9e00e915", "sf.ddl.desc-external-volume.k8281ca3b2f50", - "sf.ddl.desc-function-dmf.k358fb74c2360", - "sf.ddl.desc-function-dmf.k42c557d0bde0", - "sf.ddl.desc-function-dmf.k437132777c20", - "sf.ddl.desc-function-dmf.kaa2c81b91f40", "sf.ddl.desc-iceberg-table.k9625ac9edcba", "sf.ddl.desc-mcp-server.ke25b5a1e7257", "sf.ddl.desc-model-monitor.k8d852ca13b93", @@ -150213,10 +150209,6 @@ "sf.ddl.show-versions-in-listing.k48dbbfc4b2a6", "sf.ddl.show-versions-in-model.kae37a160c500", "sf.ddl.show-versions.k4929e4763764", - "sf.ddl.show-warehouses.k60bb276ffb47", - "sf.ddl.show-warehouses.k9b013a14443f", - "sf.ddl.show-warehouses.ka3980f8f2cf6", - "sf.ddl.show-warehouses.kb3ccb1d89a97", "sf.ddl.undrop-external-volume.kb557e7ff4586", "sf.expressions.data-types-numeric.double.kcf1c9c4b00d8", "sf.expressions.data-types-text.string.kaa398b570613", diff --git a/coverage/syntax/receipt-disagreements.toml b/coverage/syntax/receipt-disagreements.toml index 458c73ef5..4ca8bd2ef 100644 --- a/coverage/syntax/receipt-disagreements.toml +++ b/coverage/syntax/receipt-disagreements.toml @@ -351,11 +351,6 @@ other_receipts_contradicted = [ "k5c0f60c6cde2", ] "sf.ddl.alter-iceberg-table.unset" = ["ke33c9a12af90"] -"sf.ddl.alter-openflow-connector.push-username-password-name" = [ - "k17cce82d6804", - "k848f558ff405", - "k8d011b9d08e8", -] "sf.ddl.alter-openflow-deployment.rename-to" = ["k1dd7f9ba81fc"] "sf.ddl.alter-openflow-deployment.terminate" = ["kf3b26f2f6a13"] "sf.ddl.alter-openflow-deployment.upgrade" = ["k8f0dad70d584"] @@ -372,26 +367,6 @@ other_receipts_contradicted = [ "k40c1b10b46dd", "k98072043c837", ] -"sf.ddl.alter-warehouse.abort-all-queries" = ["k71191b2fbfe6"] -"sf.ddl.alter-warehouse.add-tables" = [ - "k0add3b7ab01d", - "k22a4a06e0b15", - "k82c79cc80548", - "kd23873c7924c", -] -"sf.ddl.alter-warehouse.drop-tables" = [ - "k0467ae54bde3", - "k18cd7b807795", - "k83d39159180e", - "kb199babc8141", -] -"sf.ddl.alter-warehouse.rename-to" = ["kacbfb3c46117"] -"sf.ddl.alter-warehouse.set-tag" = ["k5929dd7f75d5"] -"sf.ddl.alter-warehouse.unset" = ["kf2a072236596"] -"sf.ddl.alter-warehouse.unset-tag" = [ - "k1d78d7976e06", - "k806f1c1561f7", -] "sf.ddl.comment.is" = ["ke40ebb8a5793"] "sf.ddl.create-agent" = [ "k2d726daf323d", @@ -420,13 +395,6 @@ other_receipts_contradicted = [ "k5122c8e1ce71", "ka1910fdd6a39", ] -"sf.ddl.create-event-table.table" = [ - "k3db3965dad10", - "ka4565655794b", - "kb2b289150635", - "kbeab4331574d", - "ke81a17d6f572", -] "sf.ddl.create-file-format.create-file-format" = ["k157043357740"] "sf.ddl.create-file-format.create-or-alter-file" = ["k63c67a765cde"] "sf.ddl.create-hybrid-table.table" = ["k5069c51ae2f1"] @@ -486,24 +454,11 @@ other_receipts_contradicted = [ "sf.ddl.create-table.define-table" = ["ke1f3c185cda6"] "sf.ddl.create-task-graph.create-or-alter-task" = ["k6122231c287a"] "sf.ddl.create-task-graph.create-task-graph" = ["ka874e1616f5f"] -"sf.ddl.create-variable" = [ - "k1a1d69c5fb25", - "k8b65a378a2fb", - "ka0c8ed100821", - "kc4bd146749db", - "kfe10f90fd69b", -] "sf.ddl.create-versioned-schema" = [ "ke67978ccde94", "kec07de1bbc4f", ] "sf.ddl.desc-external-table" = ["kcc6e9e00e915"] -"sf.ddl.desc-function-dmf" = [ - "k358fb74c2360", - "k42c557d0bde0", - "k437132777c20", - "kaa2c81b91f40", -] "sf.ddl.desc-table" = ["k377b2974e7ea"] "sf.ddl.drop-iceberg-table" = ["k0c6d88e813a7"] "sf.ddl.show-cortex-search" = [ @@ -517,12 +472,6 @@ other_receipts_contradicted = [ "k5e02277ae099", ] "sf.ddl.show-schema-variables" = ["k9212c756ceed"] -"sf.ddl.show-warehouses" = [ - "k60bb276ffb47", - "k9b013a14443f", - "ka3980f8f2cf6", - "kb3ccb1d89a97", -] "sf.expressions.data-types-numeric.double" = ["kcf1c9c4b00d8"] "sf.expressions.data-types-text.string" = ["kaa398b570613"] "sf.expressions.session-variables" = ["ka6236ae06564"] From b854e3ae10e27eb2003d01853ed4c9ca65e1fe0b Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 08:09:43 +0000 Subject: [PATCH 07/10] chore(syntax-limits): add observed cases for the open EXECUTE IMMEDIATE, notebook name, event table contact and SHOW SERVICES questions --- coverage/syntax/limits.toml | 99 ++++++++++++++++++++++ coverage/syntax/obligations/ddl.toml | 49 +++++++++++ coverage/syntax/obligations/scripting.toml | 14 +++ coverage/syntax/obligations/utility.toml | 14 +++ 4 files changed, 176 insertions(+) diff --git a/coverage/syntax/limits.toml b/coverage/syntax/limits.toml index ac5200dec..6b6a99aea 100644 --- a/coverage/syntax/limits.toml +++ b/coverage/syntax/limits.toml @@ -84823,3 +84823,102 @@ anchor = "doc.sql.alter-event-routing-table / Syntax" sql = "ALTER EVENT ROUTING TABLE v1 SET RULE v1 = ( REGION_GROUP = 'g1' , REGIONS = ( 'm' ) , DESTINATION_ACCOUNT = v1 . v1 ) ;" expect = "observe" context = "raw" + +# PR J probes: EXECUTE IMMEDIATE in a parenthesised RESULTSET assignment, notebooks named project, +# event table CONTACT without WITH, and SHOW SERVICES OF TYPE placement. + +[[limit]] +form = "sf.scripting.let.let-resultset-default" +kind = "positive" +note = "RESULTSET := ( EXECUTE IMMEDIATE :q ), a bound query in parentheses" +anchor = "doc.snowflake-scripting.let / Syntax / RESULTSET assignment syntax" +sql = "LET r1 RESULTSET := ( EXECUTE IMMEDIATE :q1 ) ;" +expect = "observe" + +[[limit]] +form = "sf.scripting.let.let-resultset-default" +kind = "positive" +note = "RESULTSET := ( EXECUTE IMMEDIATE :q USING ( ... ) ), as the EXECUTE IMMEDIATE page shows" +anchor = "doc.snowflake-scripting.let / Syntax / RESULTSET assignment syntax" +sql = "LET r1 RESULTSET := ( EXECUTE IMMEDIATE :q1 USING ( v1 ) ) ;" +expect = "observe" + +[[limit]] +form = "sf.utility.execute-immediate.immediate" +kind = "positive" +note = "a source built with || from strings, observed" +anchor = "doc.sql.execute-immediate / Syntax" +sql = "EXECUTE IMMEDIATE 'SELECT ' || '1' ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.utility.execute-immediate.immediate" +kind = "positive" +note = "a bound variable as the source, observed" +anchor = "doc.sql.execute-immediate / Syntax" +sql = "EXECUTE IMMEDIATE :q1 ;" +expect = "observe" + +[[limit]] +form = "sf.ddl.create-notebook" +kind = "positive" +note = "a notebook named project, from a stage location string" +anchor = "doc.sql.create-notebook / Syntax" +sql = "CREATE NOTEBOOK project FROM '@d1.s1.st1' ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.ddl.create-notebook" +kind = "positive" +note = "a notebook named project, without FROM" +anchor = "doc.sql.create-notebook / Syntax" +sql = "CREATE NOTEBOOK project ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.ddl.create-notebook" +kind = "negative_neighbour" +note = "FROM an unquoted stage path in place of ''" +anchor = "doc.sql.create-notebook / Syntax" +sql = "CREATE NOTEBOOK v1 FROM @s1 ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.ddl.create-event-table.table" +kind = "negative_neighbour" +note = "CONTACT without WITH on an event table, observed" +anchor = "doc.sql.create-event-table / Syntax" +sql = "CREATE EVENT TABLE v1 CONTACT ( STEWARD = v1 ) ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.ddl.show-services" +kind = "positive" +note = "OF TYPE after IN COMPUTE POOL" +anchor = "doc.sql.show-services / Syntax" +sql = "SHOW SERVICES IN COMPUTE POOL v1 OF TYPE USER ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.ddl.show-services" +kind = "positive" +note = "OF TYPE with a list of types" +anchor = "doc.sql.show-services / Syntax" +sql = "SHOW SERVICES OF TYPE USER , JOB ;" +expect = "observe" +context = "raw" + +[[limit]] +form = "sf.ddl.show-services" +kind = "negative_neighbour" +note = "OF TYPE before LIMIT, observed" +anchor = "doc.sql.show-services / Syntax" +sql = "SHOW SERVICES OF TYPE USER LIMIT 1 ;" +expect = "observe" +context = "raw" diff --git a/coverage/syntax/obligations/ddl.toml b/coverage/syntax/obligations/ddl.toml index aafcce974..6857ad109 100644 --- a/coverage/syntax/obligations/ddl.toml +++ b/coverage/syntax/obligations/ddl.toml @@ -131580,6 +131580,13 @@ target = "[ , = ... ]" anchor = "doc.sql.create-event-table / Syntax" note = "the list continued at least once, observed" +[[obligation]] +id = "sf.ddl.create-event-table.table.o195" +kind = "negative_neighbour" +required = true +anchor = "doc.sql.create-event-table / Syntax" +note = "CONTACT without WITH on an event table, observed" + [[obligation]] id = "sf.ddl.create-event-table.table-clone.o001" kind = "positive" @@ -183836,6 +183843,27 @@ target = "IDLE_AUTO_SHUTDOWN_TIME_SECONDS = " anchor = "doc.sql.create-notebook / Parameters" note = "IDLE_AUTO_SHUTDOWN_TIME_SECONDS = 259,201 against the documented range 60 to 259,200" +[[obligation]] +id = "sf.ddl.create-notebook.o060" +kind = "positive" +required = true +anchor = "doc.sql.create-notebook / Syntax" +note = "a notebook named project, from a stage location string" + +[[obligation]] +id = "sf.ddl.create-notebook.o061" +kind = "positive" +required = true +anchor = "doc.sql.create-notebook / Syntax" +note = "a notebook named project, without FROM" + +[[obligation]] +id = "sf.ddl.create-notebook.o062" +kind = "negative_neighbour" +required = true +anchor = "doc.sql.create-notebook / Syntax" +note = "FROM an unquoted stage path in place of ''" + [[obligation]] id = "sf.ddl.create-notebook-project.from.o001" kind = "positive" @@ -299579,6 +299607,27 @@ target = " in [ IN { ACCOUNT | DATABASE | DATABASE Date: Fri, 13 Nov 2026 08:23:09 +0000 Subject: [PATCH 08/10] chore(syntax-coverage): pin the batch that records the EXECUTE IMMEDIATE, notebook name, event table contact and SHOW SERVICES questions --- coverage/syntax/marks/ddl.jsonl | 7 +++++++ coverage/syntax/marks/scripting.jsonl | 2 ++ coverage/syntax/marks/utility.jsonl | 1 + evidence.toml | 4 ++-- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/coverage/syntax/marks/ddl.jsonl b/coverage/syntax/marks/ddl.jsonl index 3b0eae6cf..dd0497b1f 100644 --- a/coverage/syntax/marks/ddl.jsonl +++ b/coverage/syntax/marks/ddl.jsonl @@ -1526,6 +1526,7 @@ {"case_id":"sf.ddl.create-event-table.table.kbcd8dd0ec68a","mark":"settled accept","obligations":["sf.ddl.create-event-table.table.o115"],"sql_sha256":"bcd8dd0ec68a85d138b00f3370a2a1f05f1149bbb89a492181df2830da51b849"} {"case_id":"sf.ddl.create-event-table.table.kbeab4331574d","mark":"documented","obligations":["sf.ddl.create-event-table.table.o193"],"sql_sha256":"beab4331574d9af613eb80bd7350d552bedf5518ccf0cd3791c2dd109242e5ed"} {"case_id":"sf.ddl.create-event-table.table.kd827debb9f77","mark":"settled accept","obligations":["sf.ddl.create-event-table.table.o042"],"sql_sha256":"d827debb9f77e371aba5e99d613ce61a0ebb562b497eaad113baa4b6f9092d4e"} +{"case_id":"sf.ddl.create-event-table.table.ke78f8f5c1856","mark":"settled reject","obligations":["sf.ddl.create-event-table.table.o195"],"sql_sha256":"e78f8f5c1856acf89638b92f72ac4f2e0530997c2a3e2667c48f0accf8997374"} {"case_id":"sf.ddl.create-event-table.table.ke81a17d6f572","mark":"documented","obligations":["sf.ddl.create-event-table.table.o192"],"sql_sha256":"e81a17d6f5729692cfc39331059d9ecfe7c1e58503400b08b1cd8f34d5712987"} {"case_id":"sf.ddl.create-external-agent.k6854f0d0eca1","mark":"documented","obligations":["sf.ddl.create-external-agent.o045"],"sql_sha256":"6854f0d0eca15eaf80c4e144c6fc92dabfe1eba5d8249d8796398826e622d545"} {"case_id":"sf.ddl.create-external-agent.k9cb1a65657fa","mark":"settled reject","obligations":["sf.ddl.create-external-agent.o018"],"sql_sha256":"9cb1a65657fab5acd12f3763551d97afc81f3ac56182a503ca316b1de4f4bd1e"} @@ -2121,10 +2122,13 @@ {"case_id":"sf.ddl.create-notebook-project.from.syntax.k8658fac18973","mark":"settled accept","obligations":["sf.ddl.create-notebook-project.from.syntax.o031"],"sql_sha256":"8658fac189739eb35bb522921fb9d36e5a2c7602a10c2c3181013d2f6b051157"} {"case_id":"sf.ddl.create-notebook-project.from.syntax.kacf90435b87a","mark":"settled accept","obligations":["sf.ddl.create-notebook-project.from.syntax.o017"],"sql_sha256":"acf90435b87a726816fdd3b167a19f738ff1bced092654fec587358817aef124"} {"case_id":"sf.ddl.create-notebook-project.from.syntax.kee7525779465","mark":"settled accept","obligations":["sf.ddl.create-notebook-project.from.syntax.o032"],"sql_sha256":"ee752577946543fa081fc85cdbd36544b5de160888a759a887623b4322092ac3"} +{"case_id":"sf.ddl.create-notebook.k29ba034d4e41","mark":"settled accept","obligations":["sf.ddl.create-notebook.o061"],"sql_sha256":"29ba034d4e41c9ce9b4a4ffee6cc25f3f7199c24f0be2f995bf4ca3f874c3efc"} {"case_id":"sf.ddl.create-notebook.k3b06983d8b60","mark":"settled accept","obligations":["sf.ddl.create-notebook.o059"],"sql_sha256":"3b06983d8b60c90eb2317b9ee4093472ea83bb2d8badca4543cf1845f4b3b4ae"} {"case_id":"sf.ddl.create-notebook.k46bcc90bdad6","mark":"settled accept","obligations":["sf.ddl.create-notebook.o054"],"sql_sha256":"46bcc90bdad6f7fe5eaa4cf8f66b8a85b8904cd03b1a8e4d8f13dbd158cd35a9"} {"case_id":"sf.ddl.create-notebook.k677b4f657abe","mark":"settled accept","obligations":["sf.ddl.create-notebook.o042"],"sql_sha256":"677b4f657abef7a7f985cb55f7b8151cc5d473750b55fbaf21a9fae41cf36784"} {"case_id":"sf.ddl.create-notebook.k84e1e6adbca3","mark":"settled accept","obligations":["sf.ddl.create-notebook.o018"],"sql_sha256":"84e1e6adbca38cffb14600a4f56f65ad5a19cc81c925fb6d3e2307e4cc19289d"} +{"case_id":"sf.ddl.create-notebook.k959cea8a8c07","mark":"settled accept","obligations":["sf.ddl.create-notebook.o062"],"sql_sha256":"959cea8a8c07d5cf24769a48a334df31188b3904ba8f8899428378d03c934dc1"} +{"case_id":"sf.ddl.create-notebook.k967415cf39d9","mark":"settled accept","obligations":["sf.ddl.create-notebook.o060"],"sql_sha256":"967415cf39d96a4d87f3f3c2a56192675cbc7a8702d91d69989132762317e1b6"} {"case_id":"sf.ddl.create-notebook.kc4367bfc5806","mark":"settled accept","obligations":["sf.ddl.create-notebook.o037"],"sql_sha256":"c4367bfc580619aad3f725c782f79c11b6e59e9931b8f1c17822c4ae6a059ad1"} {"case_id":"sf.ddl.create-notebook.ke9527c2872ef","mark":"settled accept","obligations":["sf.ddl.create-notebook.o032"],"sql_sha256":"e9527c2872efa48f247189caf5dd8dd4d10c395fe6a6134aa6ee622792931da4"} {"case_id":"sf.ddl.create-notebook.kf71b1b4702de","mark":"settled reject","obligations":["sf.ddl.create-notebook.o013"],"sql_sha256":"f71b1b4702de64447441cd5f40fb62dcca833a85abb6473ba247c88ca16a8d4e"} @@ -3424,10 +3428,13 @@ {"case_id":"sf.ddl.show-sequences.k03b465f19229","mark":"settled accept","obligations":["sf.ddl.show-sequences.o054"],"sql_sha256":"03b465f19229195d5e450be6dae73aa96a7d4d258f6c7c8bfb269cf771b027db"} {"case_id":"sf.ddl.show-sequences.ka48847641a88","mark":"settled reject","obligations":["sf.ddl.show-sequences.o006"],"sql_sha256":"a48847641a88ad4b4240ff99a981e7c1f638ded16ded857e1387850c3e634192"} {"case_id":"sf.ddl.show-service-volumes-in-service.k1a90530e5a33","mark":"settled accept","obligations":["sf.ddl.show-service-volumes-in-service.o010"],"sql_sha256":"1a90530e5a335001804303d54459d983cb3939cded1925eba3455b83c30aaaa6"} +{"case_id":"sf.ddl.show-services.k01db831ab566","mark":"settled accept","obligations":["sf.ddl.show-services.o070"],"sql_sha256":"01db831ab566c8f919c82bde795c39bb7a922e466bf3a6f05563149b8ef80d65"} {"case_id":"sf.ddl.show-services.k2b2a51e6a1b2","mark":"documented","obligations":["sf.ddl.show-services.o063"],"sql_sha256":"2b2a51e6a1b29c43ddecbdbe1fab4c48a3d2bba7c30898230592cee98b1b24e8"} +{"case_id":"sf.ddl.show-services.k5a4f57168e89","mark":"settled reject","obligations":["sf.ddl.show-services.o069"],"sql_sha256":"5a4f57168e8984cd6e1a19288172082bd4aeadbbbd6fb40fe499c23fe214a2ff"} {"case_id":"sf.ddl.show-services.k9840ef6666b1","mark":"settled reject","obligations":["sf.ddl.show-services.o010"],"sql_sha256":"9840ef6666b1002df65bd2742fe890e382c66b0e3a236563c63738abe57afaa4"} {"case_id":"sf.ddl.show-services.kbce8ef49cc6c","mark":"settled reject","obligations":["sf.ddl.show-services.o042"],"sql_sha256":"bce8ef49cc6c705c28b0e1c3faa3f38365aab8fe79d913709321d9a0168e093e"} {"case_id":"sf.ddl.show-services.kc00e9638a197","mark":"documented","obligations":["sf.ddl.show-services.o064"],"sql_sha256":"c00e9638a19730171e0d97b40fb41fb7e68af0f6562ecb4c9f448eb05d2f367e"} +{"case_id":"sf.ddl.show-services.kc51e4f2199da","mark":"settled accept","obligations":["sf.ddl.show-services.o071"],"sql_sha256":"c51e4f2199da871f15c246985412d7c389b807af2b9435c78b0cd63a05e17271"} {"case_id":"sf.ddl.show-services.kcdd9d23758af","mark":"settled reject","obligations":["sf.ddl.show-services.o033"],"sql_sha256":"cdd9d23758af87e55c9fc55a6c2831dcc865bd90405721a36304afd1de899f18"} {"case_id":"sf.ddl.show-services.kda3120334b6f","mark":"documented","obligations":["sf.ddl.show-services.o065"],"sql_sha256":"da3120334b6ffe4f96985d8cc828520f634bbe864a4df0105bc358a1c1d9ded6"} {"case_id":"sf.ddl.show-services.kf604c05f9bab","mark":"documented","obligations":["sf.ddl.show-services.o066"],"sql_sha256":"f604c05f9bab7b0ca41581d5345af98ed3fe0680c61f98e6f2cb42e6a1186cc6"} diff --git a/coverage/syntax/marks/scripting.jsonl b/coverage/syntax/marks/scripting.jsonl index c5f1f43e5..47d18d9a2 100644 --- a/coverage/syntax/marks/scripting.jsonl +++ b/coverage/syntax/marks/scripting.jsonl @@ -1 +1,3 @@ {"case_id":"sf.scripting.declare.exception.k8f071055548a","mark":"settled reject","obligations":["sf.scripting.declare.exception.o012"],"sql_sha256":"8f071055548a2219ef447f66fd993aad49eaa9a32940d5625e5a1cf21cd801d4"} +{"case_id":"sf.scripting.let.let-resultset-default.k753318a195f7","mark":"settled accept","obligations":["sf.scripting.let.let-resultset-default.o021"],"sql_sha256":"753318a195f75c4fa1566d558e79ec7048e8212215e922d4100f3d8511279632"} +{"case_id":"sf.scripting.let.let-resultset-default.k7b7880ab4b89","mark":"settled accept","obligations":["sf.scripting.let.let-resultset-default.o020"],"sql_sha256":"7b7880ab4b895b2916cfc0e062750b06ef3087817f3aae6b2793a4e09d5c1143"} diff --git a/coverage/syntax/marks/utility.jsonl b/coverage/syntax/marks/utility.jsonl index 433f35f08..bf7666c09 100644 --- a/coverage/syntax/marks/utility.jsonl +++ b/coverage/syntax/marks/utility.jsonl @@ -117,6 +117,7 @@ {"case_id":"sf.utility.execute-immediate-from.kb4598310cf27","mark":"settled accept","obligations":["sf.utility.execute-immediate-from.o060"],"sql_sha256":"b4598310cf2781240611fd0435b460504b835cdeca7e5eed122fcb5574fb25e2"} {"case_id":"sf.utility.execute-immediate-from.kd2b2dee1a470","mark":"documented","obligations":["sf.utility.execute-immediate-from.o062"],"sql_sha256":"d2b2dee1a4701e6cc51d9e5e50d1b2d79ec1a3bd371b78416ebf1078572ed332"} {"case_id":"sf.utility.execute-immediate-from.kea3e07c355cb","mark":"documented","obligations":["sf.utility.execute-immediate-from.o061"],"sql_sha256":"ea3e07c355cb526767dc3aaeb1ce33b4830a257834719d1ecf73f66e4fb306ac"} +{"case_id":"sf.utility.execute-immediate.immediate.k4c5f8b188cfd","mark":"settled accept","obligations":["sf.utility.execute-immediate.immediate.o016"],"sql_sha256":"4c5f8b188cfd855397364f0c4ad8a5d0d3327771348c8ec939e7478750e08ac0"} {"case_id":"sf.utility.execute-inference-job-service.k080ac57d3454","mark":"settled accept","obligations":["sf.utility.execute-inference-job-service.o090"],"sql_sha256":"080ac57d3454465c3841b091b601ff54ccba61f067d1ef178222d142809850ac"} {"case_id":"sf.utility.execute-inference-job-service.k0df083441c69","mark":"settled accept","obligations":["sf.utility.execute-inference-job-service.o091"],"sql_sha256":"0df083441c69924440dbf9c710aed0c73c03fcd91e91597963a57a9c688d44c8"} {"case_id":"sf.utility.execute-inference-job-service.k316caebc5c85","mark":"settled reject","obligations":["sf.utility.execute-inference-job-service.o042"],"sql_sha256":"316caebc5c85e04cad33d13a4c53c9cc329b371443c730b50a62d1efd9f96a14"} diff --git a/evidence.toml b/evidence.toml index cb7431415..3d800c841 100644 --- a/evidence.toml +++ b/evidence.toml @@ -1,4 +1,4 @@ # The evidence SQLQuack's checks read: one commit of the evidence repository, and the SHA-256 of its files. repository = "https://github.com/sqlstack-io/sqlquack-evidence.git" -commit = "ad6c152e45fb57007238e44c2b91f69504290b4e" -content_sha256 = "1c35caff78e18c01ba3934c0c27b109867b5a7efcc46637badaf45b71a2f88d3" +commit = "7f110c2b9fbadfab94fa7618cd7f6b6b8955a364" +content_sha256 = "408215e5850c9444e823cff6f3bdb0723499e69d0dddfc23c10700dbc73eaabe" From 9811249e6de193c2827da96cf5397b84c82cb92c Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 08:23:09 +0000 Subject: [PATCH 09/10] fix(syntax): follow the recorded RESULTSET, notebook name and SHOW SERVICES verdicts An EXECUTE IMMEDIATE inside a parenthesised RESULTSET assignment now ends before the closing parenthesis, so LET can take it. A notebook may be named PROJECT when its name ends the statement or FROM follows. SHOW SERVICES reads OF TYPE straight after the kind, where Snowflake accepts it, and refuses it after IN. --- .../parser/_helpers/ddl/snowflake_commands.rs | 12 +++--- .../parser/_helpers/ddl/snowflake_opaque.rs | 11 ++++- .../src/parser/_helpers/ddl/snowflake_show.rs | 30 ++++++------- .../src/parser/_helpers/statements/entry.rs | 4 +- .../parser/_helpers/statements/sessions.rs | 13 +++++- .../test_snowflake_receipted_objects.rs | 43 +++++++++++++++++-- 6 files changed, 83 insertions(+), 30 deletions(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_commands.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_commands.rs index c2f2cf45b..0f1afb784 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_commands.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_commands.rs @@ -19,10 +19,10 @@ use sqlquack_syntax::tokens::types::Result; use sqlquack_syntax::traversal::types::ExpressionWalk; impl Parser { - /// In Snowflake, refuse an EXECUTE IMMEDIATE, read after EXECUTE, that is neither `IMMEDIATE [ USING ( [ , ... ] ) ]` nor `IMMEDIATE FROM [ USING ( => [ , ... ] ) ] [ DRY_RUN = { TRUE | FALSE } ]`; the cursor ends where it started. - pub(crate) fn check_execute_immediate(&mut self) -> Result<()> { + /// In Snowflake, refuse an EXECUTE IMMEDIATE, read after EXECUTE, that is neither `IMMEDIATE [ USING ( [ , ... ] ) ]` nor `IMMEDIATE FROM [ USING ( => [ , ... ] ) ] [ DRY_RUN = { TRUE | FALSE } ]`, and return the index of the token that ends it, a `)` closing an enclosing assignment included; the cursor ends where it started. + pub(crate) fn check_execute_immediate(&mut self) -> Result> { if !self.applies_snowflake_context_rules() { - return Ok(()); + return Ok(None); } let start = self.current; let checked = self.check_execute_immediate_parts(); @@ -53,7 +53,7 @@ impl Parser { Err(self.parse_error("Expected the statement to execute")) } - fn check_execute_immediate_parts(&mut self) -> Result<()> { + fn check_execute_immediate_parts(&mut self) -> Result> { self.skip(); let from = self.match_token(TokenType::From); if from { @@ -87,8 +87,8 @@ impl Parser { return Err(self.parse_error("Expected TRUE or FALSE")); } } - match self.is_statement_end_at(0) { - true => Ok(()), + match self.is_statement_end_at(0) || self.check(TokenType::RParen) { + true => Ok(Some(self.current)), false => Err(self.parse_error("Expected the end of EXECUTE IMMEDIATE")), } } diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs index 77e37bff9..b184276ef 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_opaque.rs @@ -49,7 +49,7 @@ impl Parser { self.current = after_name; return checked; } - let project = matches!(second.as_str(), "PROJECT"); + let project = matches!(second.as_str(), "PROJECT") && after_name > kind_at + 2; let checked = match kind.as_str() { "EXTERNAL" if matches!(second.as_str(), "AGENT") => self.check_external_agent_tail(), "VARIABLE" => self.check_variable_tail(), @@ -296,7 +296,7 @@ impl Parser { .is_some_and(|next| next.text.eq_ignore_ascii_case("VERSION"))) } - /// The kind, `IF [ NOT ] EXISTS` and name of a kind the opaque check knows, a notebook project's name with its database left out, then an ALTER's action; nothing for another kind. + /// The kind, `IF [ NOT ] EXISTS` and name of a kind the opaque check knows, a notebook project's name with its database left out, then an ALTER's action; nothing for another kind. NOTEBOOK PROJECT is a kind only when a name follows it. fn check_opaque_head(&mut self, create: bool) -> Result<()> { let kind = SNOWFLAKE_OPAQUE_KINDS .iter() @@ -305,6 +305,7 @@ impl Parser { self.check_text_seq(words) && !(**words == ["MODEL", "MONITOR"] && self.model_name_ends_at(self.current + 2)) + && !(**words == ["NOTEBOOK", "PROJECT"] && self.notebook_name_ends_at(2)) }); let Some(&kind) = kind else { return self.check_opaque_unknown_kind(); @@ -342,6 +343,12 @@ impl Parser { } } + /// Whether the token `offset` tokens ahead ends a notebook's name: the statement end or FROM, so `CREATE NOTEBOOK project FROM @s1` names the notebook PROJECT. + fn notebook_name_ends_at(&self, offset: usize) -> bool { + self.peek_nth(offset) + .is_none_or(|token| matches!(token.token_type, TokenType::From | TokenType::Semicolon)) + } + /// Refuse a kind whose first word starts a kind the check knows but whose next words complete none, as `ALTER OPENFLOW v1` does. fn check_opaque_unknown_kind(&self) -> Result<()> { let first = self.peek().text.to_ascii_uppercase(); diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs index 8ab5336c3..5b7717add 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_show.rs @@ -52,6 +52,20 @@ impl Parser { if matches!(kind.as_str(), "SERVICES") && self.match_text_seq(&["EXCLUDE", "JOBS"]) { show.this.push_str(" EXCLUDE JOBS"); } + if matches!(kind.as_str(), "SERVICES") && self.match_text_seq(&["OF", "TYPE"]) { + show.this.push_str(" OF TYPE "); + loop { + if !(self.is_identifier_token() || self.check_keyword()) { + return Err(self.parse_error("Expected a service type after OF TYPE")); + } + show.this + .push_str(&self.advance_text()?.to_ascii_uppercase()); + if !self.match_token(TokenType::Comma) { + break; + } + show.this.push_str(", "); + } + } if matches!(kind.as_str(), "OPENFLOW DATA PLANE INTEGRATIONS") { return Ok(Some(Expression::Show(Box::new(show)))); } @@ -131,7 +145,7 @@ impl Parser { Ok(Some(Expression::Show(Box::new(show)))) } - /// `[ STARTS WITH '' ]`, then ROOT ONLY for tasks, then `[ LIMIT [ FROM '' ] ]`, then a service list's `OF TYPE [ , ... ]`. + /// `[ STARTS WITH '' ]`, then ROOT ONLY for tasks, then `[ LIMIT [ FROM '' ] ]`. fn parse_show_starts_and_limit(&mut self, kind: &str, mut show: Show) -> Result { if self.match_identifier("STARTS") { self.expect_token(TokenType::With)?; @@ -153,20 +167,6 @@ impl Parser { show.from = Some(self.parse_show_string("FROM")?); } } - if matches!(kind, "SERVICES") && self.match_text_seq(&["OF", "TYPE"]) { - show.this.push_str(" OF TYPE "); - loop { - if !(self.is_identifier_token() || self.check_keyword()) { - return Err(self.parse_error("Expected a service type after OF TYPE")); - } - show.this - .push_str(&self.advance_text()?.to_ascii_uppercase()); - if !self.match_token(TokenType::Comma) { - break; - } - show.this.push_str(", "); - } - } Ok(show) } diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/entry.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/entry.rs index 638014daa..63a9b1256 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/entry.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/entry.rs @@ -489,8 +489,8 @@ impl Parser { == Some(true) { self.skip(); - self.check_execute_immediate()?; - self.parse_command()?.ok_or_else(|| { + let end = self.check_execute_immediate()?; + self.parse_command_before(end)?.ok_or_else(|| { self.parse_error("Failed to parse EXECUTE IMMEDIATE statement") }) } else { diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs index 24bcd8058..33b4de0c3 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs @@ -973,10 +973,21 @@ impl Parser { /// Parses a generic command with no specific parser. pub(crate) fn parse_command(&mut self) -> Result> { + self.parse_command_before(None) + } + + /// Parses a generic command up to the next `;`, or up to the token at `end` when it is given. + pub(crate) fn parse_command_before( + &mut self, + end: Option, + ) -> Result> { let command_text = self.previous_text().to_ascii_uppercase(); let mut tokens: Vec<(String, TokenType)> = vec![(command_text, TokenType::Var)]; - while !self.is_at_end() && !self.check(TokenType::Semicolon) { + while !self.is_at_end() + && !self.check(TokenType::Semicolon) + && end.is_none_or(|end| self.current < end) + { let token = self.advance()?; let text = if token.token_type == TokenType::QuotedIdentifier { let quote_char = { '"' }; diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs index 393650ddd..4fc29aa10 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_receipted_objects.rs @@ -155,6 +155,21 @@ fn given_a_snowflake_execute_immediate_when_parsing_then_recorded_verdicts_hold( sql: "BEGIN EXECUTE IMMEDIATE :q USING ( v1 ) ; END ;", expected_kind: Some("scripting_block"), }, + SnowflakeVerdictTestCase { + description: "a RESULTSET may take what EXECUTE IMMEDIATE returns (recorded semantic error)", + sql: "BEGIN LET r1 RESULTSET := ( EXECUTE IMMEDIATE :q1 USING ( v1 ) ) ; END ;", + expected_kind: Some("scripting_block"), + }, + SnowflakeVerdictTestCase { + description: "a RESULTSET may take EXECUTE IMMEDIATE without USING (recorded semantic error)", + sql: "BEGIN LET r1 RESULTSET := ( EXECUTE IMMEDIATE :q1 ) ; END ;", + expected_kind: Some("scripting_block"), + }, + SnowflakeVerdictTestCase { + description: "a closing parenthesis with nothing to close is no end", + sql: "EXECUTE IMMEDIATE :q1 ) ;", + expected_kind: None, + }, SnowflakeVerdictTestCase { description: "a source may concatenate strings and variables, as Snowflake documents", sql: "EXECUTE IMMEDIATE v2 || ',(80)' || ',(84)' ;", @@ -320,6 +335,21 @@ fn given_a_snowflake_notebook_project_or_organization_profile_when_parsing_then_ sql: "CREATE NOTEBOOK PROJECT IF EXISTS v1 . v1 . v1 FROM '@d1.s1.st1' ;", expected_kind: None, }, + SnowflakeVerdictTestCase { + description: "a notebook may be named PROJECT (recorded runtime error)", + sql: "CREATE NOTEBOOK project ;", + expected_kind: Some("raw"), + }, + SnowflakeVerdictTestCase { + description: "a notebook named PROJECT may come from a stage (recorded runtime error)", + sql: "CREATE NOTEBOOK project FROM '@d1.s1.st1' ;", + expected_kind: Some("raw"), + }, + SnowflakeVerdictTestCase { + description: "a reserved word is no notebook project's name", + sql: "CREATE NOTEBOOK PROJECT set FROM 'snow://workspace/w1' ;", + expected_kind: None, + }, SnowflakeVerdictTestCase { description: "PROJECT alone is no kind (recorded errno 1003)", sql: "CREATE PROJECT v1 . v1 . v1 FROM '@d1.s1.st1' ;", @@ -424,10 +454,15 @@ fn given_a_snowflake_show_services_when_parsing_then_recorded_verdicts_hold() { expected_kind: Some("show"), }, SnowflakeVerdictTestCase { - description: "OF TYPE comes last, after the documented clauses", - sql: "SHOW SERVICES LIKE 'm' IN COMPUTE POOL v1 OF TYPE USER ;", + description: "LIMIT may follow OF TYPE (recorded acceptance)", + sql: "SHOW SERVICES OF TYPE USER LIMIT 1 ;", expected_kind: Some("show"), }, + SnowflakeVerdictTestCase { + description: "OF TYPE comes straight after SERVICES, not after IN (recorded errno 1003)", + sql: "SHOW SERVICES IN COMPUTE POOL v1 OF TYPE USER ;", + expected_kind: None, + }, SnowflakeVerdictTestCase { description: "OF TYPE needs a type (recorded errno 1003)", sql: "SHOW SERVICES OF TYPE ;", @@ -657,9 +692,9 @@ fn given_a_snowflake_external_agent_or_filtered_show_when_parsing_then_the_tree_ }, StatementTestCase { description: "SHOW SERVICES keeps its filters in its kind", - sql: "SHOW SERVICES EXCLUDE JOBS IN COMPUTE POOL v1 LIMIT 1 OF TYPE USER , JOB ;", + sql: "SHOW SERVICES OF TYPE USER , JOB IN COMPUTE POOL v1 LIMIT 1 ;", pointer: "/0/show/this", - expected_value: json!("SERVICES EXCLUDE JOBS OF TYPE USER, JOB"), + expected_value: json!("SERVICES OF TYPE USER, JOB"), }, ]; for test_case in test_cases { From cac36a94f0c1f29c1ebdcdeaebb60aa9d456d036 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Fri, 13 Nov 2026 08:26:07 +0000 Subject: [PATCH 10/10] chore(syntax-coverage): record what the RESULTSET, notebook name and SHOW SERVICES fixes cleared Every receipt of the batch agrees with the parser, so the disagreement list stays at 583 entries, and four event table and SHOW SERVICES obligations are now met. The RESULTSET assignment form loses its approval: its two new EXECUTE IMMEDIATE cases parse, but EXECUTE IMMEDIATE is still kept as an opaque command, which no positive obligation accepts, until it has a structured node. --- coverage/syntax/baseline.json | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 4af7e60f5..d84f9bb93 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -2790,7 +2790,7 @@ "sf.scripting.let.let-cursor-for.cursor-assignment-syntax": "verified", "sf.scripting.let.let-default": "verified", "sf.scripting.let.let-default.variable-assignment-syntax": "verified", - "sf.scripting.let.let-resultset-default": "verified", + "sf.scripting.let.let-resultset-default": "unverified", "sf.scripting.loop": "verified", "sf.scripting.null": "verified", "sf.scripting.open": "verified", @@ -23276,6 +23276,7 @@ "sf.ddl.create-event-table.table.o177", "sf.ddl.create-event-table.table.o178", "sf.ddl.create-event-table.table.o179", + "sf.ddl.create-event-table.table.o195", "sf.ddl.create-event-table.table-clone.o001", "sf.ddl.create-event-table.table-clone.o003", "sf.ddl.create-event-table.table-clone.o005", @@ -46251,6 +46252,9 @@ "sf.ddl.show-services.o061", "sf.ddl.show-services.o062", "sf.ddl.show-services.o068", + "sf.ddl.show-services.o069", + "sf.ddl.show-services.o070", + "sf.ddl.show-services.o071", "sf.ddl.show-shared-content.o001", "sf.ddl.show-shared-content.o002", "sf.ddl.show-shared-content.o003", @@ -96617,6 +96621,7 @@ "sf.ddl.create-notebook.k0bed30175e53", "sf.ddl.create-notebook.k203a128a59e3", "sf.ddl.create-notebook.k27ce15d339c2", + "sf.ddl.create-notebook.k29ba034d4e41", "sf.ddl.create-notebook.k37007c22c9d0", "sf.ddl.create-notebook.k3b06983d8b60", "sf.ddl.create-notebook.k3e5519a206d6", @@ -96624,6 +96629,8 @@ "sf.ddl.create-notebook.k4c2fd70d0d4f", "sf.ddl.create-notebook.k677b4f657abe", "sf.ddl.create-notebook.k84e1e6adbca3", + "sf.ddl.create-notebook.k959cea8a8c07", + "sf.ddl.create-notebook.k967415cf39d9", "sf.ddl.create-notebook.k9dda135f2b1e", "sf.ddl.create-notebook.kc4367bfc5806", "sf.ddl.create-notebook.kd00ef261df2b", @@ -102042,6 +102049,7 @@ "sf.ddl.show-service-volumes-in-service.k090649c1f9b8", "sf.ddl.show-service-volumes-in-service.k70ceea8a3a35", "sf.ddl.show-service-volumes-in-service.ke49b4e5a611a", + "sf.ddl.show-services.k01db831ab566", "sf.ddl.show-services.k0acbf4ce87c6", "sf.ddl.show-services.k1e99eec0a993", "sf.ddl.show-services.k29a0665c9b62", @@ -102055,6 +102063,7 @@ "sf.ddl.show-services.kb18c179a6638", "sf.ddl.show-services.kbef7e93eb07c", "sf.ddl.show-services.kc253f69002b8", + "sf.ddl.show-services.kc51e4f2199da", "sf.ddl.show-services.kd9887a8bb169", "sf.ddl.show-services.kdbd3ecd7ecb5", "sf.ddl.show-services.kfc239d30c4cb", @@ -107694,6 +107703,8 @@ "sf.scripting.let.let-resultset-default.k0574bbd8761c", "sf.scripting.let.let-resultset-default.k2026d044c804", "sf.scripting.let.let-resultset-default.k47bfb0dac0e2", + "sf.scripting.let.let-resultset-default.k753318a195f7", + "sf.scripting.let.let-resultset-default.k7b7880ab4b89", "sf.scripting.let.let-resultset-default.k857e8658789c", "sf.scripting.let.let-resultset-default.ka9985c6e57ba", "sf.scripting.let.let-resultset-default.kbfeb42945d8c", @@ -115328,6 +115339,7 @@ "sf.utility.execute-immediate.immediate.k1156f161277b", "sf.utility.execute-immediate.immediate.k12bd17edf6bc", "sf.utility.execute-immediate.immediate.k3e2a5259ffe8", + "sf.utility.execute-immediate.immediate.k4c5f8b188cfd", "sf.utility.execute-immediate.immediate.kd2afb4d7b1fd", "sf.utility.execute-immediate.immediate.syntax.k4121e62a684d", "sf.utility.execute-immediate.immediate.syntax.k755f663acfb3", @@ -124823,6 +124835,7 @@ "sf.ddl.create-event-table.table.kca58640f3090", "sf.ddl.create-event-table.table.kd0631a46f73a", "sf.ddl.create-event-table.table.kd6769254a7c6", + "sf.ddl.create-event-table.table.ke78f8f5c1856", "sf.ddl.create-event-table.table.ke7e3da2e2d4c", "sf.ddl.create-event-table.table.ke81a17d6f572", "sf.ddl.create-event-table.table.kec2839b42c59", @@ -133010,6 +133023,7 @@ "sf.ddl.show-services.k15ae18c7f8ca", "sf.ddl.show-services.k2b2a51e6a1b2", "sf.ddl.show-services.k5921aec5ad1a", + "sf.ddl.show-services.k5a4f57168e89", "sf.ddl.show-services.k5ce91e02cf1b", "sf.ddl.show-services.k6152a08b0d4e", "sf.ddl.show-services.k7879696353a4",