From 271ca44c20a8a1f849da15369c34955ad4eed8f2 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 18:35:45 +0000 Subject: [PATCH 01/14] chore(syntax-limits): add cases for ON read-order clauses, model monitor column arrays, x86 resource constraints and online feature table shapes These cases are recorded by a later evidence pin. The JOIN form with ON had read-order cases without ON, which Snowflake reads as a table alias; these rows carry ON TRUE. CREATE MODEL MONITOR's *_COLUMNS values are arrays of column-name strings, so their present and operand rows write one- and two-element arrays on a plain base, and the identifier classes, which do not apply to strings, are withdrawn. CREATE OR ALTER WAREHOUSE names each _x86 resource constraint. Six CREATE ONLINE FEATURE TABLE shapes are observed. Two EXECUTE IMMEDIATE FROM stage paths run in a run database. --- coverage/syntax/held.jsonl | 2 + coverage/syntax/limits.toml | 840 +++++++++++++++++++++++++ coverage/syntax/obligations/ddl.toml | 493 ++++++--------- coverage/syntax/obligations/query.toml | 86 +-- 4 files changed, 1082 insertions(+), 339 deletions(-) diff --git a/coverage/syntax/held.jsonl b/coverage/syntax/held.jsonl index bb7c5c5b9..3f35e69bb 100644 --- a/coverage/syntax/held.jsonl +++ b/coverage/syntax/held.jsonl @@ -626,3 +626,5 @@ {"calls": ["a stage path that needs a current database to resolve"], "case_id": "sf.dml.copy-into-location.ke84dfd53053b", "expect": "observe", "family": "dml", "packet_revision": "c44bdb317ec71a638508e300fb96d1cde73b862a", "reason": "run in a run database: a session without a current database answers errno 90105"} {"calls": ["a stage path that needs a current database to resolve"], "case_id": "sf.query.from.k6198154838c3", "expect": "observe", "family": "query", "packet_revision": "c44bdb317ec71a638508e300fb96d1cde73b862a", "reason": "run in a run database: a session without a current database answers errno 90105"} {"calls": ["a semantic view reference that needs a current database to resolve"], "case_id": "sf.query.semantic-view.k346000861414", "expect": "observe", "family": "query", "packet_revision": "c44bdb317ec71a638508e300fb96d1cde73b862a", "reason": "run in a run database: a session without a current database answers errno 90105"} +{"calls": ["a stage path that needs a current database to resolve"], "case_id": "sf.utility.execute-immediate-from.kd2b2dee1a470", "expect": "observe", "family": "utility", "packet_revision": "a08ad154b8f076e49e46a1e9ad26ebe962a1127a", "reason": "run in a run database: a session without a current database answers errno 90105"} +{"calls": ["a stage path that needs a current database to resolve"], "case_id": "sf.utility.execute-immediate-from.kea3e07c355cb", "expect": "observe", "family": "utility", "packet_revision": "a08ad154b8f076e49e46a1e9ad26ebe962a1127a", "reason": "run in a run database: a session without a current database answers errno 90105"} diff --git a/coverage/syntax/limits.toml b/coverage/syntax/limits.toml index c58a518a5..33a20abf7 100644 --- a/coverage/syntax/limits.toml +++ b/coverage/syntax/limits.toml @@ -83296,3 +83296,843 @@ anchor = "doc.constructs.semantic_view / Syntax" sql = "SELECT * FROM SEMANTIC_VIEW ( v1 DIMENSIONS 1 METRICS 1 ) ;" context = "raw" expect = "observe" + +# The ON form of JOIN has the same read-order clause after ON. Its derived read-order cases have no ON, +# so Snowflake reads FIRST ( v1 ) there as a table alias (errno 2003); these rows carry ON TRUE. + +[[suppress]] +form = "sf.query.join.join" +kind = "alternative" +target = "{ FIRST | LAST } → FIRST" +reason = "without ON or USING the generated case reads FIRST ( v1 ) as a table alias (errno 2003, not 1868); the row below carries ON so the read-order clause is parsed" + +[[limit]] +form = "sf.query.join.join" +kind = "alternative" +target = "{ FIRST | LAST } → FIRST" +note = "FIRST after ON, a read-order clause" +anchor = "doc.constructs.join / Usage notes" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( v1 ) ;" +context = "raw" +expect = "accept" + +[[suppress]] +form = "sf.query.join.join" +kind = "alternative" +target = "{ FIRST | LAST } → LAST" +reason = "without ON or USING the generated case reads LAST ( v1 ) as a table alias; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "alternative" +target = "{ FIRST | LAST } → LAST" +note = "LAST after ON, a read-order clause" +anchor = "doc.constructs.join / Usage notes" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE LAST ( v1 ) ;" +context = "raw" +expect = "accept" + +[[suppress]] +form = "sf.query.join.join" +kind = "required_operand_missing" +target = " in [ { FIRST | LAST } ( ) ]" +reason = "without ON or USING the generated case is an empty column-alias list; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "required_operand_missing" +target = " in [ { FIRST | LAST } ( ) ]" +note = "omit in a read-order clause after ON" +anchor = "doc.constructs.join / Syntax" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( ) ;" +context = "raw" +expect = "reject" + +[[suppress]] +form = "sf.query.join.join" +kind = "negative_neighbour" +target = " in [ { FIRST | LAST } ( ) ]" +note = "a string literal in place of " +reason = "without ON or USING the generated case is a literal in a column-alias list; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "negative_neighbour" +target = " in [ { FIRST | LAST } ( ) ]" +note = "a string literal in place of in a read-order clause after ON" +anchor = "doc.constructs.join / Syntax" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( 'v1' ) ;" +context = "raw" +expect = "reject" + +[[suppress]] +form = "sf.query.join.join" +kind = "negative_neighbour" +note = "the form without its required ( in [ { FIRST | LAST } ( ) ]" +reason = "without ON or USING the generated case does not reach a read-order clause; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "negative_neighbour" +note = "a read-order clause after ON without its (" +anchor = "doc.constructs.join / Syntax" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST v1 ) ;" +context = "raw" +expect = "reject" + +[[suppress]] +form = "sf.query.join.join" +kind = "negative_neighbour" +note = "the form without its required ) in [ { FIRST | LAST } ( ) ]" +reason = "without ON or USING the generated case is an unclosed column-alias list; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "negative_neighbour" +note = "a read-order clause after ON without its )" +anchor = "doc.constructs.join / Syntax" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( v1 ;" +context = "raw" +expect = "reject" + +[[suppress]] +form = "sf.query.join.join" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "without ON or USING the generated case is a quoted column alias; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "identifier_class" +target = "" +note = "quoted in a read-order clause after ON" +anchor = "doc.identifiers-syntax" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( \"v1 Q\" ) ;" +context = "raw" +expect = "accept" + +[[suppress]] +form = "sf.query.join.join" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "without ON or USING the generated cases are column aliases; the row below carries ON" + +[[limit]] +form = "sf.query.join.join" +kind = "identifier_class" +target = "" +note = "reserved in a read-order clause after ON, unquoted and double-quoted" +anchor = "doc.identifiers-syntax" +sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( SELECT ) ;" +context = "raw" +expect = "reject" +also_sql = "SELECT * FROM t1 INNER DIRECTED JOIN t2 ON TRUE FIRST ( \"SELECT\" ) ;" +also_expect = "accept" + +# CREATE OR ALTER WAREHOUSE: the truncated alternative list names the three _x86 resource constraints, but +# the derived case writes v1 for all three (errno 1422, an invalid value). These rows name each constraint. + +[[suppress]] +form = "sf.ddl.create-warehouse.create-or-alter-warehouse" +kind = "alternative" +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_1X_x86" +reason = "the derived case writes v1 instead of MEMORY_1X_x86; the row below names it" + +[[limit]] +form = "sf.ddl.create-warehouse.create-or-alter-warehouse" +kind = "alternative" +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_1X_x86" +note = "RESOURCE_CONSTRAINT = MEMORY_1X_x86" +anchor = "doc.sql.create-warehouse / Parameters" +sql = "CREATE OR ALTER WAREHOUSE v1 RESOURCE_CONSTRAINT = MEMORY_1X_x86 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-warehouse.create-or-alter-warehouse" +kind = "alternative" +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_16X_x86" +reason = "the derived case writes v1 instead of MEMORY_16X_x86; the row below names it" + +[[limit]] +form = "sf.ddl.create-warehouse.create-or-alter-warehouse" +kind = "alternative" +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_16X_x86" +note = "RESOURCE_CONSTRAINT = MEMORY_16X_x86" +anchor = "doc.sql.create-warehouse / Parameters" +sql = "CREATE OR ALTER WAREHOUSE v1 RESOURCE_CONSTRAINT = MEMORY_16X_x86 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-warehouse.create-or-alter-warehouse" +kind = "alternative" +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_64X_x86" +reason = "the derived case writes v1 instead of MEMORY_64X_x86; the row below names it" + +[[limit]] +form = "sf.ddl.create-warehouse.create-or-alter-warehouse" +kind = "alternative" +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_64X_x86" +note = "RESOURCE_CONSTRAINT = MEMORY_64X_x86" +anchor = "doc.sql.create-warehouse / Parameters" +sql = "CREATE OR ALTER WAREHOUSE v1 RESOURCE_CONSTRAINT = MEMORY_64X_x86 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +# CREATE MODEL MONITOR: each *_COLUMNS value is an array of column-name strings, ( 'col' [ , ... ] ). The +# derived cases write a bare name or string, which Snowflake refuses as an invalid value (errno 1421 or 1008), +# and the base case that combines OR REPLACE with IF NOT EXISTS fails first (errno 1004). These rows write +# arrays on the plain base. Identifier classes do not apply to an array of strings, so those are withdrawn. + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ ID_COLUMNS = ]" +reason = "the derived case writes a bare value where ID_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ ID_COLUMNS = ]" +note = "ID_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ID_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ ID_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where ID_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ ID_COLUMNS = ]" +note = "ID_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ID_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ PREDICTION_CLASS_COLUMNS = ]" +reason = "the derived case writes a bare value where PREDICTION_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ PREDICTION_CLASS_COLUMNS = ]" +note = "PREDICTION_CLASS_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 PREDICTION_CLASS_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ PREDICTION_CLASS_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where PREDICTION_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ PREDICTION_CLASS_COLUMNS = ]" +note = "PREDICTION_CLASS_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 PREDICTION_CLASS_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ PREDICTION_SCORE_COLUMNS = ]" +reason = "the derived case writes a bare value where PREDICTION_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ PREDICTION_SCORE_COLUMNS = ]" +note = "PREDICTION_SCORE_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 PREDICTION_SCORE_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ PREDICTION_SCORE_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where PREDICTION_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ PREDICTION_SCORE_COLUMNS = ]" +note = "PREDICTION_SCORE_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 PREDICTION_SCORE_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ ACTUAL_CLASS_COLUMNS = ]" +reason = "the derived case writes a bare value where ACTUAL_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ ACTUAL_CLASS_COLUMNS = ]" +note = "ACTUAL_CLASS_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ACTUAL_CLASS_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ ACTUAL_CLASS_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where ACTUAL_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ ACTUAL_CLASS_COLUMNS = ]" +note = "ACTUAL_CLASS_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ACTUAL_CLASS_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ ACTUAL_SCORE_COLUMNS = ]" +reason = "the derived case writes a bare value where ACTUAL_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ ACTUAL_SCORE_COLUMNS = ]" +note = "ACTUAL_SCORE_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ACTUAL_SCORE_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ ACTUAL_SCORE_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where ACTUAL_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ ACTUAL_SCORE_COLUMNS = ]" +note = "ACTUAL_SCORE_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ACTUAL_SCORE_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ SEGMENT_COLUMNS = ]" +reason = "the derived case writes a bare value where SEGMENT_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ SEGMENT_COLUMNS = ]" +note = "SEGMENT_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 SEGMENT_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ SEGMENT_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where SEGMENT_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ SEGMENT_COLUMNS = ]" +note = "SEGMENT_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 SEGMENT_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ CUSTOM_METRIC_COLUMNS = ]" +reason = "the derived case writes a bare value where CUSTOM_METRIC_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ CUSTOM_METRIC_COLUMNS = ]" +note = "CUSTOM_METRIC_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 CUSTOM_METRIC_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ CUSTOM_METRIC_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where CUSTOM_METRIC_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ CUSTOM_METRIC_COLUMNS = ]" +note = "CUSTOM_METRIC_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 CUSTOM_METRIC_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ ID_COLUMNS = ]" +reason = "the derived case writes a bare value where ID_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ ID_COLUMNS = ]" +note = "ID_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ID_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ ID_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where ID_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ ID_COLUMNS = ]" +note = "ID_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ID_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ PREDICTION_CLASS_COLUMNS = ]" +reason = "the derived case writes a bare value where PREDICTION_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ PREDICTION_CLASS_COLUMNS = ]" +note = "PREDICTION_CLASS_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' PREDICTION_CLASS_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ PREDICTION_CLASS_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where PREDICTION_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ PREDICTION_CLASS_COLUMNS = ]" +note = "PREDICTION_CLASS_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' PREDICTION_CLASS_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ PREDICTION_SCORE_COLUMNS = ]" +reason = "the derived case writes a bare value where PREDICTION_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ PREDICTION_SCORE_COLUMNS = ]" +note = "PREDICTION_SCORE_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' PREDICTION_SCORE_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ PREDICTION_SCORE_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where PREDICTION_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ PREDICTION_SCORE_COLUMNS = ]" +note = "PREDICTION_SCORE_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' PREDICTION_SCORE_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ ACTUAL_CLASS_COLUMNS = ]" +reason = "the derived case writes a bare value where ACTUAL_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ ACTUAL_CLASS_COLUMNS = ]" +note = "ACTUAL_CLASS_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ACTUAL_CLASS_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ ACTUAL_CLASS_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where ACTUAL_CLASS_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ ACTUAL_CLASS_COLUMNS = ]" +note = "ACTUAL_CLASS_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ACTUAL_CLASS_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ ACTUAL_SCORE_COLUMNS = ]" +reason = "the derived case writes a bare value where ACTUAL_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ ACTUAL_SCORE_COLUMNS = ]" +note = "ACTUAL_SCORE_COLUMNS as a one-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ACTUAL_SCORE_COLUMNS = ( 'c1' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ ACTUAL_SCORE_COLUMNS = ]" +note = "a valid identifier" +reason = "the derived case writes a bare value where ACTUAL_SCORE_COLUMNS takes an array of strings; the row below writes one" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ ACTUAL_SCORE_COLUMNS = ]" +note = "ACTUAL_SCORE_COLUMNS as a two-element array of column-name strings" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ACTUAL_SCORE_COLUMNS = ( 'c1' , 'c2' ) ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "quoted: a double-quoted identifier with blanks and mixed case" +reason = "the value is an array of column-name strings, not an identifier" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "identifier_class" +target = "" +note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +reason = "the value is an array of column-name strings, not an identifier" + +# CREATE ONLINE FEATURE TABLE: shapes the grammar review asked Snowflake about. The page example orders +# its clauses differently from the syntax block, and the usage note names IF NOT EXISTS, so each +# shape whose syntax or semantic split is unknown is observed. + +[[limit]] +form = "sf.ddl.create-online-feature-table" +kind = "positive" +note = "the page's example, whose clause order differs from the syntax block" +anchor = "doc.sql.create-online-feature-table / Examples" +sql = "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) TIMESTAMP_COLUMN = 'TS' TARGET_LAG = '30 seconds' WAREHOUSE = v1 FROM t2 ;" +context = "raw" +expect = "observe" + +[[limit]] +form = "sf.ddl.create-online-feature-table" +kind = "positive" +note = "an optional clause before TARGET_LAG" +anchor = "doc.sql.create-online-feature-table / Syntax" +sql = "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) REFRESH_MODE = AUTO TARGET_LAG = '1 minute' WAREHOUSE = v1 FROM t2 ;" +context = "raw" +expect = "observe" + +[[limit]] +form = "sf.ddl.create-online-feature-table" +kind = "negative_neighbour" +note = "the form without its required TARGET_LAG clause" +anchor = "doc.sql.create-online-feature-table / Syntax" +sql = "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) WAREHOUSE = v1 FROM t2 ;" +context = "raw" +expect = "observe" + +[[limit]] +form = "sf.ddl.create-online-feature-table" +kind = "negative_neighbour" +note = "the form without its required WAREHOUSE clause" +anchor = "doc.sql.create-online-feature-table / Syntax" +sql = "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) TARGET_LAG = '1 minute' FROM t2 ;" +context = "raw" +expect = "observe" + +[[limit]] +form = "sf.ddl.create-online-feature-table" +kind = "required_operand_missing" +target = " { seconds | minutes | hours | days }" +note = "omit the TARGET_LAG value" +anchor = "doc.sql.create-online-feature-table / Syntax" +sql = "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) TARGET_LAG = WAREHOUSE = v1 FROM t2 ;" +context = "raw" +expect = "reject" + +[[limit]] +form = "sf.ddl.create-online-feature-table" +kind = "positive" +note = "IF NOT EXISTS, named by the usage note but absent from the syntax block" +anchor = "doc.sql.create-online-feature-table / Usage notes" +sql = "CREATE ONLINE FEATURE TABLE IF NOT EXISTS v1 PRIMARY KEY ( v1 ) TARGET_LAG = '1 minute' WAREHOUSE = v1 FROM t2 ;" +context = "raw" +expect = "observe" diff --git a/coverage/syntax/obligations/ddl.toml b/coverage/syntax/obligations/ddl.toml index fd96e8072..1b5eb5303 100644 --- a/coverage/syntax/obligations/ddl.toml +++ b/coverage/syntax/obligations/ddl.toml @@ -181603,12 +181603,6 @@ required = true target = " in [ GROUND_TRUTH = ]" note = "a valid operand" -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o025" -kind = "option_present" -required = true -target = "[ ID_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o026" kind = "option_absent" @@ -181622,13 +181616,6 @@ required = true target = " in [ ID_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o028" -kind = "operand_type_class" -required = true -target = " in [ ID_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o029" kind = "negative_neighbour" @@ -181636,12 +181623,6 @@ required = true target = " in [ ID_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o030" -kind = "option_present" -required = true -target = "[ PREDICTION_CLASS_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o031" kind = "option_absent" @@ -181655,13 +181636,6 @@ required = true target = " in [ PREDICTION_CLASS_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o033" -kind = "operand_type_class" -required = true -target = " in [ PREDICTION_CLASS_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o034" kind = "negative_neighbour" @@ -181669,12 +181643,6 @@ required = true target = " in [ PREDICTION_CLASS_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o035" -kind = "option_present" -required = true -target = "[ PREDICTION_SCORE_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o036" kind = "option_absent" @@ -181688,13 +181656,6 @@ required = true target = " in [ PREDICTION_SCORE_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o038" -kind = "operand_type_class" -required = true -target = " in [ PREDICTION_SCORE_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o039" kind = "negative_neighbour" @@ -181702,12 +181663,6 @@ required = true target = " in [ PREDICTION_SCORE_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o040" -kind = "option_present" -required = true -target = "[ ACTUAL_CLASS_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o041" kind = "option_absent" @@ -181721,13 +181676,6 @@ required = true target = " in [ ACTUAL_CLASS_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o043" -kind = "operand_type_class" -required = true -target = " in [ ACTUAL_CLASS_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o044" kind = "negative_neighbour" @@ -181735,12 +181683,6 @@ required = true target = " in [ ACTUAL_CLASS_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o045" -kind = "option_present" -required = true -target = "[ ACTUAL_SCORE_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o046" kind = "option_absent" @@ -181754,13 +181696,6 @@ required = true target = " in [ ACTUAL_SCORE_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o048" -kind = "operand_type_class" -required = true -target = " in [ ACTUAL_SCORE_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o049" kind = "negative_neighbour" @@ -181938,91 +181873,91 @@ anchor = "doc.identifiers-syntax" note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o075" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o085" +kind = "negative_neighbour" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "the form without its required WITH, observed" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o076" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o087" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ ID_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "ID_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o077" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o088" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ ID_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "ID_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o078" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o089" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ PREDICTION_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "PREDICTION_CLASS_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o079" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o090" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ PREDICTION_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "PREDICTION_CLASS_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o080" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o091" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ PREDICTION_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "PREDICTION_SCORE_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o081" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o092" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ PREDICTION_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "PREDICTION_SCORE_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o082" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o093" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ ACTUAL_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "ACTUAL_CLASS_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o083" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o094" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ ACTUAL_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "ACTUAL_CLASS_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o084" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o095" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ ACTUAL_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +note = "ACTUAL_SCORE_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o085" -kind = "negative_neighbour" +id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o096" +kind = "operand_type_class" required = true +target = " in [ ACTUAL_SCORE_COLUMNS = ]" anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" -note = "the form without its required WITH, observed" +note = "ACTUAL_SCORE_COLUMNS as a two-element array of column-name strings" [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o001" @@ -182234,12 +182169,6 @@ required = true target = " in [ BASELINE = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o032" -kind = "option_present" -required = true -target = "[ ID_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o033" kind = "option_absent" @@ -182253,13 +182182,6 @@ required = true target = " in [ ID_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o035" -kind = "operand_type_class" -required = true -target = " in [ ID_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o036" kind = "negative_neighbour" @@ -182267,12 +182189,6 @@ required = true target = " in [ ID_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o037" -kind = "option_present" -required = true -target = "[ PREDICTION_CLASS_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o038" kind = "option_absent" @@ -182286,13 +182202,6 @@ required = true target = " in [ PREDICTION_CLASS_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o040" -kind = "operand_type_class" -required = true -target = " in [ PREDICTION_CLASS_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o041" kind = "negative_neighbour" @@ -182300,12 +182209,6 @@ required = true target = " in [ PREDICTION_CLASS_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o042" -kind = "option_present" -required = true -target = "[ PREDICTION_SCORE_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o043" kind = "option_absent" @@ -182319,13 +182222,6 @@ required = true target = " in [ PREDICTION_SCORE_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o045" -kind = "operand_type_class" -required = true -target = " in [ PREDICTION_SCORE_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o046" kind = "negative_neighbour" @@ -182333,12 +182229,6 @@ required = true target = " in [ PREDICTION_SCORE_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o047" -kind = "option_present" -required = true -target = "[ ACTUAL_CLASS_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o048" kind = "option_absent" @@ -182352,13 +182242,6 @@ required = true target = " in [ ACTUAL_CLASS_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o050" -kind = "operand_type_class" -required = true -target = " in [ ACTUAL_CLASS_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o051" kind = "negative_neighbour" @@ -182366,12 +182249,6 @@ required = true target = " in [ ACTUAL_CLASS_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o052" -kind = "option_present" -required = true -target = "[ ACTUAL_SCORE_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o053" kind = "option_absent" @@ -182385,13 +182262,6 @@ required = true target = " in [ ACTUAL_SCORE_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o055" -kind = "operand_type_class" -required = true -target = " in [ ACTUAL_SCORE_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o056" kind = "negative_neighbour" @@ -182399,12 +182269,6 @@ required = true target = " in [ ACTUAL_SCORE_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o057" -kind = "option_present" -required = true -target = "[ SEGMENT_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o058" kind = "option_absent" @@ -182418,13 +182282,6 @@ required = true target = " in [ SEGMENT_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o060" -kind = "operand_type_class" -required = true -target = " in [ SEGMENT_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o061" kind = "negative_neighbour" @@ -182432,12 +182289,6 @@ required = true target = " in [ SEGMENT_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o062" -kind = "option_present" -required = true -target = "[ CUSTOM_METRIC_COLUMNS = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o063" kind = "option_absent" @@ -182451,13 +182302,6 @@ required = true target = " in [ CUSTOM_METRIC_COLUMNS = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o065" -kind = "operand_type_class" -required = true -target = " in [ CUSTOM_METRIC_COLUMNS = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o066" kind = "negative_neighbour" @@ -182679,123 +182523,123 @@ anchor = "doc.identifiers-syntax" note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o098" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o112" +kind = "negative_neighbour" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "the form without its required WITH, observed" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o099" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o114" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ ID_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "ID_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o100" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o115" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ ID_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "ID_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o101" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o116" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ PREDICTION_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "PREDICTION_CLASS_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o102" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o117" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ PREDICTION_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "PREDICTION_CLASS_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o103" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o118" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ PREDICTION_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "PREDICTION_SCORE_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o104" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o119" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ PREDICTION_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "PREDICTION_SCORE_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o105" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o120" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ ACTUAL_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "ACTUAL_CLASS_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o106" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o121" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ ACTUAL_CLASS_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "ACTUAL_CLASS_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o107" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o122" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ ACTUAL_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "ACTUAL_SCORE_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o108" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o123" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ ACTUAL_SCORE_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "ACTUAL_SCORE_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o109" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o124" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ SEGMENT_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "SEGMENT_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o110" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o125" +kind = "operand_type_class" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +target = " in [ SEGMENT_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "SEGMENT_COLUMNS as a two-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o111" -kind = "identifier_class" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o126" +kind = "option_present" required = true -target = "" -anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +target = "[ CUSTOM_METRIC_COLUMNS = ]" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +note = "CUSTOM_METRIC_COLUMNS as a one-element array of column-name strings" [[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o112" -kind = "negative_neighbour" +id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o127" +kind = "operand_type_class" required = true +target = " in [ CUSTOM_METRIC_COLUMNS = ]" anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" -note = "the form without its required WITH, observed" +note = "CUSTOM_METRIC_COLUMNS as a two-element array of column-name strings" [[obligation]] id = "sf.ddl.create-model.internalstage.o001" @@ -184719,6 +184563,49 @@ target = "''" anchor = "doc.sql.create-online-feature-table / Parameters" note = "a tag value of 257 characters against the documented maximum of 256" +[[obligation]] +id = "sf.ddl.create-online-feature-table.o074" +kind = "positive" +required = true +anchor = "doc.sql.create-online-feature-table / Examples" +note = "the page's example, whose clause order differs from the syntax block" + +[[obligation]] +id = "sf.ddl.create-online-feature-table.o075" +kind = "positive" +required = true +anchor = "doc.sql.create-online-feature-table / Syntax" +note = "an optional clause before TARGET_LAG" + +[[obligation]] +id = "sf.ddl.create-online-feature-table.o076" +kind = "negative_neighbour" +required = true +anchor = "doc.sql.create-online-feature-table / Syntax" +note = "the form without its required TARGET_LAG clause" + +[[obligation]] +id = "sf.ddl.create-online-feature-table.o077" +kind = "negative_neighbour" +required = true +anchor = "doc.sql.create-online-feature-table / Syntax" +note = "the form without its required WAREHOUSE clause" + +[[obligation]] +id = "sf.ddl.create-online-feature-table.o078" +kind = "required_operand_missing" +required = true +target = " { seconds | minutes | hours | days }" +anchor = "doc.sql.create-online-feature-table / Syntax" +note = "omit the TARGET_LAG value" + +[[obligation]] +id = "sf.ddl.create-online-feature-table.o079" +kind = "positive" +required = true +anchor = "doc.sql.create-online-feature-table / Usage notes" +note = "IF NOT EXISTS, named by the usage note but absent from the syntax block" + [[obligation]] id = "sf.ddl.create-openflow-connector.from.o001" kind = "positive" @@ -267155,36 +267042,18 @@ kind = "alternative" required = true target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 | MEMORY_64X |… → MEMORY_1X" -[[obligation]] -id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o035" -kind = "alternative" -required = true -target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_1X_x86" - [[obligation]] id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o036" kind = "alternative" required = true target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 | MEMORY_64X |… → MEMORY_16X" -[[obligation]] -id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o037" -kind = "alternative" -required = true -target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_16X_x86" - [[obligation]] id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o038" kind = "alternative" required = true target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 | MEMORY_64X |… → MEMORY_64X" -[[obligation]] -id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o039" -kind = "alternative" -required = true -target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_64X_x86" - [[obligation]] id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o040" kind = "operand_type_class" @@ -267726,6 +267595,30 @@ target = "" anchor = "doc.identifiers-syntax" note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" +[[obligation]] +id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o124" +kind = "alternative" +required = true +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_1X_x86" +anchor = "doc.sql.create-warehouse / Parameters" +note = "RESOURCE_CONSTRAINT = MEMORY_1X_x86" + +[[obligation]] +id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o125" +kind = "alternative" +required = true +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_16X_x86" +anchor = "doc.sql.create-warehouse / Parameters" +note = "RESOURCE_CONSTRAINT = MEMORY_16X_x86" + +[[obligation]] +id = "sf.ddl.create-warehouse.create-or-alter-warehouse.o126" +kind = "alternative" +required = true +target = "{ STANDARD_GEN_1 | STANDARD_GEN_2 | MEMORY_1X | MEMORY_1X_x86 | MEMORY_16X | MEMORY_16X_x86 |… → MEMORY_64X_x86" +anchor = "doc.sql.create-warehouse / Parameters" +note = "RESOURCE_CONSTRAINT = MEMORY_64X_x86" + [[obligation]] id = "sf.ddl.create-warehouse.create-warehouse.o001" kind = "positive" diff --git a/coverage/syntax/obligations/query.toml b/coverage/syntax/obligations/query.toml index 4abbc295c..08e520b34 100644 --- a/coverage/syntax/obligations/query.toml +++ b/coverage/syntax/obligations/query.toml @@ -4748,84 +4748,92 @@ required = true target = "[ { FIRST | LAST } ( ) ]" [[obligation]] -id = "sf.query.join.join.o023" -kind = "alternative" +id = "sf.query.join.join.o026" +kind = "operand_type_class" required = true -target = "{ FIRST | LAST } → FIRST" +target = " in [ { FIRST | LAST } ( ) ]" +note = "a valid identifier" [[obligation]] -id = "sf.query.join.join.o024" -kind = "alternative" +id = "sf.query.join.join.o028" +kind = "negative_neighbour" required = true -target = "{ FIRST | LAST } → LAST" +note = "the form without its required FROM" [[obligation]] -id = "sf.query.join.join.o025" -kind = "required_operand_missing" +id = "sf.query.join.join.o032" +kind = "interaction_all_options" required = true -target = " in [ { FIRST | LAST } ( ) ]" -note = "omit " +note = "every independent option of one production together" [[obligation]] -id = "sf.query.join.join.o026" -kind = "operand_type_class" +id = "sf.query.join.join.o035" +kind = "positive" required = true -target = " in [ { FIRST | LAST } ( ) ]" -note = "a valid identifier" +anchor = "doc.constructs.join / Syntax" +note = "two joins in a row, each with ON, observed" [[obligation]] -id = "sf.query.join.join.o027" -kind = "negative_neighbour" +id = "sf.query.join.join.o036" +kind = "alternative" required = true -target = " in [ { FIRST | LAST } ( ) ]" -note = "a string literal in place of " +target = "{ FIRST | LAST } → FIRST" +anchor = "doc.constructs.join / Usage notes" +note = "FIRST after ON, a read-order clause" [[obligation]] -id = "sf.query.join.join.o028" -kind = "negative_neighbour" +id = "sf.query.join.join.o037" +kind = "alternative" required = true -note = "the form without its required FROM" +target = "{ FIRST | LAST } → LAST" +anchor = "doc.constructs.join / Usage notes" +note = "LAST after ON, a read-order clause" [[obligation]] -id = "sf.query.join.join.o030" +id = "sf.query.join.join.o038" +kind = "required_operand_missing" +required = true +target = " in [ { FIRST | LAST } ( ) ]" +anchor = "doc.constructs.join / Syntax" +note = "omit in a read-order clause after ON" + +[[obligation]] +id = "sf.query.join.join.o039" kind = "negative_neighbour" required = true -note = "the form without its required ( in [ { FIRST | LAST } ( ) ]" +target = " in [ { FIRST | LAST } ( ) ]" +anchor = "doc.constructs.join / Syntax" +note = "a string literal in place of in a read-order clause after ON" [[obligation]] -id = "sf.query.join.join.o031" +id = "sf.query.join.join.o040" kind = "negative_neighbour" required = true -note = "the form without its required ) in [ { FIRST | LAST } ( ) ]" +anchor = "doc.constructs.join / Syntax" +note = "a read-order clause after ON without its (" [[obligation]] -id = "sf.query.join.join.o032" -kind = "interaction_all_options" +id = "sf.query.join.join.o041" +kind = "negative_neighbour" required = true -note = "every independent option of one production together" +anchor = "doc.constructs.join / Syntax" +note = "a read-order clause after ON without its )" [[obligation]] -id = "sf.query.join.join.o033" +id = "sf.query.join.join.o042" kind = "identifier_class" required = true target = "" anchor = "doc.identifiers-syntax" -note = "quoted: a double-quoted identifier with blanks and mixed case" +note = "quoted in a read-order clause after ON" [[obligation]] -id = "sf.query.join.join.o034" +id = "sf.query.join.join.o043" kind = "identifier_class" required = true target = "" anchor = "doc.identifiers-syntax" -note = "reserved: a reserved keyword, unquoted (expected rejection) and double-quoted (expected acceptance)" - -[[obligation]] -id = "sf.query.join.join.o035" -kind = "positive" -required = true -anchor = "doc.constructs.join / Syntax" -note = "two joins in a row, each with ON, observed" +note = "reserved in a read-order clause after ON, unquoted and double-quoted" [[obligation]] id = "sf.query.join.join-2.o001" From 68bc3fa98d1445f5fc7aaac7920db7ee88444837 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 18:39:35 +0000 Subject: [PATCH 02/14] fix(syntax): read ALTER and DROP MODEL monitor as a model named or qualified by monitor ALTER MODEL monitor followed by a dot or an ALTER MODEL action (RENAME TO, SET, UNSET, MODIFY, VERSION, or ADD or DROP VERSION) alters a model, since none of those can follow a model monitor's name. In DROP, a two-word kind whose second word is followed by a dot names an object of the shorter kind in that schema, as it already did at the statement end, so DROP MODEL monitor.m1 drops a model. --- .../src/parser/_helpers/ddl/constraints.rs | 2 +- .../_helpers/ddl/snowflake_alter_resources.rs | 23 ++++-- .../tests/parser/test_snowflake_alter.rs | 72 +++++++++++++++++++ 3 files changed, 92 insertions(+), 5 deletions(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/constraints.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/constraints.rs index a3e2414dd..7c44504ea 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/constraints.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/constraints.rs @@ -1460,7 +1460,7 @@ impl Parser { { let shorter = &kind[..kind.len() - 1]; let kind_word_named = kind.len() > 1 - && self.is_statement_end_at(0) + && (self.is_statement_end_at(0) || self.check(TokenType::Dot)) && SNOWFLAKE_DROP_KINDS.contains(&shorter); if kind_word_named { self.current -= 1; diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs index 9fa8c3de7..5f79a971d 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs @@ -196,12 +196,27 @@ fn resource_actions(kind: &str) -> &'static [&'static [&'static str]] { } impl Parser { + /// Whether `MODEL MONITOR` here starts `ALTER MODEL ` with a name or schema called monitor: a dot or a whole ALTER MODEL action follows. + fn alters_model_named_monitor(&self) -> bool { + if !(self.check_identifier("MODEL") && self.check_next_identifier("MONITOR")) { + return false; + } + match self.text_at(2).as_deref() { + Some("." | "SET" | "UNSET") => true, + Some("RENAME") => self.text_at(3).as_deref() == Some("TO"), + Some("MODIFY" | "ADD" | "DROP") => self.text_at(3).as_deref() == Some("VERSION"), + Some("VERSION") => { + matches!(self.text_at(4).as_deref(), Some("SET" | "UNSET")) + && self.text_at(5).as_deref() == Some("ALIAS") + } + _ => false, + } + } + /// Parse a Snowflake ALTER of a kind in RESOURCE_KINDS, or None when the next words name another kind. pub(super) fn parse_alter_snowflake_resource(&mut self) -> Result> { - let model_named_monitor = self.check_identifier("MODEL") - && self.check_next_identifier("MONITOR") - && matches!(self.text_at(2).as_deref(), Some("SET" | "UNSET")); - let words: &[&str] = if model_named_monitor && self.match_identifier("MODEL") { + let words: &[&str] = if self.alters_model_named_monitor() && self.match_identifier("MODEL") + { &["MODEL"] } else if let Some(words) = RESOURCE_KINDS .iter() diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_alter.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_alter.rs index ce94302dc..047aead39 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_alter.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_alter.rs @@ -185,6 +185,78 @@ fn given_a_snowflake_alter_of_an_object_kind_when_parsing_then_recorded_rejectio dialect: Dialect::Snowflake, expected_accepted: true, }, + AcceptanceTestCase { + description: "a model named monitor is renamed", + sql: "ALTER MODEL monitor RENAME TO m3 ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model named monitor adds a version", + sql: "ALTER MODEL monitor ADD VERSION v2 FROM MODEL m2 ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model in a schema named monitor sets its comment", + sql: "ALTER MODEL monitor.m1 SET COMMENT = 'x' ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model monitor still adds segment columns", + sql: "ALTER MODEL MONITOR mm ADD SEGMENT_COLUMN = 'c1' ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model monitor named rename is still a monitor", + sql: "ALTER MODEL MONITOR rename SUSPEND ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model monitor named modify is still a monitor", + sql: "ALTER MODEL MONITOR modify RESUME ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model monitor named version is still a monitor", + sql: "ALTER MODEL MONITOR version SET REFRESH_INTERVAL = '1 minute' ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model named monitor sets a version alias", + sql: "ALTER MODEL monitor VERSION v1 SET ALIAS = a1 ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model named monitor modifies a version", + sql: "ALTER MODEL monitor MODIFY VERSION v1 SET COMMENT = 'x' ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model named monitor drops a version", + sql: "ALTER MODEL monitor DROP VERSION v1 ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model in a schema named monitor is dropped", + sql: "DROP MODEL monitor.m1 ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, + AcceptanceTestCase { + description: "a model monitor is still dropped by name", + sql: "DROP MODEL MONITOR mm ;", + dialect: Dialect::Snowflake, + expected_accepted: true, + }, AcceptanceTestCase { description: "TAG pairs are a SET of their own (every recorded mix is errno 1003)", sql: "ALTER COMPUTE POOL v1 SET MIN_NODES = 1 TAG v1 = 'm' ;", From adac6d0ebf2dd1b3a2e5b98ed6abbebd6dcaac94 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 18:43:00 +0000 Subject: [PATCH 03/14] fix(syntax): record a stage path as a stage reference, not a string The unquoted stage paths of EXECUTE JOB SERVICE, CREATE and ALTER SERVICE, ALTER MODEL ADD VERSION and stage-valued properties were stored as string literals, so a tree could not tell @s1 from '@s1'. They are now stage references with the stage name and the path within it. A quoted value stays a string literal, since it may be any text, such as a comment that starts with @. --- .../_helpers/ddl/snowflake_alter_resources.rs | 20 ++++++++++++++-- .../tests/parser/test_snowflake_execute.rs | 24 ++++++++++++++++--- 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs index 5f79a971d..f3c21b84f 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_alter_resources.rs @@ -7,6 +7,7 @@ use crate::parser::models::Parser; use sqlquack_syntax::expressions::names::models::Literal; use sqlquack_syntax::expressions::names::models::TableRef; use sqlquack_syntax::expressions::schema_objects::models::ObjectProperty; +use sqlquack_syntax::expressions::statements::models::StageReference; use sqlquack_syntax::expressions::tree::models::Expression; use sqlquack_syntax::expressions::types::models::Tuple; use sqlquack_syntax::tokens::models::TokenType; @@ -610,8 +611,13 @@ impl Parser { !self.is_at_end() && self.peek_text().starts_with('@') } - /// Parse a stage path, which like Snowflake's ends at the first whitespace: `@"s 1"` is not one path. + /// Parse a stage path, which like Snowflake's ends at the first whitespace; a quoted string that starts with @ stays a string. pub(super) fn parse_stage_path(&mut self) -> Result { + if self.check(TokenType::String) || self.check(TokenType::DollarString) { + let text = self.peek_text().to_owned(); + self.skip(); + return Ok(Expression::Literal(Box::new(Literal::String(text)))); + } let mut path = self.peek_text().to_owned(); let mut end = self.peek().span.end; self.skip(); @@ -629,7 +635,17 @@ impl Parser { end = self.peek().span.end; self.skip(); } - Ok(Expression::Literal(Box::new(Literal::String(path)))) + let (name, path) = match path.find('/') { + Some(at) => (path[..at].to_owned(), Some(path[at..].to_owned())), + None => (path, None), + }; + Ok(Expression::StageReference(Box::new(StageReference { + name, + path, + file_format: None, + pattern: None, + quoted: false, + }))) } /// Parse a service's source after FROM: SPECIFICATION or SPECIFICATION_TEMPLATE with a value, ` = ` and USING ( ... ). diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_execute.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_execute.rs index d81dfb1ed..c55aac4aa 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_execute.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_execute.rs @@ -51,10 +51,28 @@ fn given_a_snowflake_execute_of_a_job_service_when_parsing_then_the_tree_keeps_i expected_value: json!("IN COMPUTE POOL"), }, ProjectionTestCase { - description: "the stage path is kept whole", + description: "the stage is a stage, not a string", sql: SQL, - pointer: "/0/execute_object/properties/1/value/literal/value", - expected_value: json!("@s1/a"), + pointer: "/0/execute_object/properties/1/value/stage_reference/name", + expected_value: json!("@s1"), + }, + ProjectionTestCase { + description: "a quoted value that starts with @ stays a string", + sql: "ALTER MODEL m1 SET COMMENT = '@ml-team owns this' ;", + pointer: "/0/alter_object/properties/0/value/literal/value", + expected_value: json!("@ml-team owns this"), + }, + ProjectionTestCase { + description: "a dollar-quoted value that starts with @ stays a string", + sql: "ALTER MODEL m1 SET COMMENT = $$@ml-team owns this$$ ;", + pointer: "/0/alter_object/properties/0/value/literal/value", + expected_value: json!("@ml-team owns this"), + }, + ProjectionTestCase { + description: "the path within the stage is kept", + sql: SQL, + pointer: "/0/execute_object/properties/1/value/stage_reference/path", + expected_value: json!("/a"), }, ProjectionTestCase { description: "the template file follows the stage", From 868d067096c5b1a3408135456cf7dcfb81afef67 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 19:02:29 +0000 Subject: [PATCH 04/14] fix(syntax): accept an online feature table without TARGET_LAG or with IF NOT EXISTS Snowflake parses CREATE ONLINE FEATURE TABLE without a TARGET_LAG clause (errno 2029, after parsing) and with IF NOT EXISTS (errno 2003), so only WAREHOUSE stays required and IF NOT EXISTS is read after the kind. --- .../_helpers/ddl/snowflake_event_tables.rs | 18 +++++++++--------- .../src/parser/constants.rs | 6 ++++++ .../tests/parser/test_snowflake_tables.rs | 10 ++++++++++ 3 files changed, 25 insertions(+), 9 deletions(-) diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs index 9156dcfce..cb98e501c 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/ddl/snowflake_event_tables.rs @@ -2,7 +2,9 @@ use crate::parser::_helpers::ddl::snowflake_alter::property; use crate::parser::_helpers::ddl::snowflake_create_table::SnowflakeTableKind; -use crate::parser::constants::{EVENT_TABLE, SNOWFLAKE_DYNAMIC_TABLE_REQUIRED, TABLE_KEYWORD}; +use crate::parser::constants::{ + EVENT_TABLE, ONLINE_FEATURE_TABLE, ONLINE_FEATURE_TABLE_REQUIRED, TABLE_KEYWORD, +}; use crate::parser::models::Parser; use sqlquack_syntax::expressions::names::models::Identifier; use sqlquack_syntax::expressions::operators::models::BinaryOp; @@ -34,11 +36,12 @@ impl Parser { } else if self.match_text_seq(&["EVENT", "ROUTING", "TABLE"]) { "EVENT ROUTING TABLE" } else if self.match_text_seq(&["ONLINE", "FEATURE", "TABLE"]) { - "ONLINE FEATURE TABLE" + ONLINE_FEATURE_TABLE } else { return Ok(None); }; - let if_not_exists = kind == EVENT_TABLE && self.check(TokenType::If); + let if_not_exists = + (kind == EVENT_TABLE || kind == ONLINE_FEATURE_TABLE) && self.check(TokenType::If); if if_not_exists { if !self.match_keywords(&[TokenType::If, TokenType::Not, TokenType::Exists]) { return Err(self.parse_error("Expected IF NOT EXISTS")); @@ -194,7 +197,7 @@ impl Parser { }))) } - /// `PRIMARY KEY ( ) ... FROM `: the key, the properties with TARGET_LAG and WAREHOUSE required, and the source. + /// `PRIMARY KEY ( ) ... FROM `: the key, the properties with WAREHOUSE required, and the source. fn parse_online_feature_table( &mut self, ) -> Result<(Expression, Vec, Expression)> { @@ -212,11 +215,8 @@ impl Parser { keys.extend(found_key); properties.extend(found); } - let missing = SNOWFLAKE_DYNAMIC_TABLE_REQUIRED - .iter() - .any(|required| !keys.contains(&required.to_string())); - if missing { - return Err(self.parse_error("Expected TARGET_LAG and WAREHOUSE")); + if !keys.iter().any(|key| key == ONLINE_FEATURE_TABLE_REQUIRED) { + return Err(self.parse_error("Expected WAREHOUSE")); } self.expect_token(TokenType::From)?; let source = Expression::Table(Box::new(self.parse_iceberg_object_name()?)); diff --git a/crates/sqlquack-syntax-snowflake/src/parser/constants.rs b/crates/sqlquack-syntax-snowflake/src/parser/constants.rs index 2ae217c1c..cfa6e0172 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/constants.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/constants.rs @@ -203,6 +203,12 @@ pub(crate) const UNSET_COMMENT: &str = "UNSET COMMENT"; /// The text "EVENT TABLE", as comparisons test it. pub(crate) const EVENT_TABLE: &str = "EVENT TABLE"; +/// The text "ONLINE FEATURE TABLE", as comparisons test it. +pub(crate) const ONLINE_FEATURE_TABLE: &str = "ONLINE FEATURE TABLE"; + +/// The one property an online feature table requires. +pub(crate) const ONLINE_FEATURE_TABLE_REQUIRED: &str = "WAREHOUSE"; + /// The keyword TABLE, as comparisons test it. pub(crate) const TABLE_KEYWORD: &str = "TABLE"; diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_tables.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_tables.rs index 09beb421a..1d4789ba6 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_tables.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_snowflake_tables.rs @@ -558,6 +558,16 @@ fn given_snowflake_event_routing_and_feature_tables_when_parsing_then_their_gram sql: "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) TARGET_LAG = '1 minute' WAREHOUSE = 'v1' TAG ( v1 = m1 ) FROM t2 ;", expected_kind: Some("create_object"), }, + SnowflakeVerdictTestCase { + description: "an online feature table without TARGET_LAG (recorded errno 2029, after parsing)", + sql: "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) WAREHOUSE = v1 FROM t2 ;", + expected_kind: Some("create_object"), + }, + SnowflakeVerdictTestCase { + description: "an online feature table with IF NOT EXISTS (recorded errno 2003, after parsing)", + sql: "CREATE ONLINE FEATURE TABLE IF NOT EXISTS v1 PRIMARY KEY ( v1 ) TARGET_LAG = '1 minute' WAREHOUSE = v1 FROM t2 ;", + expected_kind: Some("create_object"), + }, SnowflakeVerdictTestCase { description: "an online feature table with a reserved warehouse name (recorded errno 1003)", sql: "CREATE ONLINE FEATURE TABLE v1 PRIMARY KEY ( v1 ) TARGET_LAG = '1 minute' WAREHOUSE = SELECT FROM t2 ;", From 5b11e00dc09e9743b2a8f008fcaff5fcd2da2dda Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 19:12:21 +0000 Subject: [PATCH 05/14] chore(syntax-coverage): pin the batch that records read-order clauses after ON, model monitor arrays and online feature table shapes The pinned evidence adds 26 receipts and the cases they settle. Every read-order clause after ON is parsed (errno 1868) or a syntax error (1003), every model monitor column array parses, and the two online feature table shapes the parser refused now parse. The receipt-disagreement list is unchanged. Three forms whose fingerprints changed only because stage paths became stage references are re-approved: of their 104 cases, 65 trees are unchanged and 39 differ only by the stage reference. Verified forms stay at 2,418; satisfied obligations move from 82,598 to 82,562 because replaced and withdrawn obligations leave and 18 new ones wait on cases the capture guard holds. --- coverage/syntax/baseline.json | 200 +++++++++++++-------------- coverage/syntax/marks/ddl.jsonl | 4 + coverage/syntax/reviews/ddl.toml | 20 +++ coverage/syntax/reviews/utility.toml | 17 +++ evidence.toml | 4 +- 5 files changed, 138 insertions(+), 107 deletions(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index c47e1df50..8dfba6ee5 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -28995,30 +28995,20 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o022", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o023", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o024", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o025", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o026", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o027", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o028", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o029", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o030", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o031", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o032", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o033", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o034", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o035", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o036", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o037", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o038", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o039", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o040", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o041", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o042", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o043", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o044", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o045", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o046", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o047", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o048", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o049", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o050", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o051", @@ -29044,18 +29034,18 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o072", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o073", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o074", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o075", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o076", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o077", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o078", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o079", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o080", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o081", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o082", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o083", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o084", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o085", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o086", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o087", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o088", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o089", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o090", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o091", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o092", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o093", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o094", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o095", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o096", "sf.ddl.create-model-monitor.version-function-source-warehouse.o001", "sf.ddl.create-model-monitor.version-function-source-warehouse.o002", "sf.ddl.create-model-monitor.version-function-source-warehouse.o003", @@ -29087,40 +29077,26 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.o029", "sf.ddl.create-model-monitor.version-function-source-warehouse.o030", "sf.ddl.create-model-monitor.version-function-source-warehouse.o031", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o032", "sf.ddl.create-model-monitor.version-function-source-warehouse.o033", "sf.ddl.create-model-monitor.version-function-source-warehouse.o034", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o035", "sf.ddl.create-model-monitor.version-function-source-warehouse.o036", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o037", "sf.ddl.create-model-monitor.version-function-source-warehouse.o038", "sf.ddl.create-model-monitor.version-function-source-warehouse.o039", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o040", "sf.ddl.create-model-monitor.version-function-source-warehouse.o041", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o042", "sf.ddl.create-model-monitor.version-function-source-warehouse.o043", "sf.ddl.create-model-monitor.version-function-source-warehouse.o044", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o045", "sf.ddl.create-model-monitor.version-function-source-warehouse.o046", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o047", "sf.ddl.create-model-monitor.version-function-source-warehouse.o048", "sf.ddl.create-model-monitor.version-function-source-warehouse.o049", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o050", "sf.ddl.create-model-monitor.version-function-source-warehouse.o051", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o052", "sf.ddl.create-model-monitor.version-function-source-warehouse.o053", "sf.ddl.create-model-monitor.version-function-source-warehouse.o054", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o055", "sf.ddl.create-model-monitor.version-function-source-warehouse.o056", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o057", "sf.ddl.create-model-monitor.version-function-source-warehouse.o058", "sf.ddl.create-model-monitor.version-function-source-warehouse.o059", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o060", "sf.ddl.create-model-monitor.version-function-source-warehouse.o061", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o062", "sf.ddl.create-model-monitor.version-function-source-warehouse.o063", "sf.ddl.create-model-monitor.version-function-source-warehouse.o064", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o065", "sf.ddl.create-model-monitor.version-function-source-warehouse.o066", "sf.ddl.create-model-monitor.version-function-source-warehouse.o067", "sf.ddl.create-model-monitor.version-function-source-warehouse.o068", @@ -29152,20 +29128,6 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.o095", "sf.ddl.create-model-monitor.version-function-source-warehouse.o096", "sf.ddl.create-model-monitor.version-function-source-warehouse.o097", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o098", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o099", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o100", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o101", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o102", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o103", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o104", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o105", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o106", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o107", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o108", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o109", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o110", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o111", "sf.ddl.create-model-monitor.version-function-source-warehouse.o112", "sf.ddl.create-model-monitor.version-function-source-warehouse.o113", "sf.ddl.create-model.internalstage.o006", @@ -29306,6 +29268,11 @@ "sf.ddl.create-online-feature-table.o071", "sf.ddl.create-online-feature-table.o072", "sf.ddl.create-online-feature-table.o073", + "sf.ddl.create-online-feature-table.o074", + "sf.ddl.create-online-feature-table.o075", + "sf.ddl.create-online-feature-table.o076", + "sf.ddl.create-online-feature-table.o078", + "sf.ddl.create-online-feature-table.o079", "sf.ddl.create-pipe.create-or-alter-pipe.o002", "sf.ddl.create-pipe.create-or-alter-pipe.o004", "sf.ddl.create-pipe.create-or-alter-pipe.o013", @@ -39780,11 +39747,8 @@ "sf.ddl.create-warehouse.create-or-alter-warehouse.o032", "sf.ddl.create-warehouse.create-or-alter-warehouse.o033", "sf.ddl.create-warehouse.create-or-alter-warehouse.o034", - "sf.ddl.create-warehouse.create-or-alter-warehouse.o035", "sf.ddl.create-warehouse.create-or-alter-warehouse.o036", - "sf.ddl.create-warehouse.create-or-alter-warehouse.o037", "sf.ddl.create-warehouse.create-or-alter-warehouse.o038", - "sf.ddl.create-warehouse.create-or-alter-warehouse.o039", "sf.ddl.create-warehouse.create-or-alter-warehouse.o040", "sf.ddl.create-warehouse.create-or-alter-warehouse.o041", "sf.ddl.create-warehouse.create-or-alter-warehouse.o042", @@ -62126,18 +62090,18 @@ "sf.query.join.join.o020", "sf.query.join.join.o021", "sf.query.join.join.o022", - "sf.query.join.join.o023", - "sf.query.join.join.o024", - "sf.query.join.join.o025", "sf.query.join.join.o026", - "sf.query.join.join.o027", "sf.query.join.join.o028", - "sf.query.join.join.o030", - "sf.query.join.join.o031", "sf.query.join.join.o032", - "sf.query.join.join.o033", - "sf.query.join.join.o034", "sf.query.join.join.o035", + "sf.query.join.join.o036", + "sf.query.join.join.o037", + "sf.query.join.join.o038", + "sf.query.join.join.o039", + "sf.query.join.join.o040", + "sf.query.join.join.o041", + "sf.query.join.join.o042", + "sf.query.join.join.o043", "sf.query.join.join-2.o001", "sf.query.join.join-2.o002", "sf.query.join.join-2.o003", @@ -94360,57 +94324,47 @@ "sf.ddl.create-mcp-server.k4880fb6e8d41", "sf.ddl.create-mcp-server.k72500e901f6a", "sf.ddl.create-mcp-server.k842e2a8044bf", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k01c2fb358d7c", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k028e87d4cbe9", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k05d9bb9ff511", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k177c889dcd0f", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k185ed580d270", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k1b5611fcf31c", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k1bab38f496cd", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k1ca8d3bb06ef", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k24a17c87d0d5", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k2716037856d0", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k2960c12468dc", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k3c972000bd3d", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k40eaefe47128", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k5c6ea075b24d", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k621bd70c81fc", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k652d3b858954", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k6bf6895a506a", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k6e677f9f5f7e", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k6ed3e0d9093b", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k7a30cff41adc", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k7ab59f7dd7e5", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k741744e9e5bd", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k7cd64487aef6", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8517fce13d80", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8c5e57a1192c", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8caaeb9ae1cd", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8cf93e5865d8", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k9112177ece6e", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k9bdec7cb988c", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka8c9b3516b7b", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kab39c68889bf", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kac3d2b00c03f", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kbe1dee9e9f2c", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kce690e8c0713", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kd9b7107761ec", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kde628a79a5e5", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ke1bb9c3bf411", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kecd8d9cfa86a", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kfdfaa8815a0f", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k0062b2ca7ea0", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ke37ad49e0bdb", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kecace24e1a91", "sf.ddl.create-model-monitor.version-function-source-warehouse.k037b943d730f", "sf.ddl.create-model-monitor.version-function-source-warehouse.k0439cf2811d4", "sf.ddl.create-model-monitor.version-function-source-warehouse.k093eb664620f", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k0e605874cdda", "sf.ddl.create-model-monitor.version-function-source-warehouse.k1347648194c2", "sf.ddl.create-model-monitor.version-function-source-warehouse.k18b1e8f99744", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k22239af73d4e", "sf.ddl.create-model-monitor.version-function-source-warehouse.k29687269a1b7", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k2e92ec7bcc67", "sf.ddl.create-model-monitor.version-function-source-warehouse.k33769c65b52e", "sf.ddl.create-model-monitor.version-function-source-warehouse.k357b9a314f55", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k451d4bdefe28", "sf.ddl.create-model-monitor.version-function-source-warehouse.k4976383771b4", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k4d94ae53a83d", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k5024dd22d1e0", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k54c96be5bd9e", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k56b0a3636f68", "sf.ddl.create-model-monitor.version-function-source-warehouse.k5e448de3125e", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k5e68651b03a0", "sf.ddl.create-model-monitor.version-function-source-warehouse.k695e8326b2dc", "sf.ddl.create-model-monitor.version-function-source-warehouse.k6a7a0662a744", "sf.ddl.create-model-monitor.version-function-source-warehouse.k6efa1d0fdb8c", @@ -94418,21 +94372,17 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.k771f25933a29", "sf.ddl.create-model-monitor.version-function-source-warehouse.k783919376ef4", "sf.ddl.create-model-monitor.version-function-source-warehouse.k82c75caa01e7", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k87d35dd0a799", "sf.ddl.create-model-monitor.version-function-source-warehouse.k8a025b5a9b90", "sf.ddl.create-model-monitor.version-function-source-warehouse.k911c213f6150", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k946005310774", "sf.ddl.create-model-monitor.version-function-source-warehouse.k9d8de043bee4", "sf.ddl.create-model-monitor.version-function-source-warehouse.ka3c9db840acf", "sf.ddl.create-model-monitor.version-function-source-warehouse.kab9c23d2dd6d", "sf.ddl.create-model-monitor.version-function-source-warehouse.kc1ede48d0b95", - "sf.ddl.create-model-monitor.version-function-source-warehouse.kd4a7baa134fe", "sf.ddl.create-model-monitor.version-function-source-warehouse.kd51a50e97c3c", "sf.ddl.create-model-monitor.version-function-source-warehouse.kefccce311a72", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf4edc72bd8d0", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf5cd06438754", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf749a23d10d5", - "sf.ddl.create-model-monitor.version-function-source-warehouse.kf8a3cce413a3", "sf.ddl.create-model-monitor.version-function-source-warehouse.kfac141852901", "sf.ddl.create-model-monitor.version-function-source-warehouse.kfbaa79f6c2cc", "sf.ddl.create-model.internalstage.k1d42e16e76d5", @@ -94518,6 +94468,7 @@ "sf.ddl.create-notebook.kfd79250989ae", "sf.ddl.create-online-feature-table.k13ac2af94869", "sf.ddl.create-online-feature-table.k2aa53372b933", + "sf.ddl.create-online-feature-table.k2e0ad02666a1", "sf.ddl.create-online-feature-table.k2ff297042b16", "sf.ddl.create-online-feature-table.k3297fbf0f612", "sf.ddl.create-online-feature-table.k33ab2aad2556", @@ -94526,6 +94477,7 @@ "sf.ddl.create-online-feature-table.k4c6e3b17dba0", "sf.ddl.create-online-feature-table.k5817b9531c60", "sf.ddl.create-online-feature-table.k64de8b01b15b", + "sf.ddl.create-online-feature-table.k70cf9571fb33", "sf.ddl.create-online-feature-table.k7bc63a3fbfb8", "sf.ddl.create-online-feature-table.k82e3a421c05c", "sf.ddl.create-online-feature-table.k834d961b3a7f", @@ -94535,6 +94487,8 @@ "sf.ddl.create-online-feature-table.kad6a152113fa", "sf.ddl.create-online-feature-table.kb55ca5d175d4", "sf.ddl.create-online-feature-table.kbe5ddb9b78b4", + "sf.ddl.create-online-feature-table.kc4789fcae99b", + "sf.ddl.create-online-feature-table.kdbb48f7f233f", "sf.ddl.create-online-feature-table.ke2afccccc7b6", "sf.ddl.create-online-feature-table.keda354640c4a", "sf.ddl.create-online-feature-table.kf02223eaf78c", @@ -98181,7 +98135,6 @@ "sf.ddl.create-warehouse.create-or-alter-warehouse.k50d053677eef", "sf.ddl.create-warehouse.create-or-alter-warehouse.k549e72e8b8ba", "sf.ddl.create-warehouse.create-or-alter-warehouse.k56a0739a97b2", - "sf.ddl.create-warehouse.create-or-alter-warehouse.k59ce04142d2d", "sf.ddl.create-warehouse.create-or-alter-warehouse.k5a9edc9c433a", "sf.ddl.create-warehouse.create-or-alter-warehouse.k5f0ebad6cb82", "sf.ddl.create-warehouse.create-or-alter-warehouse.k63e892b8821d", @@ -105028,17 +104981,17 @@ "sf.query.join.join-2.k9f2b3b608fa1", "sf.query.join.join-2.ka101cce59841", "sf.query.join.join-2.kde21cc593c3b", - "sf.query.join.join.k01b8b75d55b0", "sf.query.join.join.k05e4f9e324c8", "sf.query.join.join.k1fb531da7187", - "sf.query.join.join.k1fe6cdfd0c31", + "sf.query.join.join.k2c14b695ac72", + "sf.query.join.join.k3ee0696964e1", "sf.query.join.join.k550e3acf56bf", "sf.query.join.join.k579ecbc06bcd", + "sf.query.join.join.k7a959b831f78", "sf.query.join.join.k8b1a72dc88a7", - "sf.query.join.join.ka093fd0ae52f", "sf.query.join.join.ka8667f105441", - "sf.query.join.join.kaef61209e08b", "sf.query.join.join.kbcaea6c005a3", + "sf.query.join.join.kceb0ba9f80d4", "sf.query.join.join.syntax.k088cd26ed8ad", "sf.query.join.join.syntax.k0d44721aa065", "sf.query.join.join.syntax.k189a79dc1092", @@ -113044,7 +112997,9 @@ "sf.utility.execute-immediate-from.kabb79365dfcb", "sf.utility.execute-immediate-from.kaff26e859b32", "sf.utility.execute-immediate-from.kb4598310cf27", + "sf.utility.execute-immediate-from.kd2b2dee1a470", "sf.utility.execute-immediate-from.ke906fd42c75e", + "sf.utility.execute-immediate-from.kea3e07c355cb", "sf.utility.execute-immediate-from.kf30c1543208e", "sf.utility.execute-immediate-from.kffc0f9765f0b", "sf.utility.execute-immediate.immediate-2.k75938830bcaf", @@ -124624,21 +124579,16 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k29edbc6a4a7d", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k30247ddc3e47", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k30890e7d1213", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k3617e3dca235", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k45af62d84e71", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k4fc674687779", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k51958d973b9f", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k59a3c6bc53d7", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k5d3c2a9690c8", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k643622f0636c", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k70ad00a68f57", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k7b5038c11959", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k840b9e989523", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k84278b6d3272", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k9b5a4a6eaf0f", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka8dfed9fc1e5", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka9ef0f1507b7", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kb0e3b6e3f54b", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kbb2e5b2c2159", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kc25c0129756f", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kc4872c673897", @@ -124652,13 +124602,10 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.k00d348f15d45", "sf.ddl.create-model-monitor.version-function-source-warehouse.k03cc1f4c2fb8", "sf.ddl.create-model-monitor.version-function-source-warehouse.k0ca3d9bd985a", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k107eaf79a3a8", "sf.ddl.create-model-monitor.version-function-source-warehouse.k19bb34440022", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k1b9483cc946c", "sf.ddl.create-model-monitor.version-function-source-warehouse.k1fdedbbbd003", "sf.ddl.create-model-monitor.version-function-source-warehouse.k2181fdaf9db7", "sf.ddl.create-model-monitor.version-function-source-warehouse.k33d1f12070cf", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k373bd7733543", "sf.ddl.create-model-monitor.version-function-source-warehouse.k37aad2caa6ed", "sf.ddl.create-model-monitor.version-function-source-warehouse.k3b2fecb8d6d4", "sf.ddl.create-model-monitor.version-function-source-warehouse.k4269ec696a10", @@ -124676,9 +124623,6 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.k802685c3bfe9", "sf.ddl.create-model-monitor.version-function-source-warehouse.k8c510b62ce24", "sf.ddl.create-model-monitor.version-function-source-warehouse.k961c5a40debd", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k9c4c71c09d1d", - "sf.ddl.create-model-monitor.version-function-source-warehouse.ka1eeb0b9c65f", - "sf.ddl.create-model-monitor.version-function-source-warehouse.ka40a48d7bb89", "sf.ddl.create-model-monitor.version-function-source-warehouse.ka6f35d9ec20f", "sf.ddl.create-model-monitor.version-function-source-warehouse.ka770aed64be8", "sf.ddl.create-model-monitor.version-function-source-warehouse.ka8d19173e5df", @@ -124687,7 +124631,6 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.kc3f87af3c1ab", "sf.ddl.create-model-monitor.version-function-source-warehouse.kd25b32e85857", "sf.ddl.create-model-monitor.version-function-source-warehouse.kde1e3232016a", - "sf.ddl.create-model-monitor.version-function-source-warehouse.ke26f5de9784c", "sf.ddl.create-model-monitor.version-function-source-warehouse.kef95e787a944", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf3633ab9c31f", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf72a505d3bd7", @@ -124762,6 +124705,7 @@ "sf.ddl.create-online-feature-table.k7e65272f4287", "sf.ddl.create-online-feature-table.k849ad670beb9", "sf.ddl.create-online-feature-table.k8c6e03afd71d", + "sf.ddl.create-online-feature-table.k91fbbc1dbbbe", "sf.ddl.create-online-feature-table.k9b7596c4f9d3", "sf.ddl.create-online-feature-table.ka33b0c9b2c36", "sf.ddl.create-online-feature-table.kae307d601029", @@ -137379,13 +137323,13 @@ "sf.query.join-lateral.kea3b47725f1d", "sf.query.join.join.k014af02f7dda", "sf.query.join.join.k060cac231cdc", - "sf.query.join.join.k267005238434", - "sf.query.join.join.k2c31ef8a2d0f", - "sf.query.join.join.k7fcce1fe63e8", + "sf.query.join.join.k3386ca1eaac1", "sf.query.join.join.k85416f626046", - "sf.query.join.join.kaf1a5af38146", + "sf.query.join.join.k8bae3666cbe5", "sf.query.join.join.kaffa5b5d0b95", - "sf.query.join.join.kebb25d0fd07e", + "sf.query.join.join.kb1ff984638d9", + "sf.query.join.join.kbd12b962d32f", + "sf.query.join.join.kf8b9158d8d7b", "sf.query.join.join.syntax.k4be20724185c", "sf.query.join.join.syntax.k5249991752ed", "sf.query.join.join.syntax.k90bad46f888f", @@ -149352,6 +149296,42 @@ "sf.ddl.create-iceberg-table.table.iceberg-rest-in-a-catalog-linked-database.k97c92a5930eb", "sf.ddl.create-iceberg-table.table.iceberg-rest-in-a-catalog-linked-database.k99f8e39993ac", "sf.ddl.create-iceberg-table.table.iceberg-rest-in-a-catalog-linked-database.kb8d964c8574d", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k01c2fb358d7c", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k1ca8d3bb06ef", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k3617e3dca235", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k59a3c6bc53d7", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k643622f0636c", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k7a30cff41adc", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k7ab59f7dd7e5", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8517fce13d80", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8caaeb9ae1cd", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka8c9b3516b7b", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka9ef0f1507b7", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kb0e3b6e3f54b", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kde628a79a5e5", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kecd8d9cfa86a", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kfdfaa8815a0f", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k0062b2ca7ea0", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k0e605874cdda", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k107eaf79a3a8", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k1b9483cc946c", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k22239af73d4e", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k2e92ec7bcc67", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k373bd7733543", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k451d4bdefe28", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k4d94ae53a83d", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k5024dd22d1e0", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k54c96be5bd9e", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k56b0a3636f68", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k5e68651b03a0", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k87d35dd0a799", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k946005310774", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k9c4c71c09d1d", + "sf.ddl.create-model-monitor.version-function-source-warehouse.ka1eeb0b9c65f", + "sf.ddl.create-model-monitor.version-function-source-warehouse.ka40a48d7bb89", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kd4a7baa134fe", + "sf.ddl.create-model-monitor.version-function-source-warehouse.ke26f5de9784c", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kf8a3cce413a3", "sf.ddl.create-model.internalstage.k89f9105f15ba", "sf.ddl.create-model.internalstage.ka7cd6e5074b5", "sf.ddl.create-model.internalstage.ke73c5b998055", @@ -149404,6 +149384,7 @@ "sf.ddl.create-task.define-task.ke474e998ee63", "sf.ddl.create-task.define-task.keeeb6ab8d05e", "sf.ddl.create-task.define-task.kf52f318dcaf5", + "sf.ddl.create-warehouse.create-or-alter-warehouse.k59ce04142d2d", "sf.dml.copy-files.from-select-from.k000bfe7b2770", "sf.dml.copy-files.from-select-from.k115e2f6e996c", "sf.dml.copy-files.from.k730fe88084b4", @@ -149416,6 +149397,15 @@ "sf.functions.cast.cast-as.k28124ee3d309", "sf.functions.cast.cast-as.ke781ca0e7651", "sf.query.from.kbd5234cefead", + "sf.query.join.join.k01b8b75d55b0", + "sf.query.join.join.k1fe6cdfd0c31", + "sf.query.join.join.k267005238434", + "sf.query.join.join.k2c31ef8a2d0f", + "sf.query.join.join.k7fcce1fe63e8", + "sf.query.join.join.ka093fd0ae52f", + "sf.query.join.join.kaef61209e08b", + "sf.query.join.join.kaf1a5af38146", + "sf.query.join.join.kebb25d0fd07e", "sf.query.join.join.syntax.k04ce7f9db935", "sf.query.join.join.syntax.k0cbe11000c68", "sf.query.join.join.syntax.k16cef4c47cd3", diff --git a/coverage/syntax/marks/ddl.jsonl b/coverage/syntax/marks/ddl.jsonl index 2c7ee4b08..29b58d857 100644 --- a/coverage/syntax/marks/ddl.jsonl +++ b/coverage/syntax/marks/ddl.jsonl @@ -2098,10 +2098,14 @@ {"case_id":"sf.ddl.create-notebook.kf71b1b4702de","mark":"settled reject","obligations":["sf.ddl.create-notebook.o013"],"sql_sha256":"f71b1b4702de64447441cd5f40fb62dcca833a85abb6473ba247c88ca16a8d4e"} {"case_id":"sf.ddl.create-notebook.kfd79250989ae","mark":"settled accept","obligations":["sf.ddl.create-notebook.o023"],"sql_sha256":"fd79250989aebff6597e3a636b41e90d1d6e42804df29a02314f07ffb0ae5d3a"} {"case_id":"sf.ddl.create-online-feature-table.k2aa53372b933","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o024"],"sql_sha256":"2aa53372b933ce087d680e92ffcad6b08708c361652399dcbb01327c29b1d84b"} +{"case_id":"sf.ddl.create-online-feature-table.k2e0ad02666a1","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o075"],"sql_sha256":"2e0ad02666a1d5e5adbab093770c2b12f5cf0afe4d163201a9c620b14e23ce09"} {"case_id":"sf.ddl.create-online-feature-table.k4c6e3b17dba0","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o014"],"sql_sha256":"4c6e3b17dba0e746234f482703475675f812a91c5479c4cd3b58378c7210065f"} {"case_id":"sf.ddl.create-online-feature-table.k5817b9531c60","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o031"],"sql_sha256":"5817b9531c60bb8619e832439204e052c99fef7ee983ce477bbc59f33f4aa907"} +{"case_id":"sf.ddl.create-online-feature-table.k70cf9571fb33","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o076"],"sql_sha256":"70cf9571fb33d026197bcf0b2ea06713637b37cf7b75f88421b1ae003be60706"} {"case_id":"sf.ddl.create-online-feature-table.k82e3a421c05c","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o041"],"sql_sha256":"82e3a421c05cadbee177d1921a847fd9075f6962d344f55b97a2f354c74e219e"} {"case_id":"sf.ddl.create-online-feature-table.kad6a152113fa","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o073"],"sql_sha256":"ad6a152113fab275bfe9e27a6039d816704baf8682da595525d7c1328a00b0ae"} +{"case_id":"sf.ddl.create-online-feature-table.kc4789fcae99b","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o079"],"sql_sha256":"c4789fcae99bd62d8bd7241fdbff8a29eedf6f154102efac2b0d083a16ae0839"} +{"case_id":"sf.ddl.create-online-feature-table.kdbb48f7f233f","mark":"settled accept","obligations":["sf.ddl.create-online-feature-table.o074"],"sql_sha256":"dbb48f7f233f7240d9c2be91115969d2b644fbd06f4e399ee0f4eff45a3a6391"} {"case_id":"sf.ddl.create-pipe.create-or-alter-pipe.k3922c76da5a7","mark":"settled accept","obligations":["sf.ddl.create-pipe.create-or-alter-pipe.o034"],"sql_sha256":"3922c76da5a70cca43b4fe128ed1dbb24638fa0c68781f1f512e9cdf33e8d464"} {"case_id":"sf.ddl.create-pipe.create-or-alter-pipe.k9aa281c5ac98","mark":"settled accept","obligations":["sf.ddl.create-pipe.create-or-alter-pipe.o015"],"sql_sha256":"9aa281c5ac98c47c83a48d222980bfd7054e24f57c03aaa3c16e4c79ccb06062"} {"case_id":"sf.ddl.create-pipe.create-or-alter-pipe.kb027d92bea6a","mark":"settled accept","obligations":["sf.ddl.create-pipe.create-or-alter-pipe.o025"],"sql_sha256":"b027d92bea6a74e2861b66f356be1decc4beb577d560c0db06b35147cfc11291"} diff --git a/coverage/syntax/reviews/ddl.toml b/coverage/syntax/reviews/ddl.toml index 10bca333c..a112fd806 100644 --- a/coverage/syntax/reviews/ddl.toml +++ b/coverage/syntax/reviews/ddl.toml @@ -1661,3 +1661,23 @@ note = "Read in full against the documentation page, the obligations, the cases "sf.ddl.create-contact" = "4904656d4fa2d41b0002a0afe96b7d2f2c554ec0b5985e8f459118c2898760aa" "sf.ddl.create-git-repository" = "cafca2ce2d0e340ee9e9440566fa1db4d436c9980b03b15afc799552e48d3360" "sf.ddl.create-image-repository" = "242d5d4d0449489931508b88a124cbd142781842f18c171d1665cb925def4bbf" + +[[review]] +id = "ddl-024" +family = "ddl" +parser_tree = "582bdba8f75e43db2dfbf7d7ba7b39411f31a8fb" +reviewed_utc = "2026-11-12T19:10:18Z" +verdict = "approved" +forms = [ + "sf.ddl.alter-dbt-project.deploy-from", + "sf.ddl.alter-listing.listing-add-version-from", +] +note = "Re-approved after stage paths became stage references: of the 104 cases of these forms, 65 trees are unchanged and 39 differ only by a stage path recorded as a stage reference with its name and path instead of a string. Every scored case agrees with its Snowflake receipt." + +[review.fingerprints] +"sf.ddl.alter-dbt-project.deploy-from" = "41039b633615b26c7f55cf18417fb2ca1f69afa5d38826e032fff7fd00738d4c" +"sf.ddl.alter-listing.listing-add-version-from" = "e53df48860d89c9ad2c17012e223142f1aef85f1d94daf3d99e679cb5733c522" + +[review.definitions] +"sf.ddl.alter-dbt-project.deploy-from" = "73cbec01605ca4f568c243c6a796e3c25420276f0f3ec53d37b0291f60fadf30" +"sf.ddl.alter-listing.listing-add-version-from" = "d2b6b9d6850402fbf3cb027e387305cef8a9e1f08f883561b58bdf7cbca3d380" diff --git a/coverage/syntax/reviews/utility.toml b/coverage/syntax/reviews/utility.toml index 2bb6e49cd..e1c2277b5 100644 --- a/coverage/syntax/reviews/utility.toml +++ b/coverage/syntax/reviews/utility.toml @@ -136,3 +136,20 @@ note = "Read in full against the documentation page, the obligations, the cases [review.definitions] "sf.utility.call-with.language-javascript-as-call" = "db87dc3c49bdc6f86eade43bc6f93d20d98cf0969eb7485be03bcae219c7f772" "sf.utility.execute-job-service" = "f0d2489a4725394b38014d90c6c4832d295b389f79a5b19581c111ddc4237c64" + +[[review]] +id = "utility-007" +family = "utility" +parser_tree = "582bdba8f75e43db2dfbf7d7ba7b39411f31a8fb" +reviewed_utc = "2026-11-12T19:10:18Z" +verdict = "approved" +forms = [ + "sf.utility.execute-job-service", +] +note = "Re-approved after stage paths became stage references: of the 104 cases of these forms, 65 trees are unchanged and 39 differ only by a stage path recorded as a stage reference with its name and path instead of a string. Every scored case agrees with its Snowflake receipt." + +[review.fingerprints] +"sf.utility.execute-job-service" = "60dab65b25cb7ffdaa03ab29e60d825d2fc710dbd9ce7f2fc1d0f4734163eda5" + +[review.definitions] +"sf.utility.execute-job-service" = "f0d2489a4725394b38014d90c6c4832d295b389f79a5b19581c111ddc4237c64" diff --git a/evidence.toml b/evidence.toml index a4606a296..0e75f61d2 100644 --- a/evidence.toml +++ b/evidence.toml @@ -1,4 +1,4 @@ # The evidence SQLQuack's checks read: one commit of the evidence repository, and the SHA-256 of its files. repository = "https://github.com/sqlstack-io/sqlquack-evidence.git" -commit = "150c169f048f46acdc4a0f76f00f1953d8bba202" -content_sha256 = "a36b60031d53d8cc0d1f25bb661d6200820a588fe5852651f4cc179cd52dd111" +commit = "b59884e0d6fa3583969c5c4ae4e197b34644beec" +content_sha256 = "411a906222eecbac33c9bee15f938d7e4d735ba82843bad0aab1ef800a8588ac" From c5fbce56899cfc645c9b5d3f87b5eeea838ea0d7 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 19:18:50 +0000 Subject: [PATCH 06/14] chore(syntax-coverage): approve the JOIN form with ON Its read-order cases after ON are parsed (errno 1868) or syntax errors (1003) as Snowflake reports, and its trees record DIRECTED, the read-order word and its alias as written. Verified forms rise to 2,419. --- coverage/syntax/baseline.json | 2 +- coverage/syntax/reviews/query.toml | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 8dfba6ee5..3b0861492 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -2725,7 +2725,7 @@ "sf.query.into": "verified", "sf.query.join": "absent", "sf.query.join-lateral": "verified", - "sf.query.join.join": "unverified", + "sf.query.join.join": "verified", "sf.query.join.join-2": "verified", "sf.query.join.join.syntax": "verified", "sf.query.limit.fetch": "verified", diff --git a/coverage/syntax/reviews/query.toml b/coverage/syntax/reviews/query.toml index 5f7155a88..51e3b60d9 100644 --- a/coverage/syntax/reviews/query.toml +++ b/coverage/syntax/reviews/query.toml @@ -280,3 +280,20 @@ note = "Read in full against the documentation page, the obligations, the cases [review.definitions] "sf.query.join.join-2" = "4bc06fc3d076a458af27807d8093a505210af7d6d27133f3105be3e026df82ca" "sf.query.join.join.syntax" = "abf625c6216905b38bfa74d505624954f92108406a0eeefe2672de7e36567e19" + +[[review]] +id = "query-013" +family = "query" +parser_tree = "582bdba8f75e43db2dfbf7d7ba7b39411f31a8fb" +reviewed_utc = "2026-11-12T19:17:19Z" +verdict = "approved" +forms = [ + "sf.query.join.join", +] +note = "Read in full against the documentation page, the obligations, the cases and the parse trees: every read-order case after ON is parsed (errno 1868) or a syntax error (1003) as Snowflake reports, and every scored case agrees with its Snowflake receipt." + +[review.fingerprints] +"sf.query.join.join" = "f408da6c1caacee63e105a28b6a23adc58b69e7a110f5e31ea02ec1dd46ff782" + +[review.definitions] +"sf.query.join.join" = "20ab01abd8faed881505d69e9f88c21692e6fd9a316d54149aca51af293a5d5a" From 91761f0270d3d658b54a477bb1e67cea9676816b Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 19:39:07 +0000 Subject: [PATCH 07/14] chore(syntax-limits): split the model monitor gateway all-options case The shared all-options case wrote the column parameters as bare names instead of the documented arrays, so it could not show that the documented options parse together. Each option now has its own case, and the all-options case writes every column parameter as an array with distinct column names. --- coverage/syntax/limits.toml | 124 +++++++++++++++++++++++++++ coverage/syntax/obligations/ddl.toml | 99 +++++++++++---------- 2 files changed, 179 insertions(+), 44 deletions(-) diff --git a/coverage/syntax/limits.toml b/coverage/syntax/limits.toml index 33a20abf7..963f3ceda 100644 --- a/coverage/syntax/limits.toml +++ b/coverage/syntax/limits.toml @@ -84136,3 +84136,127 @@ anchor = "doc.sql.create-online-feature-table / Usage notes" sql = "CREATE ONLINE FEATURE TABLE IF NOT EXISTS v1 PRIMARY KEY ( v1 ) TARGET_LAG = '1 minute' WAREHOUSE = v1 FROM t2 ;" context = "raw" expect = "observe" + +# The gateway model monitor's shared all-options case gave its *_COLUMNS bare names instead of the documented +# arrays, so the obligations it served each get their own case, and the all-options row writes arrays with +# distinct columns, as the page allows each column once. Snowflake raises its errno 1004 after parsing. + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ OR REPLACE ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ OR REPLACE ]" +note = "OR REPLACE on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE OR REPLACE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ IF NOT EXISTS ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ IF NOT EXISTS ]" +note = "IF NOT EXISTS on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR IF NOT EXISTS v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ GROUND_TRUTH = ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ GROUND_TRUTH = ]" +note = "GROUND_TRUTH on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' GROUND_TRUTH = v1 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ GROUND_TRUTH = ]" +note = "a valid operand" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = " in [ GROUND_TRUTH = ]" +note = "a table name as GROUND_TRUTH" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' GROUND_TRUTH = t2 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ COMMENT = '' ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "option_present" +target = "[ COMMENT = '' ]" +note = "COMMENT on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' COMMENT = 'm' ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = "'' in [ COMMENT = '' ]" +note = "a valid string_literal" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "operand_type_class" +target = "'' in [ COMMENT = '' ]" +note = "a string as COMMENT" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' COMMENT = 'c' ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "interaction_all_options" +note = "every independent option of one production together" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" +kind = "interaction_all_options" +note = "every option together, each *_COLUMNS value an array with its own column" +anchor = "doc.sql.create-model-monitor / Syntax / Gateway model monitor" +sql = "CREATE OR REPLACE MODEL MONITOR IF NOT EXISTS v1 WITH MODEL = v1 GATEWAY = v1 FUNCTION = 'm' WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' GROUND_TRUTH = v1 ID_COLUMNS = ( 'c1' ) PREDICTION_CLASS_COLUMNS = ( 'c2' ) PREDICTION_SCORE_COLUMNS = ( 'c3' ) ACTUAL_CLASS_COLUMNS = ( 'c4' ) ACTUAL_SCORE_COLUMNS = ( 'c5' ) COMMENT = 'm' ;" +context = "raw" +expect = "accept" +stage = "semantic" diff --git a/coverage/syntax/obligations/ddl.toml b/coverage/syntax/obligations/ddl.toml index 1b5eb5303..cfdf62b15 100644 --- a/coverage/syntax/obligations/ddl.toml +++ b/coverage/syntax/obligations/ddl.toml @@ -181448,24 +181448,12 @@ kind = "positive" required = true note = "the documented form with every required part and no optional part" -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o002" -kind = "option_present" -required = true -target = "[ OR REPLACE ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o003" kind = "option_absent" required = true target = "[ OR REPLACE ]" -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o004" -kind = "option_present" -required = true -target = "[ IF NOT EXISTS ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o005" kind = "option_absent" @@ -181577,12 +181565,6 @@ required = true target = "" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o021" -kind = "option_present" -required = true -target = "[ GROUND_TRUTH = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o022" kind = "option_absent" @@ -181596,13 +181578,6 @@ required = true target = " in [ GROUND_TRUTH = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o024" -kind = "operand_type_class" -required = true -target = " in [ GROUND_TRUTH = ]" -note = "a valid operand" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o026" kind = "option_absent" @@ -181703,12 +181678,6 @@ required = true target = " in [ ACTUAL_SCORE_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o050" -kind = "option_present" -required = true -target = "[ COMMENT = '' ]" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o051" kind = "option_absent" @@ -181722,13 +181691,6 @@ required = true target = "'' in [ COMMENT = '' ]" note = "omit ''" -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o053" -kind = "operand_type_class" -required = true -target = "'' in [ COMMENT = '' ]" -note = "a valid string_literal" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o054" kind = "negative_neighbour" @@ -181802,12 +181764,6 @@ kind = "negative_neighbour" required = true note = "the form without its required AGGREGATION_WINDOW" -[[obligation]] -id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o066" -kind = "interaction_all_options" -required = true -note = "every independent option of one production together" - [[obligation]] id = "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o067" kind = "identifier_class" @@ -181959,6 +181915,61 @@ target = " in [ ACTUAL_SCORE_COLUMNS = Date: Thu, 12 Nov 2026 19:52:20 +0000 Subject: [PATCH 08/14] chore(syntax-coverage): pin the batch that records each model monitor gateway option --- coverage/syntax/baseline.json | 23 +++++++++++++++-------- evidence.toml | 4 ++-- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 3b0861492..1f59ddaeb 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -28972,9 +28972,7 @@ "sf.ddl.create-mcp-server.o014", "sf.ddl.create-mcp-server.o015", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o001", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o002", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o003", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o004", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o005", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o006", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o007", @@ -28991,10 +28989,8 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o018", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o019", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o020", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o021", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o022", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o023", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o024", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o026", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o027", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o029", @@ -29010,10 +29006,8 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o046", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o047", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o049", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o050", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o051", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o052", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o053", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o054", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o055", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o056", @@ -29025,7 +29019,6 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o063", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o064", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o065", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o066", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o067", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o068", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o069", @@ -29046,6 +29039,13 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o094", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o095", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o096", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o097", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o098", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o099", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o100", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o101", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o102", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o103", "sf.ddl.create-model-monitor.version-function-source-warehouse.o001", "sf.ddl.create-model-monitor.version-function-source-warehouse.o002", "sf.ddl.create-model-monitor.version-function-source-warehouse.o003", @@ -94326,14 +94326,18 @@ "sf.ddl.create-mcp-server.k842e2a8044bf", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k028e87d4cbe9", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k05d9bb9ff511", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k0e7bc1a568e5", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k177c889dcd0f", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k185ed580d270", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k1b5611fcf31c", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k1bab38f496cd", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k2119d97ade41", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k24a17c87d0d5", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k2716037856d0", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k2960c12468dc", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k322a2bba8a02", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k3c972000bd3d", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k3e609877acb4", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k40eaefe47128", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k5c6ea075b24d", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k621bd70c81fc", @@ -94347,14 +94351,16 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k8cf93e5865d8", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k9112177ece6e", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.k9bdec7cb988c", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka16d86f73517", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kab39c68889bf", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kac3d2b00c03f", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kbe1dee9e9f2c", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kce690e8c0713", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kd9b7107761ec", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ke1bb9c3bf411", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ke37ad49e0bdb", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ke3c6089261cf", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kecace24e1a91", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kf99a747d5c23", "sf.ddl.create-model-monitor.version-function-source-warehouse.k037b943d730f", "sf.ddl.create-model-monitor.version-function-source-warehouse.k0439cf2811d4", "sf.ddl.create-model-monitor.version-function-source-warehouse.k093eb664620f", @@ -149308,6 +149314,7 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka8c9b3516b7b", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ka9ef0f1507b7", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kb0e3b6e3f54b", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kce690e8c0713", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kde628a79a5e5", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kecd8d9cfa86a", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kfdfaa8815a0f", diff --git a/evidence.toml b/evidence.toml index 0e75f61d2..011f17830 100644 --- a/evidence.toml +++ b/evidence.toml @@ -1,4 +1,4 @@ # The evidence SQLQuack's checks read: one commit of the evidence repository, and the SHA-256 of its files. repository = "https://github.com/sqlstack-io/sqlquack-evidence.git" -commit = "b59884e0d6fa3583969c5c4ae4e197b34644beec" -content_sha256 = "411a906222eecbac33c9bee15f938d7e4d735ba82843bad0aab1ef800a8588ac" +commit = "3ad234d3d7625a69423c8d60bdb8bf87351488d7" +content_sha256 = "eb30449734f7594c2bd138969e5669fee873547f2485d28e97a668bb170ede3c" From 71b21064d273ac9a5b860a34e9b49af52984e2e6 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 20:06:04 +0000 Subject: [PATCH 09/14] chore(syntax-coverage): approve the model monitor gateway form --- coverage/syntax/baseline.json | 2 +- coverage/syntax/reviews/ddl.toml | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 1f59ddaeb..14730b80b 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -766,7 +766,7 @@ "sf.ddl.create-listing.from": "unverified", "sf.ddl.create-materialized-view": "unverified", "sf.ddl.create-mcp-server": "unverified", - "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval": "unverified", + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval": "verified", "sf.ddl.create-model-monitor.version-function-source-warehouse": "unverified", "sf.ddl.create-model.internalstage": "unverified", "sf.ddl.create-model.model": "verified", diff --git a/coverage/syntax/reviews/ddl.toml b/coverage/syntax/reviews/ddl.toml index a112fd806..ef7e01bff 100644 --- a/coverage/syntax/reviews/ddl.toml +++ b/coverage/syntax/reviews/ddl.toml @@ -1681,3 +1681,20 @@ note = "Re-approved after stage paths became stage references: of the 104 cases [review.definitions] "sf.ddl.alter-dbt-project.deploy-from" = "73cbec01605ca4f568c243c6a796e3c25420276f0f3ec53d37b0291f60fadf30" "sf.ddl.alter-listing.listing-add-version-from" = "d2b6b9d6850402fbf3cb027e387305cef8a9e1f08f883561b58bdf7cbca3d380" + +[[review]] +id = "ddl-025" +family = "ddl" +parser_tree = "582bdba8f75e43db2dfbf7d7ba7b39411f31a8fb" +reviewed_utc = "2026-11-12T20:05:43Z" +verdict = "approved" +forms = [ + "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval", +] +note = "Read in full against the documentation page, the obligations, the cases and the parse trees: each gateway option has its own case, the all-options case writes every column parameter as an array, and every scored case agrees with its Snowflake receipt." + +[review.fingerprints] +"sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" = "053e6f9e67ea0f33afe8bbbe0a0152f43f4b83c7ace622dd420c46f829e8d9be" + +[review.definitions] +"sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" = "ca8be0bcaceb82392bb0932369a9d9c902f272d168fbcec4fe0d432883a7a5c8" From 390f81a69869d2a65396cb4924df2615fc9488c7 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 20:17:24 +0000 Subject: [PATCH 10/14] chore(syntax-limits): split the model monitor version all-options case The version form's shared all-options case also wrote the column parameters as bare names. Each option it served now has its own case, and the all-options case writes all seven column parameters as arrays with distinct column names. --- coverage/syntax/limits.toml | 123 +++++++++++++++++++++++++++ coverage/syntax/obligations/ddl.toml | 99 +++++++++++---------- 2 files changed, 178 insertions(+), 44 deletions(-) diff --git a/coverage/syntax/limits.toml b/coverage/syntax/limits.toml index 963f3ceda..22c6e806a 100644 --- a/coverage/syntax/limits.toml +++ b/coverage/syntax/limits.toml @@ -84260,3 +84260,126 @@ sql = "CREATE OR REPLACE MODEL MONITOR IF NOT EXISTS v1 WITH MODEL = v1 GATEWAY context = "raw" expect = "accept" stage = "semantic" + +# The version model monitor's shared all-options case gives its *_COLUMNS bare names too, so the same split +# applies: each obligation it served gets its own case, and the all-options row writes seven distinct array columns. + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ OR REPLACE ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ OR REPLACE ]" +note = "OR REPLACE on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE OR REPLACE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ IF NOT EXISTS ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ IF NOT EXISTS ]" +note = "IF NOT EXISTS on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR IF NOT EXISTS v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ BASELINE = ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ BASELINE = ]" +note = "BASELINE on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 BASELINE = v1 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ BASELINE = ]" +note = "a valid identifier" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = " in [ BASELINE = ]" +note = "a table name as BASELINE" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 BASELINE = t2 ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ COMMENT = '' ]" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "option_present" +target = "[ COMMENT = '' ]" +note = "COMMENT on its own" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 COMMENT = 'm' ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = "'' in [ COMMENT = '' ]" +note = "a valid string_literal" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "operand_type_class" +target = "'' in [ COMMENT = '' ]" +note = "a string as COMMENT" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE MODEL MONITOR v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 COMMENT = 'c' ;" +context = "raw" +expect = "accept" +stage = "semantic" + +[[suppress]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "interaction_all_options" +note = "every independent option of one production together" +reason = "the shared all-options case gives *_COLUMNS bare names; the row below has its own case" + +[[limit]] +form = "sf.ddl.create-model-monitor.version-function-source-warehouse" +kind = "interaction_all_options" +note = "every option together, each *_COLUMNS value an array with its own column" +anchor = "doc.sql.create-model-monitor / Syntax / Model version monitor" +sql = "CREATE OR REPLACE MODEL MONITOR IF NOT EXISTS v1 WITH MODEL = v1 VERSION = 'm' FUNCTION = 'm' SOURCE = v1 WAREHOUSE = v1 REFRESH_INTERVAL = '1 minute' AGGREGATION_WINDOW = '1 days' TIMESTAMP_COLUMN = v1 BASELINE = v1 ID_COLUMNS = ( 'c1' ) PREDICTION_CLASS_COLUMNS = ( 'c2' ) PREDICTION_SCORE_COLUMNS = ( 'c3' ) ACTUAL_CLASS_COLUMNS = ( 'c4' ) ACTUAL_SCORE_COLUMNS = ( 'c5' ) SEGMENT_COLUMNS = ( 'c6' ) CUSTOM_METRIC_COLUMNS = ( 'c7' ) COMMENT = 'm' ;" +context = "raw" +expect = "accept" +stage = "semantic" diff --git a/coverage/syntax/obligations/ddl.toml b/coverage/syntax/obligations/ddl.toml index cfdf62b15..20cb1102c 100644 --- a/coverage/syntax/obligations/ddl.toml +++ b/coverage/syntax/obligations/ddl.toml @@ -181976,24 +181976,12 @@ kind = "positive" required = true note = "the documented form with every required part and no optional part" -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o002" -kind = "option_present" -required = true -target = "[ OR REPLACE ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o003" kind = "option_absent" required = true target = "[ OR REPLACE ]" -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o004" -kind = "option_present" -required = true -target = "[ IF NOT EXISTS ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o005" kind = "option_absent" @@ -182147,12 +182135,6 @@ required = true target = "" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o027" -kind = "option_present" -required = true -target = "[ BASELINE = ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o028" kind = "option_absent" @@ -182166,13 +182148,6 @@ required = true target = " in [ BASELINE = ]" note = "omit " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o030" -kind = "operand_type_class" -required = true -target = " in [ BASELINE = ]" -note = "a valid identifier" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o031" kind = "negative_neighbour" @@ -182320,12 +182295,6 @@ required = true target = " in [ CUSTOM_METRIC_COLUMNS = ]" note = "a string literal in place of " -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o067" -kind = "option_present" -required = true -target = "[ COMMENT = '' ]" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o068" kind = "option_absent" @@ -182339,13 +182308,6 @@ required = true target = "'' in [ COMMENT = '' ]" note = "omit ''" -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o070" -kind = "operand_type_class" -required = true -target = "'' in [ COMMENT = '' ]" -note = "a valid string_literal" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o071" kind = "negative_neighbour" @@ -182431,12 +182393,6 @@ kind = "negative_neighbour" required = true note = "the form without its required TIMESTAMP_COLUMN" -[[obligation]] -id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o085" -kind = "interaction_all_options" -required = true -note = "every independent option of one production together" - [[obligation]] id = "sf.ddl.create-model-monitor.version-function-source-warehouse.o086" kind = "identifier_class" @@ -182652,6 +182608,61 @@ target = " in [ CUSTOM_METRIC_COLUMNS = Date: Thu, 12 Nov 2026 20:35:18 +0000 Subject: [PATCH 11/14] chore(syntax-coverage): pin the batch that records the version model monitor form and a semantic view with DIMENSIONS before METRICS --- coverage/syntax/baseline.json | 53 ++++++++++++++++++++++++++----- coverage/syntax/marks/query.jsonl | 1 + evidence.toml | 4 +-- 3 files changed, 48 insertions(+), 10 deletions(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 14730b80b..eec5d76f0 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -29047,9 +29047,7 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o102", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.o103", "sf.ddl.create-model-monitor.version-function-source-warehouse.o001", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o002", "sf.ddl.create-model-monitor.version-function-source-warehouse.o003", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o004", "sf.ddl.create-model-monitor.version-function-source-warehouse.o005", "sf.ddl.create-model-monitor.version-function-source-warehouse.o006", "sf.ddl.create-model-monitor.version-function-source-warehouse.o007", @@ -29072,10 +29070,8 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.o024", "sf.ddl.create-model-monitor.version-function-source-warehouse.o025", "sf.ddl.create-model-monitor.version-function-source-warehouse.o026", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o027", "sf.ddl.create-model-monitor.version-function-source-warehouse.o028", "sf.ddl.create-model-monitor.version-function-source-warehouse.o029", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o030", "sf.ddl.create-model-monitor.version-function-source-warehouse.o031", "sf.ddl.create-model-monitor.version-function-source-warehouse.o033", "sf.ddl.create-model-monitor.version-function-source-warehouse.o034", @@ -29098,10 +29094,8 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.o063", "sf.ddl.create-model-monitor.version-function-source-warehouse.o064", "sf.ddl.create-model-monitor.version-function-source-warehouse.o066", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o067", "sf.ddl.create-model-monitor.version-function-source-warehouse.o068", "sf.ddl.create-model-monitor.version-function-source-warehouse.o069", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o070", "sf.ddl.create-model-monitor.version-function-source-warehouse.o071", "sf.ddl.create-model-monitor.version-function-source-warehouse.o072", "sf.ddl.create-model-monitor.version-function-source-warehouse.o073", @@ -29115,7 +29109,6 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.o082", "sf.ddl.create-model-monitor.version-function-source-warehouse.o083", "sf.ddl.create-model-monitor.version-function-source-warehouse.o084", - "sf.ddl.create-model-monitor.version-function-source-warehouse.o085", "sf.ddl.create-model-monitor.version-function-source-warehouse.o086", "sf.ddl.create-model-monitor.version-function-source-warehouse.o087", "sf.ddl.create-model-monitor.version-function-source-warehouse.o088", @@ -29130,6 +29123,27 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.o097", "sf.ddl.create-model-monitor.version-function-source-warehouse.o112", "sf.ddl.create-model-monitor.version-function-source-warehouse.o113", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o114", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o115", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o116", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o117", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o118", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o119", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o120", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o121", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o122", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o123", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o124", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o125", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o126", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o127", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o128", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o129", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o130", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o131", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o132", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o133", + "sf.ddl.create-model-monitor.version-function-source-warehouse.o134", "sf.ddl.create-model.internalstage.o006", "sf.ddl.create-model.internalstage.o008", "sf.ddl.create-model.internalstage.o011", @@ -62869,6 +62883,7 @@ "sf.query.semantic-view.o072", "sf.query.semantic-view.o073", "sf.query.semantic-view.o074", + "sf.query.semantic-view.o075", "sf.query.top-n.o001", "sf.query.top-n.o002", "sf.query.top-n.o003", @@ -94361,33 +94376,53 @@ "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.ke3c6089261cf", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kecace24e1a91", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval.kf99a747d5c23", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k0374fd50ae0f", "sf.ddl.create-model-monitor.version-function-source-warehouse.k037b943d730f", "sf.ddl.create-model-monitor.version-function-source-warehouse.k0439cf2811d4", "sf.ddl.create-model-monitor.version-function-source-warehouse.k093eb664620f", - "sf.ddl.create-model-monitor.version-function-source-warehouse.k1347648194c2", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k0bf09af797ad", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k0f7b58f65a56", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k130aa7504aaf", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k13a484aeaa23", "sf.ddl.create-model-monitor.version-function-source-warehouse.k18b1e8f99744", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k19161237b4ae", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k1c5f6eea2990", "sf.ddl.create-model-monitor.version-function-source-warehouse.k29687269a1b7", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k2a93a8a07b23", "sf.ddl.create-model-monitor.version-function-source-warehouse.k33769c65b52e", "sf.ddl.create-model-monitor.version-function-source-warehouse.k357b9a314f55", "sf.ddl.create-model-monitor.version-function-source-warehouse.k4976383771b4", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k49b07bdd210b", "sf.ddl.create-model-monitor.version-function-source-warehouse.k5e448de3125e", "sf.ddl.create-model-monitor.version-function-source-warehouse.k695e8326b2dc", "sf.ddl.create-model-monitor.version-function-source-warehouse.k6a7a0662a744", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k6be8cc9bbb55", "sf.ddl.create-model-monitor.version-function-source-warehouse.k6efa1d0fdb8c", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k739c8e469627", "sf.ddl.create-model-monitor.version-function-source-warehouse.k7502193fa1e0", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k7644d831392f", "sf.ddl.create-model-monitor.version-function-source-warehouse.k771f25933a29", "sf.ddl.create-model-monitor.version-function-source-warehouse.k783919376ef4", "sf.ddl.create-model-monitor.version-function-source-warehouse.k82c75caa01e7", "sf.ddl.create-model-monitor.version-function-source-warehouse.k8a025b5a9b90", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k8ffbc68141cc", "sf.ddl.create-model-monitor.version-function-source-warehouse.k911c213f6150", "sf.ddl.create-model-monitor.version-function-source-warehouse.k9d8de043bee4", "sf.ddl.create-model-monitor.version-function-source-warehouse.ka3c9db840acf", "sf.ddl.create-model-monitor.version-function-source-warehouse.kab9c23d2dd6d", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kbcf581014040", "sf.ddl.create-model-monitor.version-function-source-warehouse.kc1ede48d0b95", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kc2bba80b9209", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kc7942abb0968", "sf.ddl.create-model-monitor.version-function-source-warehouse.kd51a50e97c3c", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kd5e1452d4cd2", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kd68c744e2b6f", + "sf.ddl.create-model-monitor.version-function-source-warehouse.ke6399fd2e508", "sf.ddl.create-model-monitor.version-function-source-warehouse.kefccce311a72", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kf2ee896b73a2", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf4edc72bd8d0", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf5cd06438754", + "sf.ddl.create-model-monitor.version-function-source-warehouse.kf6603fc2af44", "sf.ddl.create-model-monitor.version-function-source-warehouse.kf749a23d10d5", "sf.ddl.create-model-monitor.version-function-source-warehouse.kfac141852901", "sf.ddl.create-model-monitor.version-function-source-warehouse.kfbaa79f6c2cc", @@ -105199,6 +105234,7 @@ "sf.query.semantic-view.k17ea8ce89fac", "sf.query.semantic-view.k180c098cec3b", "sf.query.semantic-view.k1e7f0904d652", + "sf.query.semantic-view.k346000861414", "sf.query.semantic-view.k3467caec5df3", "sf.query.semantic-view.k4c966fd037f2", "sf.query.semantic-view.k5b0972988065", @@ -149321,6 +149357,7 @@ "sf.ddl.create-model-monitor.version-function-source-warehouse.k0062b2ca7ea0", "sf.ddl.create-model-monitor.version-function-source-warehouse.k0e605874cdda", "sf.ddl.create-model-monitor.version-function-source-warehouse.k107eaf79a3a8", + "sf.ddl.create-model-monitor.version-function-source-warehouse.k1347648194c2", "sf.ddl.create-model-monitor.version-function-source-warehouse.k1b9483cc946c", "sf.ddl.create-model-monitor.version-function-source-warehouse.k22239af73d4e", "sf.ddl.create-model-monitor.version-function-source-warehouse.k2e92ec7bcc67", diff --git a/coverage/syntax/marks/query.jsonl b/coverage/syntax/marks/query.jsonl index b548816c9..0ce4f95dd 100644 --- a/coverage/syntax/marks/query.jsonl +++ b/coverage/syntax/marks/query.jsonl @@ -86,6 +86,7 @@ {"case_id":"sf.query.sample.k7b57243ee17b","mark":"settled accept","obligations":["sf.query.sample.o050"],"sql_sha256":"7b57243ee17bef25457594b5742691e5c2186a6a48cf231df7ae5745ebb4da1b"} {"case_id":"sf.query.select.select.k90fda657c545","mark":"settled reject","obligations":["sf.query.select.select.o098"],"sql_sha256":"90fda657c5451a18c6a5d0c8fbc8bf360f612358d0e7ea4c7aae409b98cea9fa"} {"case_id":"sf.query.select.select.selecting-specific-columns.k182d9ed5aea5","mark":"documented","obligations":["sf.query.select.select.selecting-specific-columns.o061"],"sql_sha256":"182d9ed5aea573db7b15e92e99d78fe045220e691be4605307d7c8db54bfaae1"} +{"case_id":"sf.query.semantic-view.k346000861414","mark":"settled accept","obligations":["sf.query.semantic-view.o075"],"sql_sha256":"346000861414ed3cb879d8a502a00988a10af48ad40937acc8a5395b8973bed6"} {"case_id":"sf.query.semantic-view.k4c966fd037f2","mark":"settled accept","obligations":["sf.query.semantic-view.o071"],"sql_sha256":"4c966fd037f2d0481d215872629620577c6d499e40da562c0da7c565a4bf166c"} {"case_id":"sf.query.values.ke10d44990b49","mark":"settled accept","obligations":["sf.query.values.o035"],"sql_sha256":"e10d44990b4909e7199ff9e71f0d7c88d7cef307b3d0883cb2156cf3cd37bc5b"} {"case_id":"sf.query.with.select.syntax.k0ec655314565","mark":"settled accept","obligations":["sf.query.with.select.syntax.o136","sf.query.with.select.syntax.o137"],"sql_sha256":"0ec6553145653a525e249f312eb890a4e07047422958b34457adc0f9d4c468ee"} diff --git a/evidence.toml b/evidence.toml index 011f17830..f760187a3 100644 --- a/evidence.toml +++ b/evidence.toml @@ -1,4 +1,4 @@ # The evidence SQLQuack's checks read: one commit of the evidence repository, and the SHA-256 of its files. repository = "https://github.com/sqlstack-io/sqlquack-evidence.git" -commit = "3ad234d3d7625a69423c8d60bdb8bf87351488d7" -content_sha256 = "eb30449734f7594c2bd138969e5669fee873547f2485d28e97a668bb170ede3c" +commit = "3e96beb9817650e0cdfc68128c8b6ad666e16b2a" +content_sha256 = "771ebf6516c8170923ea793e904ea659051ca23b352e32b3d46f2880f5ba8d6f" From ffaa00e6177e571075c5fed7a68024a801602a6c Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 20:56:53 +0000 Subject: [PATCH 12/14] fix(syntax): record a SEMANTIC_VIEW that writes DIMENSIONS before METRICS or FACTS Snowflake returns a semantic view's columns in the order its clauses are written, so DIMENSIONS before METRICS puts the dimensions first. The tree dropped that order. It now records dimensions_first, serialized only when true, so trees that write METRICS or FACTS first or DIMENSIONS alone are unchanged. --- coverage/syntax/baseline.json | 2 +- .../parser/_helpers/statements/sessions.rs | 4 ++++ .../tests/parser/test_faithful.rs | 24 +++++++++++++++++++ .../src/expressions/tables/models.rs | 3 +++ 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index eec5d76f0..c50a8b122 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -15,7 +15,7 @@ "catalogue/utility.toml": "55b30dcf06bf8182232a0da6b1da75462ae171e015cc8c9b8b95b36a722b44c5", "sources.toml": "a180c722616dfefc1568edf41938a0abf491f5a89f9609a1f666a50aa5aead94" }, - "parser_tree": "582bdba8f75e43db2dfbf7d7ba7b39411f31a8fb", + "parser_tree": "81b399ecb25a48845ecb5e900fae8aadbe7a4586", "forms": { "sf.classes.anomaly-detection.commands.create-anomaly-detection": "unverified", "sf.classes.anomaly-detection.commands.drop-anomaly-detection": "unverified", diff --git a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs index fabb5fb6c..24bcd8058 100644 --- a/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs +++ b/crates/sqlquack-syntax-snowflake/src/parser/_helpers/statements/sessions.rs @@ -1850,9 +1850,11 @@ impl Parser { let mut dimensions = None; let mut facts = None; let mut where_clause = None; + let mut dimensions_first = false; while !self.check(TokenType::RParen) && !self.is_at_end() { if self.match_identifier("METRICS") { + dimensions_first |= dimensions.is_some(); let exprs = self.parse_semantic_view_list()?; metrics = Some(Box::new(Expression::Tuple(Box::new(Tuple { expressions: exprs, @@ -1863,6 +1865,7 @@ impl Parser { expressions: exprs, })))); } else if self.match_identifier("FACTS") { + dimensions_first |= dimensions.is_some(); let exprs = self.parse_semantic_view_list()?; facts = Some(Box::new(Expression::Tuple(Box::new(Tuple { expressions: exprs, @@ -1884,6 +1887,7 @@ impl Parser { dimensions, facts, where_: where_clause, + dimensions_first, }))) } diff --git a/crates/sqlquack-syntax-snowflake/tests/parser/test_faithful.rs b/crates/sqlquack-syntax-snowflake/tests/parser/test_faithful.rs index 1715f2975..3bbe7606b 100644 --- a/crates/sqlquack-syntax-snowflake/tests/parser/test_faithful.rs +++ b/crates/sqlquack-syntax-snowflake/tests/parser/test_faithful.rs @@ -279,6 +279,30 @@ fn given_snowflake_derived_tables_join_aliases_and_semantic_views_when_parsing_t pointer: "/0/select/from/expressions/0/semantic_view/dimensions/tuple/expressions/0/alias/alias_explicit_as", expected_value: json!(false), }, + ProjectionTestCase { + description: "DIMENSIONS written before METRICS puts its columns first", + sql: "SELECT * FROM SEMANTIC_VIEW ( v1 DIMENSIONS 1 METRICS 1 ) ;", + pointer: "/0/select/from/expressions/0/semantic_view/dimensions_first", + expected_value: json!(true), + }, + ProjectionTestCase { + description: "DIMENSIONS written before FACTS puts its columns first", + sql: "SELECT * FROM SEMANTIC_VIEW ( v1 DIMENSIONS 1 FACTS 1 ) ;", + pointer: "/0/select/from/expressions/0/semantic_view/dimensions_first", + expected_value: json!(true), + }, + ProjectionTestCase { + description: "METRICS before DIMENSIONS records no order", + sql: "SELECT * FROM SEMANTIC_VIEW ( v1 METRICS 1 DIMENSIONS 1 ) ;", + pointer: "/0/select/from/expressions/0/semantic_view/dimensions_first", + expected_value: json!(null), + }, + ProjectionTestCase { + description: "DIMENSIONS alone records no order", + sql: "SELECT * FROM SEMANTIC_VIEW ( v1 DIMENSIONS 1 ) ;", + pointer: "/0/select/from/expressions/0/semantic_view/dimensions_first", + expected_value: json!(null), + }, ]; for test_case in test_cases { assert_eq!( diff --git a/crates/sqlquack-syntax/src/expressions/tables/models.rs b/crates/sqlquack-syntax/src/expressions/tables/models.rs index d078a923b..72e754386 100644 --- a/crates/sqlquack-syntax/src/expressions/tables/models.rs +++ b/crates/sqlquack-syntax/src/expressions/tables/models.rs @@ -1151,6 +1151,9 @@ pub struct SemanticView { pub facts: Option>, #[serde(default)] pub where_: Option>, + /// DIMENSIONS was written before METRICS or FACTS, so its columns come first in the result + #[serde(default, skip_serializing_if = "std::ops::Not::not")] + pub dimensions_first: bool, } /// SerdeProperties From 0ebb1ce6a4e64c2f3a2ea08233158513d20ef910 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 21:04:08 +0000 Subject: [PATCH 13/14] chore(syntax-coverage): approve the model monitor version form --- coverage/syntax/baseline.json | 2 +- coverage/syntax/reviews/ddl.toml | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index c50a8b122..4faa141ef 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -767,7 +767,7 @@ "sf.ddl.create-materialized-view": "unverified", "sf.ddl.create-mcp-server": "unverified", "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval": "verified", - "sf.ddl.create-model-monitor.version-function-source-warehouse": "unverified", + "sf.ddl.create-model-monitor.version-function-source-warehouse": "verified", "sf.ddl.create-model.internalstage": "unverified", "sf.ddl.create-model.model": "verified", "sf.ddl.create-notebook": "unverified", diff --git a/coverage/syntax/reviews/ddl.toml b/coverage/syntax/reviews/ddl.toml index ef7e01bff..41c75d934 100644 --- a/coverage/syntax/reviews/ddl.toml +++ b/coverage/syntax/reviews/ddl.toml @@ -1698,3 +1698,20 @@ note = "Read in full against the documentation page, the obligations, the cases [review.definitions] "sf.ddl.create-model-monitor.gateway-function-warehouse-refresh-interval" = "ca8be0bcaceb82392bb0932369a9d9c902f272d168fbcec4fe0d432883a7a5c8" + +[[review]] +id = "ddl-026" +family = "ddl" +parser_tree = "81b399ecb25a48845ecb5e900fae8aadbe7a4586" +reviewed_utc = "2026-11-12T21:03:38Z" +verdict = "approved" +forms = [ + "sf.ddl.create-model-monitor.version-function-source-warehouse", +] +note = "Read in full against the documentation page, the obligations, the cases and the parse trees: each *_COLUMNS value is a string array, each option has its own case, the all-options case writes seven distinct array columns, and every scored case agrees with its Snowflake receipt." + +[review.fingerprints] +"sf.ddl.create-model-monitor.version-function-source-warehouse" = "728709e9d438497d9e80811e94db886c234a6da573777ddae79c9087af13d501" + +[review.definitions] +"sf.ddl.create-model-monitor.version-function-source-warehouse" = "a938b44c8bef2928a7d20609cc36a9899926f277db78a878ae86051c68820231" From 20046ba9db061c8f71f6f2fb2d07bcfa9b7689de Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 12 Nov 2026 21:04:51 +0000 Subject: [PATCH 14/14] chore(syntax-coverage): approve the semantic view query form --- coverage/syntax/baseline.json | 2 +- coverage/syntax/reviews/query.toml | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/coverage/syntax/baseline.json b/coverage/syntax/baseline.json index 4faa141ef..df1ee8b17 100644 --- a/coverage/syntax/baseline.json +++ b/coverage/syntax/baseline.json @@ -2759,7 +2759,7 @@ "sf.query.select.select-ilike-replace-rename": "absent", "sf.query.select.select-replace-rename": "absent", "sf.query.select.select.selecting-specific-columns": "unverified", - "sf.query.semantic-view": "unverified", + "sf.query.semantic-view": "verified", "sf.query.top-n": "verified", "sf.query.unpivot": "verified", "sf.query.values": "verified", diff --git a/coverage/syntax/reviews/query.toml b/coverage/syntax/reviews/query.toml index 51e3b60d9..b619d2913 100644 --- a/coverage/syntax/reviews/query.toml +++ b/coverage/syntax/reviews/query.toml @@ -297,3 +297,20 @@ note = "Read in full against the documentation page, the obligations, the cases [review.definitions] "sf.query.join.join" = "20ab01abd8faed881505d69e9f88c21692e6fd9a316d54149aca51af293a5d5a" + +[[review]] +id = "query-014" +family = "query" +parser_tree = "81b399ecb25a48845ecb5e900fae8aadbe7a4586" +reviewed_utc = "2026-11-12T21:04:37Z" +verdict = "approved" +forms = [ + "sf.query.semantic-view", +] +note = "Read in full against the documentation page, the obligations, the cases and the parse trees: the tree records DIMENSIONS written before METRICS or FACTS, and every scored case agrees with its Snowflake receipt." + +[review.fingerprints] +"sf.query.semantic-view" = "e2ab3dcbddedea90edf28c01588725c609aec368dd1fada83b16fc4995cdf649" + +[review.definitions] +"sf.query.semantic-view" = "51e38825d66dc6d03fa84a9abdbef01a8ea7cfd310178f078f25ef5bd2a42c14"