Skip to content

Commit fefd36a

Browse files
committed
audit: PR #142 delta at 62b33fb and the typed-literal neighbours at c127071
1 parent be6310c commit fefd36a

2 files changed

Lines changed: 71 additions & 0 deletions

File tree

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
[review]
2+
schema = "sqlquack.recorder-change-review.v1"
3+
decision = "D118"
4+
related = ["D133"]
5+
branch = "wip/typed-literal-neighbours"
6+
commit = "c1270713891a178d9b34e0a8d1accac8a350a4b9"
7+
base = "62b33fb98deb6b4d085d96bd86aa02cc7e49a69a"
8+
merge_base = "62b33fb98deb6b4d085d96bd86aa02cc7e49a69a"
9+
receipts = ["3d67a2c9 import-20261104-175 (7 receipts)"]
10+
review_entry = "wip/typed-literal-neighbours-auditor-review 2a16fed3 (auditor-expressions-017)"
11+
reviewed_at = "2026-11-07T13:50:48Z"
12+
round = 1
13+
verdict = "approved"
14+
checked = [
15+
"c1270713 is be9a4250 (limits to obligations o018-o024), 3d67a2c9 (import 175), 303ff0fc (parser) and three merges: c8e53e4e (a21da4d6), 48b2b502 (import 175) and c1270713 (62b33fb9). Each merge equals git merge-tree of its parents. Nothing is deleted.",
16+
"Import 175 (run tlnb-ex-00) has 7 receipts, all semantic_error 2121/42601. The 7 cases move to accept, stage semantic: TIMESTAMP_LTZ(3) o018, TIMESTAMPNTZ(3) o019, TIMESTAMPLTZ(3) o020, TIMESTAMPTZ(3) o021, DATETIME(3) o022, TIMESTAMP(3) o023 and TIME(3) o024, each before a string.",
17+
"303ff0fc: try_parse_snowflake_parameterized_literal runs only under applies_snowflake_context_rules and only when ( follows the TIME, TIMESTAMP or DATETIME keyword. It reuses the named-type-literal reader, which needs non-empty balanced parameters directly followed by a string and otherwise returns none without moving. TIMESTAMP and TIME are added to the rejection lookup with TO_TIMESTAMP and TO_TIME. The SQ0211 text is updated and reference.mdx regenerated.",
18+
"Built c1270713 and probed check and convert. SQ0211 for TIME(3) '…', time (3) '…', TIMESTAMP(3) and TIMESTAMP(9) '…', DATETIME(3) '…', TIMESTAMP_LTZ(3) '…' and TIMESTAMPTZ(3) '…'. Not refused: TIME '…', TIMESTAMP '…', CAST(… AS TIME(3)), '…'::TIMESTAMP(3), TIME('03:04:05'), TIME(s), WHERE TIME(s) = '…', bare TIME(3) and DATETIME(3), and CREATE TABLE … (c TIME(3) DEFAULT '00:00:00', d TIMESTAMP(3) DEFAULT '…'), whose type parameters are not read as literals.",
19+
"syntax-coverage at c1270713 (parser tree 0d2197f7): the only stale form is date-time-constant (definition 16b01a23, fingerprint d0ed46f0), and diff shows 16 gained, 1 form lost (that one) and 5128 contradicted. With auditor-expressions-017 added (2a16fed3, on top of c1270713), validate passes, stale is empty, the form is Verified 23/23, and diff shows 16 gained (o009-o024), no form lost and 5128 contradicted.",
20+
"Did not run polyglot test_exact, clippy or the full gate. The lane ran polyglot (pass, 367 s) and clippy on this head.",
21+
]
22+
23+
[[review.finding]]
24+
kind = "awaiting_receipts"
25+
blocking = false
26+
detail = "TIMESTAMP(3) WITH TIME ZONE '…' still converts (to CAST(… AS TIMESTAMPTZ)). By analogy with the recorded TIMESTAMP_TZ(3) and TIMESTAMPTZ(3) cases (2121), Snowflake probably rejects it, but no receipt shows that. Add it, with TIMESTAMP WITH TIME ZONE '…' and TIME(3) WITH TIME ZONE … if Snowflake has that spelling, as observed neighbours."
27+
28+
[[review.finding]]
29+
kind = "sequencing"
30+
blocking = false
31+
detail = "The branch needs 2a16fed3's review entry, by merge or fast-forward, before it lands. Otherwise date-time-constant is stale and diff reports it as a lost form."
32+
33+
[review.files_sha256]
34+
"crates/sqlquack-syntax/src/parser/_helpers/types/data_types.rs" = "6d7f4dd8bbebf71150418d4cb3a37dfc9577c22b0b5d73f1a7021d0195d4e601"
35+
"crates/sqlquack-syntax/src/parser/_helpers/expressions/primary.rs" = "120fa3d7dac2c9657befbf02f117b464fff69bd682cdb1732d8bd722b1101d11"
36+
"crates/sqlquack-syntax/src/expressions/types/constants.rs" = "f6a0fae622ab5daeac87a48638dc9acf90d5ca7bc38a6ab4b632979f4cf6a788"
37+
"crates/sqlquack-core/src/refusals/_helpers/rejections.rs" = "8f631e2cb199e67ab5d22ddc146cc290d2818a458979cd20532fe0f280fb06a1"
38+
"coverage/syntax/cases/expressions.jsonl" = "6a849c761069f12283a935a77e9435f3015cede080f19c453d511b982ec22005"
39+
"coverage/syntax/obligations/expressions.toml" = "26c7a6514d33c82e9677710de15653b463b42a39362d940d2c5b53f2e76e090d"
40+
"coverage/syntax/receipts/import-20261104-175.jsonl" = "aecc53f282b1e74f4ec8fc5bd489ea0fc54ebd9e717e28e356f35616730d83e4"
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
[review]
2+
schema = "sqlquack.recorder-change-review.v1"
3+
decision = "D118"
4+
pull_request = 142
5+
branch = "fix/typed-timestamp-literals"
6+
commit = "62b33fb98deb6b4d085d96bd86aa02cc7e49a69a"
7+
base = "615a5c2a2037b2d92c0c65a295d8ac342efabfbf"
8+
merge_base = "c2cbe9d247d9a1fe5e3b6ff01ed272a2b35fc01d"
9+
previous_review = "7b31b03705d3ef60102e7f1acae4cca810b91fa4"
10+
reviewed_at = "2026-11-07T13:50:48Z"
11+
round = 2
12+
verdict = "approved"
13+
checked = [
14+
"62b33fb9 is 615a5c2a plus a21da4d6 and 62b33fb9, both with the configured no-reply identity. Nothing is deleted.",
15+
"a21da4d6: Cast gains typed_literal, serde- and ast-skipped. It is set to true only in try_parse_snowflake_named_type_literal, which runs only under applies_snowflake_context_rules, and false at every other construction, including Cast::new and the Postgres crate. untyped_literal in rejections.rs now requires it in place of !double_colon_syntax. Cast::new replaces four field-by-field constructions in generic.rs with the same field values.",
16+
"62b33fb9: parse_primary_datetime_literal's DATETIME before a string refusal is gated by applies_snowflake_context_rules() in place of is_snowflake(), the same gate as #144's COPY check.",
17+
"Built 62b33fb9. CAST(… AS DATETIME(3)) and CAST(… AS TIMESTAMPNTZ(3)) convert. CAST(… AS TIMESTAMP_LTZ(3)) and TRY_CAST(… AS TIMESTAMPLTZ(3)) check clean and convert under sqlquack.toml with --utc-session, and stop at SQ0008 (the zone divergence) under the built-in policy, not SQ0211. '…'::TIMESTAMP_NTZ(3), TIMESTAMP '…' and DATE '…' convert. TIMESTAMP_NTZ(3) '…' gives SQ0211, and TIMESTAMP_NTZ '…', DATETIME '…' and DATE(DATETIME '…') give SQ0001.",
18+
"syntax-coverage at 62b33fb9 (parser tree eb614c32): stale is empty (auditor-expressions-016 covers date-time-constant). diff coverage/syntax/baseline.json gains o009-o017 with no form or obligation lost and 5128 contradicted. That is main's count at eaf17f69, so the delta adds no contradiction. The 32ba12e8 record did not note a contradicted count to compare with.",
19+
"Did not run polyglot test_exact, clippy, the CLI suite or verify. The lane ran polyglot (pass) and clippy on the follow-up head, which contains these commits.",
20+
]
21+
22+
[[review.finding]]
23+
kind = "resolved"
24+
blocking = false
25+
detail = "Casts to DATETIME(n), TIMESTAMPNTZ(n), TIMESTAMP_LTZ(n) and TIMESTAMPLTZ(n), refused with SQ0211 at 615a5c2a although main converts them, are no longer refused. The DATETIME refusal no longer runs in polyglot exact modes."
26+
27+
[review.files_sha256]
28+
"crates/sqlquack-syntax/src/expressions/operators/models.rs" = "435bc56a98abee349085fedb08ac03641d4c2861dc6155eb6b5353257e53c4ae"
29+
"crates/sqlquack-syntax/src/parser/_helpers/types/data_types.rs" = "92d67e019886f09a1de18e0fe3d4f99c1529aacdda87b2218f431c152f18a6f4"
30+
"crates/sqlquack-syntax/src/parser/_helpers/expressions/primary.rs" = "b1ba481c0efeca801d79e1cff6edbf037f0f03413bf8a2d13e4dc780aaf78f18"
31+
"crates/sqlquack-core/src/refusals/_helpers/rejections.rs" = "da348fb6e6e4a963ff623b45b7bdc149d40d8f9f3608477e9a06ccdcef104d7e"

0 commit comments

Comments
 (0)