Skip to content

Commit 39335aa

Browse files
committed
chore(syntax-coverage): judge Snowflake refusals by the receipt's recorded phase
The importer decides each receipt's phase, placing an error as a syntax error only on evidence such as errno 1003 under the compilation prefix or a 1002 whose message starts with "syntax error". The checker kept its own list, errno 1003 or 921, so a syntax-phase receipt with any other errno counted as neither parsed nor refused, and the two could drift. The checker now treats every receipt the importer placed as a syntax error as Snowflake's refusal, whatever its errno. A 1003 at another phase still counts as neither. Two receipts the parser contradicts are new: ALTER WAREHOUSE ADD TABLES and DROP TABLES, refused with 1002 and accepted by the parser, now on the Snowflake disagreement list. Sixteen syntax-phase receipts with errno 1002, 4, 92107 or 510807 now count as refusals the parser agrees with. Satisfied obligations and verified forms are unchanged.
1 parent 5dad590 commit 39335aa

7 files changed

Lines changed: 38 additions & 14 deletions

File tree

‎coverage/syntax/baseline.json‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115222,6 +115222,7 @@
115222115222
"sf.ddl.alter-model-modify-version.k4046cb02685f",
115223115223
"sf.ddl.alter-model-modify-version.k7c4ad08fc3c6",
115224115224
"sf.ddl.alter-model-modify-version.k99da9e673c5a",
115225+
"sf.ddl.alter-model-modify-version.ka045b23e0a15",
115225115226
"sf.ddl.alter-model-modify-version.kbb3fcd9f4c54",
115226115227
"sf.ddl.alter-model-modify-version.kc2c7675340e7",
115227115228
"sf.ddl.alter-model-modify-version.kdc359eede618",
@@ -115311,6 +115312,7 @@
115311115312
"sf.ddl.alter-model.version-set-alias.k003c58b74340",
115312115313
"sf.ddl.alter-model.version-set-alias.k0d3c9427d721",
115313115314
"sf.ddl.alter-model.version-set-alias.k1679423bbe76",
115315+
"sf.ddl.alter-model.version-set-alias.k496721a8f35f",
115314115316
"sf.ddl.alter-model.version-set-alias.k6903deb51055",
115315115317
"sf.ddl.alter-model.version-set-alias.k6b1c1af81ad3",
115316115318
"sf.ddl.alter-model.version-set-alias.k6e59b5551d4e",
@@ -124217,6 +124219,7 @@
124217124219
"sf.ddl.create-table.create-table-from-archive.k0c7beac766b4",
124218124220
"sf.ddl.create-table.create-table-from-archive.k2853343b5796",
124219124221
"sf.ddl.create-table.create-table-from-archive.k2f194a1d0ad5",
124222+
"sf.ddl.create-table.create-table-from-archive.k3beac591b849",
124220124223
"sf.ddl.create-table.create-table-from-archive.k47232bd28cd9",
124221124224
"sf.ddl.create-table.create-table-from-archive.k68a5c6c807ef",
124222124225
"sf.ddl.create-table.create-table-from-archive.k6afa591234d2",
@@ -126535,18 +126538,24 @@
126535126538
"sf.ddl.show-sequences.ke3e7e2abbd43",
126536126539
"sf.ddl.show-sequences.ke9fae52677ae",
126537126540
"sf.ddl.show-sequences.kf24a55d6c1f7",
126541+
"sf.ddl.show-service-containers-in-service.k0b3208246c0f",
126542+
"sf.ddl.show-service-containers-in-service.k0d7585bbc9e6",
126538126543
"sf.ddl.show-service-containers-in-service.k5405f2ea85a1",
126539126544
"sf.ddl.show-service-containers-in-service.k94f5e0882830",
126540126545
"sf.ddl.show-service-containers-in-service.kb4804fab5adf",
126541126546
"sf.ddl.show-service-containers-in-service.kce919ad39bee",
126542126547
"sf.ddl.show-service-containers-in-service.kd98f9ed0378b",
126548+
"sf.ddl.show-service-instances-in-service.k281832eec14a",
126543126549
"sf.ddl.show-service-instances-in-service.k2f5fe5c7afb3",
126550+
"sf.ddl.show-service-instances-in-service.k406e9c60d81c",
126544126551
"sf.ddl.show-service-instances-in-service.kae842ee2db47",
126545126552
"sf.ddl.show-service-instances-in-service.ke8abaf8fe2c4",
126546126553
"sf.ddl.show-service-instances-in-service.kf01905e18db2",
126547126554
"sf.ddl.show-service-volumes-in-service.k00ec6ef0c83e",
126555+
"sf.ddl.show-service-volumes-in-service.k8bcbcc06f002",
126548126556
"sf.ddl.show-service-volumes-in-service.kb17f8e56d240",
126549126557
"sf.ddl.show-service-volumes-in-service.kb6cc208b2fd0",
126558+
"sf.ddl.show-service-volumes-in-service.kce1bcd7dfd8b",
126550126559
"sf.ddl.show-services.k06ce1e64aef7",
126551126560
"sf.ddl.show-services.k11babac015e9",
126552126561
"sf.ddl.show-services.k14bc89214563",
@@ -127537,12 +127546,14 @@
127537127546
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k0e50425068e0",
127538127547
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k172845559319",
127539127548
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k1e6f2252ccaf",
127549+
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k2d3bcf6abdad",
127540127550
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k3fa1e29153cb",
127541127551
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k412daa3e1871",
127542127552
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k615f32f12f48",
127543127553
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k796c1927ae0f",
127544127554
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k80bd5c6cb355",
127545127555
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k895ddd619e4e",
127556+
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k8cfc52258f82",
127546127557
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k92735d490bc7",
127547127558
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k94a43ebac13d",
127548127559
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.k99add337eec0",
@@ -127553,6 +127564,7 @@
127553127564
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kc0f8fba35602",
127554127565
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kc1536449cb1d",
127555127566
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kc7916590f304",
127567+
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kc7ae19b55dde",
127556127568
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kc8224f65e773",
127557127569
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kcb37ef473740",
127558127570
"sf.expressions.data-types-datetime.interval-yearmonthqualifier-daytimequalifier.kce879de7e2d1",
@@ -141274,6 +141286,7 @@
141274141286
"sf.security_admin.show-listings-in-failover-group.k6bedcbb1db75",
141275141287
"sf.security_admin.show-listings-in-failover-group.k920c116e34c0",
141276141288
"sf.security_admin.show-listings-in-failover-group.kdd6b870ef2d8",
141289+
"sf.security_admin.show-listings-in-failover-group.ke43760e6b747",
141277141290
"sf.security_admin.show-maintenance-policies.k043d03185a67",
141278141291
"sf.security_admin.show-maintenance-policies.k193df6c29723",
141279141292
"sf.security_admin.show-maintenance-policies.k35959c6e458b",
@@ -141364,6 +141377,7 @@
141364141377
"sf.security_admin.show-organization-accounts.k4bd4c2912104",
141365141378
"sf.security_admin.show-organization-accounts.kdee12ffd6075",
141366141379
"sf.security_admin.show-organization-contracts.kbbbea1f84589",
141380+
"sf.security_admin.show-organization-profiles.k829f1501cc89",
141367141381
"sf.security_admin.show-organization-user-groups.k1d188d272746",
141368141382
"sf.security_admin.show-organization-user-groups.k33c42f293a58",
141369141383
"sf.security_admin.show-organization-user-groups.kfdebdd83ce24",
@@ -142209,6 +142223,8 @@
142209142223
"sf.utility.execute-dcm-project.test-all.kb469bb623288",
142210142224
"sf.utility.execute-dcm-project.test-all.kf6ef66b31604",
142211142225
"sf.utility.execute-immediate-from.kdcaf1575b582",
142226+
"sf.utility.execute-immediate.immediate-2.k81fd79784b4a",
142227+
"sf.utility.execute-immediate.immediate.kbcd9a6dfb1fd",
142212142228
"sf.utility.execute-immediate.immediate.syntax.kdb533353cc4a",
142213142229
"sf.utility.execute-inference-job-service.k034cc7ef7e72",
142214142230
"sf.utility.execute-inference-job-service.k0380a4777088",
@@ -143040,6 +143056,7 @@
143040143056
"sf.ddl.alter-warehouse.add-tables.k03a3c4082fff",
143041143057
"sf.ddl.alter-warehouse.add-tables.k0add3b7ab01d",
143042143058
"sf.ddl.alter-warehouse.add-tables.k0d8380a5561d",
143059+
"sf.ddl.alter-warehouse.add-tables.k22a4a06e0b15",
143043143060
"sf.ddl.alter-warehouse.add-tables.k42168bc94c03",
143044143061
"sf.ddl.alter-warehouse.add-tables.k4fbb9449c1ee",
143045143062
"sf.ddl.alter-warehouse.add-tables.k82c79cc80548",
@@ -143048,6 +143065,7 @@
143048143065
"sf.ddl.alter-warehouse.add-tables.kd23873c7924c",
143049143066
"sf.ddl.alter-warehouse.add-tables.kf94a691897f9",
143050143067
"sf.ddl.alter-warehouse.drop-tables.k0467ae54bde3",
143068+
"sf.ddl.alter-warehouse.drop-tables.k18cd7b807795",
143051143069
"sf.ddl.alter-warehouse.drop-tables.k6b1cdba72b9f",
143052143070
"sf.ddl.alter-warehouse.drop-tables.k75b39332a334",
143053143071
"sf.ddl.alter-warehouse.drop-tables.k83d39159180e",
@@ -146331,6 +146349,7 @@
146331146349
"sf.ddl.alter-warehouse.add-tables.k03a3c4082fff",
146332146350
"sf.ddl.alter-warehouse.add-tables.k0add3b7ab01d",
146333146351
"sf.ddl.alter-warehouse.add-tables.k0d8380a5561d",
146352+
"sf.ddl.alter-warehouse.add-tables.k22a4a06e0b15",
146334146353
"sf.ddl.alter-warehouse.add-tables.k42168bc94c03",
146335146354
"sf.ddl.alter-warehouse.add-tables.k4fbb9449c1ee",
146336146355
"sf.ddl.alter-warehouse.add-tables.k82c79cc80548",
@@ -146339,6 +146358,7 @@
146339146358
"sf.ddl.alter-warehouse.add-tables.kd23873c7924c",
146340146359
"sf.ddl.alter-warehouse.add-tables.kf94a691897f9",
146341146360
"sf.ddl.alter-warehouse.drop-tables.k0467ae54bde3",
146361+
"sf.ddl.alter-warehouse.drop-tables.k18cd7b807795",
146342146362
"sf.ddl.alter-warehouse.drop-tables.k6b1cdba72b9f",
146343146363
"sf.ddl.alter-warehouse.drop-tables.k75b39332a334",
146344146364
"sf.ddl.alter-warehouse.drop-tables.k83d39159180e",

‎coverage/syntax/receipt-disagreements.toml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1186,6 +1186,7 @@ other_receipts_contradicted = [
11861186
"k03a3c4082fff",
11871187
"k0add3b7ab01d",
11881188
"k0d8380a5561d",
1189+
"k22a4a06e0b15",
11891190
"k42168bc94c03",
11901191
"k4fbb9449c1ee",
11911192
"k82c79cc80548",
@@ -1196,6 +1197,7 @@ other_receipts_contradicted = [
11961197
]
11971198
"sf.ddl.alter-warehouse.drop-tables" = [
11981199
"k0467ae54bde3",
1200+
"k18cd7b807795",
11991201
"k6b1cdba72b9f",
12001202
"k75b39332a334",
12011203
"k83d39159180e",

‎docs/syntax-coverage.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,8 +423,9 @@ obligation that no longer is, or a receipted case Snowflake parsed that the base
423423
and the current one rejects, or a case Snowflake refused as syntax that the base parser rejected
424424
and the current one accepts. Both join each case to its receipts by SQL, setup and session hashes,
425425
whatever the case expects: Snowflake parsed a case when every receipt has a non-syntax phase and an
426-
errno other than 1003, and refused it when every receipt is a syntax error with errno 1003 or 921;
427-
a positionless 1003 or receipts that disagree count as neither. The first line catches a case that
426+
errno other than 1003, and refused it when the importer recorded every receipt's phase as a
427+
syntax error, whatever its errno; a 1003 at another phase or receipts that disagree count as
428+
neither. The first line catches a case that
428429
moves from an opaque acceptance, which satisfies no obligation, to a rejection; a pull request that
429430
has one explains each case; a case marked `documented` is listed on its own line, and fails all the
430431
same. A snapshot taken before these case lists existed has none, so it reports no such case. The

‎tools/sqlquack-coverage-check/src/check/_helpers/receipts.rs‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
use std::collections::{BTreeMap, BTreeSet};
44

55
use crate::check::models::{CaseResult, LocalVerdict, Reason, SnowflakeSyntax};
6-
use crate::formats::constants::{SYNTAX_ERRNO, SYNTAX_ERRNO_42601};
6+
use crate::formats::constants::SYNTAX_ERRNO;
77
use crate::formats::main::current_dialect::current_dialect;
88
use crate::formats::models::{AccountSetting, Case, Expect, Phase, Receipt};
99

@@ -64,19 +64,14 @@ fn agreement(phase: Phase, local: &LocalVerdict, terminates: bool) -> Result<boo
6464
}
6565
}
6666

67-
/// What Snowflake's parser did by the syntax receipts of the case's statement; none unless all agree.
67+
/// What Snowflake's parser did by the phases the importer recorded for the case's statement; none unless all agree.
6868
pub(crate) fn snowflake_syntax(statement_receipts: &[&Receipt]) -> Option<SnowflakeSyntax> {
6969
let verdicts: BTreeSet<Option<SnowflakeSyntax>> = statement_receipts
7070
.iter()
7171
.filter(|receipt| receipt.measure.is_none())
7272
.map(|receipt| match (receipt.phase, receipt.errno) {
7373
_ if receipt.is_engine() => engine_syntax(receipt),
74-
(Phase::SyntaxError, Some(errno))
75-
if errno == SYNTAX_ERRNO || errno == SYNTAX_ERRNO_42601 =>
76-
{
77-
Some(SnowflakeSyntax::Refused)
78-
}
79-
(Phase::SyntaxError, _) => None,
74+
(Phase::SyntaxError, _) => Some(SnowflakeSyntax::Refused),
8075
(_, Some(errno)) if errno == SYNTAX_ERRNO => None,
8176
_ => Some(SnowflakeSyntax::Parsed),
8277
})

‎tools/sqlquack-coverage-check/src/check/models.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ pub enum Reason {
8484
pub enum SnowflakeSyntax {
8585
/// Every receipt stopped after parsing or succeeded, with an errno other than 1003.
8686
Parsed,
87-
/// Every receipt is a syntax error: errno 1003 with a parse position, or errno 921.
87+
/// Every receipt's recorded phase is a syntax error, whatever its errno.
8888
Refused,
8989
}
9090

‎tools/sqlquack-coverage-check/src/formats/constants.rs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,3 @@ pub const DCM_POSITION: &str = " at position ";
123123

124124
/// Snowflake's errno for a syntax error; with a parse position it is a refusal by the parser.
125125
pub const SYNTAX_ERRNO: i64 = 1003;
126-
127-
/// Snowflake's errno 921, SQLSTATE 42601, reviewed as a syntax refusal.
128-
pub const SYNTAX_ERRNO_42601: i64 = 921;

‎tools/sqlquack-coverage-check/src/report/tests/test_parser_changes.rs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,15 @@ fn given_receipted_cases_of_any_expectation_when_the_parser_changes_then_the_dif
6161
expected_syntax_error_cases_accepted: vec!["select-from"],
6262
expected_documented_cases_accepted: Vec::new(),
6363
},
64+
ParserChangeTestCase {
65+
description: "an observe case the importer placed as a syntax error with 1002, now accepted",
66+
mutate: |root| observed_select_from(root, 1002),
67+
base: structural,
68+
head: opaque,
69+
expected_parsed_cases_refused: Vec::new(),
70+
expected_syntax_error_cases_accepted: vec!["select-from"],
71+
expected_documented_cases_accepted: Vec::new(),
72+
},
6473
ParserChangeTestCase {
6574
description: "a case marked documented, refused with 1003 and now accepted, is listed apart",
6675
mutate: |root| {

0 commit comments

Comments
 (0)