Skip to content

Commit f79eac9

Browse files
committed
test(rules): expect built-in model rules to parse calls as deep as the compiler
The built-in model rules' query facts now share the compiler's 256 function-call depth, so SQL nested 130 calls deep, once beyond their 128 budget, is evaluated. The unevaluated-resource case for SQBRMODEL101 becomes a case that the rule evaluates it; SQLClean rules keep their own budget and their unevaluated cases stay.
1 parent 3c8e750 commit f79eac9

2 files changed

Lines changed: 44 additions & 8 deletions

File tree

‎tests/e2e/src/sqlbuild/cli/commands/main/rules/_test_types.py‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,15 @@ class SnowflakeBodyShapeCase:
4747
expected_format_exit: int = 0
4848

4949

50+
@dataclass(frozen=True)
51+
class SharedDepthModelRuleCase:
52+
description: str
53+
template: str
54+
rule: str
55+
expected_evaluated_models: int
56+
expected_unevaluated_resources: int
57+
58+
5059
@dataclass(frozen=True)
5160
class UnevaluatedResourceCase:
5261
description: str

‎tests/e2e/src/sqlbuild/cli/commands/main/rules/test_unevaluated.py‎

Lines changed: 35 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
EvaluatedModelRulesCase,
1212
EvaluatedPredicateCase,
1313
GroupedRulesCase,
14+
SharedDepthModelRuleCase,
1415
SnowflakeBodyShapeCase,
1516
UnevaluatedResourceCase,
1617
UnevaluatedRuleCase,
@@ -48,14 +49,6 @@
4849
),
4950
),
5051
),
51-
UnevaluatedResourceCase(
52-
"built-in model rule beyond the parser budget",
53-
"models/staging/orders.sql",
54-
"MODEL (description 'Test model orders.');\nSELECT {expression} AS order_id",
55-
expected_evaluated_models=0,
56-
expected_reason="could not parse models/staging/orders.sql for rules",
57-
rule="SQBRMODEL101",
58-
),
5952
UnevaluatedResourceCase(
6053
"SQL-test guard",
6154
"tests/unit/test_orders.sql",
@@ -109,6 +102,40 @@ def test_given_guarded_resource_when_running_rules_then_reports_failure_and_cove
109102
)
110103

111104

105+
@pytest.mark.parametrize(
106+
"test_case",
107+
[
108+
SharedDepthModelRuleCase(
109+
"a built-in model rule parses calls nested as deep as the compiler accepts",
110+
"MODEL (description 'Test model orders.');\nSELECT {expression} AS order_id",
111+
"SQBRMODEL101",
112+
expected_evaluated_models=1,
113+
expected_unevaluated_resources=0,
114+
),
115+
],
116+
ids=lambda case: case.description,
117+
)
118+
def test_given_calls_nested_within_the_shared_depth_when_running_model_rules_then_evaluates(
119+
test_case: SharedDepthModelRuleCase,
120+
tmp_path: Path,
121+
) -> None:
122+
write_unevaluated_rules_project(
123+
project_dir=tmp_path,
124+
resource_path="models/staging/orders.sql",
125+
resource_template=test_case.template,
126+
selected_rules=(test_case.rule,),
127+
)
128+
129+
result: subprocess.CompletedProcess[str] = run_unevaluated_rules_cli(
130+
tmp_path, "rules", "--json", "run", test_case.rule
131+
)
132+
133+
assert result.returncode == 0, result.stdout + result.stderr
134+
payload: dict[str, Any] = json.loads(result.stdout)
135+
assert payload["unevaluated_resources"] == test_case.expected_unevaluated_resources
136+
assert payload["evaluated_models"] == test_case.expected_evaluated_models
137+
138+
112139
@pytest.mark.parametrize(
113140
"test_case",
114141
[

0 commit comments

Comments
 (0)