Skip to content

Commit bcb37ed

Browse files
committed
style: one-line doc comments and a loop-free crash-test writer
1 parent ff1aec2 commit bcb37ed

3 files changed

Lines changed: 2 additions & 8 deletions

File tree

‎crates/sqlbuild-orchestration/src/store/models.rs‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ pub enum ControlStore {
1818
Postgres(sqlx_postgres::PgPool),
1919
}
2020

21-
/// A SQLite store's file, and an idle connection held while any handle lives.
22-
///
23-
/// Without it the next transaction's connection would be the file's first and rebuild the WAL
24-
/// index, which restarts checkpointing from the start of the WAL, so the WAL would never reset.
21+
/// A SQLite store's file, and an idle connection that keeps its WAL index between transactions.
2522
#[derive(Clone, Debug)]
2623
pub struct SqliteStore {
2724
pub(crate) path: PathBuf,

‎crates/sqlbuild-orchestration/tests/scheduler/ticks/test_types.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ impl crate::scheduler::types::RunLauncher for CycleRecorder<'_> {
8282
}
8383
}
8484

85-
/// Expires its lease and renews it on the first leader poll, so a real fence reaches the loop.
8685
/// Fences the first lease it polls with, and stops the loop once it polls under a newer epoch.
8786
pub(crate) struct FencingLauncher<'a> {
8887
pub(crate) epochs: &'a mut Vec<i64>,

‎crates/sqlbuild-orchestration/tests/store/schema/helpers.rs‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,11 @@ pub(crate) fn write_until_killed_when_spawned() {
2929
run(async {
3030
let store = open_store(&path).await.expect("open store");
3131
migrate_store(&store).await.expect("migrate store");
32-
let mut index: u64 = 0;
33-
loop {
32+
for index in 0..u64::MAX {
3433
create_location(&store, &format!("orders-{index}"), "test-admin")
3534
.await
3635
.expect("create location");
3736
println!("{ACKNOWLEDGED}{index}");
38-
index += 1;
3937
}
4038
});
4139
}

0 commit comments

Comments
 (0)