Skip to content

Commit bb2e719

Browse files
committed
test(adapters): give each temporary function case a type its dialect accepts
The shared fixture declared the argument as TEXT for every adapter, so the Databricks expectation pinned DDL that Databricks refuses. Each case now declares a type valid in its dialect, and Databricks renders STRING.
1 parent ca9a17a commit bb2e719

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

‎tests/unit/src/sqlbuild/adapter/contract/classes/strict_adapter/_test_types.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,6 @@ class TemporaryFunctionRenderingTestCase:
4545
description: str
4646
adapter: StrictAdapter
4747
language: FunctionLanguage
48+
argument_type: str
4849
return_columns: tuple[tuple[str, str], ...]
4950
expected_temporary_function: TemporaryFunction | None

‎tests/unit/src/sqlbuild/adapter/contract/classes/strict_adapter/test_temporary_function_rendering.py‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
description="duckdb copies a sql function into a temporary macro",
2424
adapter=DuckDbAdapter(),
2525
language=FunctionLanguage.SQL,
26+
argument_type="VARCHAR",
2627
return_columns=(),
2728
expected_temporary_function=TemporaryFunction(
2829
target='temp.main."is_completed_order"',
@@ -36,6 +37,7 @@
3637
description="duckdb copies a table function into a temporary table macro",
3738
adapter=DuckDbAdapter(),
3839
language=FunctionLanguage.SQL,
40+
argument_type="VARCHAR",
3941
return_columns=(("order_id", "INTEGER"),),
4042
expected_temporary_function=TemporaryFunction(
4143
target='temp.main."is_completed_order"',
@@ -49,13 +51,15 @@
4951
description="duckdb leaves python functions to per-connection registration",
5052
adapter=DuckDbAdapter(),
5153
language=FunctionLanguage.PYTHON,
54+
argument_type="VARCHAR",
5255
return_columns=(),
5356
expected_temporary_function=None,
5457
),
5558
TemporaryFunctionRenderingTestCase(
5659
description="postgres creates the copy in the session pg_temp schema",
5760
adapter=PostgresAdapter(),
5861
language=FunctionLanguage.SQL,
62+
argument_type="TEXT",
5963
return_columns=(),
6064
expected_temporary_function=TemporaryFunction(
6165
target='pg_temp."is_completed_order"',
@@ -72,6 +76,7 @@
7276
description="snowflake creates a prefixed temporary function in the current schema",
7377
adapter=SnowflakeAdapter(),
7478
language=FunctionLanguage.SQL,
79+
argument_type="TEXT",
7580
return_columns=(),
7681
expected_temporary_function=TemporaryFunction(
7782
target='"__SQB_TEST__IS_COMPLETED_ORDER"',
@@ -90,19 +95,21 @@
9095
description="bigquery has no session to hold a temporary function",
9196
adapter=BigQueryAdapter(),
9297
language=FunctionLanguage.SQL,
98+
argument_type="STRING",
9399
return_columns=(),
94100
expected_temporary_function=None,
95101
),
96102
TemporaryFunctionRenderingTestCase(
97103
description="databricks creates a prefixed session temporary function",
98104
adapter=DatabricksAdapter(),
99105
language=FunctionLanguage.SQL,
106+
argument_type="STRING",
100107
return_columns=(),
101108
expected_temporary_function=TemporaryFunction(
102109
target="`__sqb_test__is_completed_order`",
103110
statements=(
104111
"CREATE OR REPLACE TEMPORARY FUNCTION "
105-
"`__sqb_test__is_completed_order`(order_status TEXT)\n"
112+
"`__sqb_test__is_completed_order`(order_status STRING)\n"
106113
"RETURNS BOOLEAN\n"
107114
"RETURN order_status = 'completed'",
108115
),
@@ -112,13 +119,15 @@
112119
description="databricks keeps using built python functions",
113120
adapter=DatabricksAdapter(),
114121
language=FunctionLanguage.PYTHON,
122+
argument_type="STRING",
115123
return_columns=(),
116124
expected_temporary_function=None,
117125
),
118126
TemporaryFunctionRenderingTestCase(
119127
description="sql server keeps using the built function",
120128
adapter=SqlServerAdapter(),
121129
language=FunctionLanguage.SQL,
130+
argument_type="TEXT",
122131
return_columns=(),
123132
expected_temporary_function=None,
124133
),
@@ -132,7 +141,7 @@ def test_given_project_function_when_rendering_temporary_copy_then_adapter_retur
132141
name="is_completed_order",
133142
definition=FunctionDefinition(
134143
destination="analytics.is_completed_order",
135-
arguments=(FunctionArgument(name="order_status", type="TEXT"),),
144+
arguments=(FunctionArgument(name="order_status", type=test_case.argument_type),),
136145
returns="BOOLEAN",
137146
body_sql="order_status = 'completed'",
138147
return_columns=tuple(

0 commit comments

Comments
 (0)