Skip to content

Commit 73837e1

Browse files
committed
test(rules): drop the nested-comment macro format case SQLClean now declines
SQLClean 0.11.1's formatter declines a body whose nested block comment holds an apostrophe, in DuckDB, Databricks and PostgreSQL alike, and leaves it as written with a format fault, so the case no longer formats in any dialect.
1 parent 9f3a940 commit 73837e1

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

‎crates/sqlbuild-rules/src/lint_text/tests/test_lint_text.rs‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ const ESCAPED_QUOTE_MACRO: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR
3737
const ESCAPED_QUOTE_FORMATTED: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCONCAT(@v, 'O\\'Brien\n kept indent', 'tail')\n";
3838
const E_STRING_MACRO: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCONCAT(\n @v,\n E'O\\'Brien\n kept indent',\n 'tail'\n)\n";
3939
const E_STRING_FORMATTED: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCONCAT(@v, E'O\\'Brien\n kept indent', 'tail')\n";
40-
const NESTED_COMMENT_MACRO: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCOALESCE(\n @v, /* outer /* inner */ it's\n kept */\n 'x'\n)\n";
41-
const NESTED_COMMENT_FORMATTED: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCOALESCE(\n @v, /* outer /* inner */ it's\n kept */ 'x'\n)\n";
4240
const BLOCK_COMMENT_MACRO: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCOALESCE(\n @v, /* first\n second */\n 'x'\n)\n";
4341
const BLOCK_COMMENT_FORMATTED: &str = "MACRO (arguments (v VARCHAR), returns VARCHAR);\n\nCOALESCE(\n @v, /* first\n second */ 'x'\n)\n";
4442
const NORMALISE_NAME_FORMATTED: &str = "MACRO (\n description \"Normalise a name\",\n arguments (column_name VARCHAR),\n returns VARCHAR,\n);\n\nREGEXP_REPLACE(\n TRIM(\n UPPER(\n -- Collapse repeated spaces\n REGEXP_REPLACE(@column_name, '[[:space:]]+', ' ')\n )\n ),\n '(^| )([A-Z]) ',\n '\\\\1\\\\2'\n)\n";
@@ -1037,12 +1035,6 @@ fn given_expression_macro_bodies_when_formatting_twice_then_every_dialect_lays_t
10371035
contents: E_STRING_MACRO.to_string(),
10381036
expected_formatted: E_STRING_FORMATTED.to_string(),
10391037
},
1040-
ExpressionMacroFormatTestCase {
1041-
description: "a nested block comment holding an apostrophe",
1042-
dialects: &["databricks"],
1043-
contents: NESTED_COMMENT_MACRO.to_string(),
1044-
expected_formatted: NESTED_COMMENT_FORMATTED.to_string(),
1045-
},
10461038
ExpressionMacroFormatTestCase {
10471039
description: "a block comment with indented lines",
10481040
dialects: &["duckdb", "snowflake"],

0 commit comments

Comments
 (0)