Repository navigation
Commit 66652f6
authored
fix: follow the Python fan-in rule for round-trip loads (#1559)
* fix: name --no-python as the reason a round-trip load is skipped
With --no-python the task gating a round-trip loader never runs, and the
load was soft-skipped with "the SQL it reads was not rebuilt", which is not
why. The reason now says --no-python skips read-side tasks and assets.
* fix: keep a gating task's soft skip soft for its round-trip load
A round-trip load was hard-skipped whenever its gating task or asset
skipped, so a task's default soft skip blocked every model reading the
source. The load now takes the upstream's skip mode: a soft skip skips
only the load, and models reading the source still build from its last
loaded data. A hard skip or failure still blocks them.
* fix: apply the Python fan-in rule to a round-trip load's gating upstreams
A round-trip load skipped at the first gating task or asset that did not
succeed. It now follows the rule every other Python node follows: a
failed or hard-skipped upstream skips it hard, any successful upstream
lets it run, and it skips softly only when every upstream skipped softly
or did not run.
* fix: gate a round-trip load only on the tasks and assets it reads directly
A load ran when any task or asset anywhere upstream of it succeeded, so a
succeeding task behind a soft-skipped one loaded that one's stale result.
Only the tasks and assets a loader reads directly, or through other
loaders, can now let it run; a failed or hard-skipped one anywhere still
skips it hard. With --no-python, a read-side gate that did not run
soft-skips the load even when an ingress gate succeeded.1 parent f2e90ec commit 66652f6
22 files changed
Lines changed: 398 additions & 35 deletions
File tree
- benchmarks/duckshop/edge_cases/loaders/round_trip/variants
- ingress_gate
- transitive_gate
- crates
- sqlbuild-analysis/src/python_plan
- _helpers
- lifecycle
- main
- tests
- sqlbuild-python/src/bindings/_helpers/build_command
- src/sqlbuild/.agents/skills/sqlbuild/references/docs/concepts/python-nodes
- tests/e2e/src/sqlbuild/cli/commands/main/build
- website/src/content/docs/docs/concepts/python-nodes
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
39 | | - | |
| 41 | + | |
| 42 | + | |
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
| |||
0 commit comments