Skip to content

Commit 4c139a0

Browse files
committed
ci: widen the release comparison's one-model edit limit to cover runner noise
1 parent ef51849 commit 4c139a0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎.github/workflows/release-performance.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
run: uv sync --locked --all-groups --all-extras
6464
- name: Build candidate wheel
6565
run: uv build --wheel --out-dir "${RUNNER_TEMP}/candidate"
66-
# Temporary: one-model edit compiles use MAX_EDIT_COMPILE_TIME_RATIO (1.25x) because an edited
66+
# Temporary: one-model edit compiles use MAX_EDIT_COMPILE_TIME_RATIO (1.35x) because an edited
6767
# model recompiles uncached; tighten it back to 1.15x once native rendering is the default.
6868
- name: Compare candidate and previous release on this runner
6969
env:

‎scripts/release_performance/constants.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
MAX_CPU_RATIO: float = 1.25
1313
MAX_RSS_RATIO: float = 1.25
1414
MAX_COMPILE_TIME_RATIO: float = 1.15
15-
MAX_EDIT_COMPILE_TIME_RATIO: float = 1.25
15+
MAX_EDIT_COMPILE_TIME_RATIO: float = 1.35
1616
MIN_WALL_REGRESSION_SECONDS: float = 0.5
1717
MIN_CPU_REGRESSION_SECONDS: float = 0.5
1818
MIN_RSS_REGRESSION_BYTES: int = 32 * 1024 * 1024

‎tests/unit/scripts/release_performance/_helpers/test_verdict.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,19 +229,19 @@ def test_given_command_minimum_version_when_checking_versions_then_explains_skip
229229
ConfiguredTimeLimitTestCase(
230230
description="a dense one-model edit within the edit limit passes",
231231
command="dense compile (one-model edit)",
232-
wall_ratio=1.232,
232+
wall_ratio=1.289,
233233
expected_regressed=False,
234234
),
235235
ConfiguredTimeLimitTestCase(
236236
description="a one-model edit within the edit limit passes",
237237
command="compile (one-model edit)",
238-
wall_ratio=1.24,
238+
wall_ratio=1.34,
239239
expected_regressed=False,
240240
),
241241
ConfiguredTimeLimitTestCase(
242242
description="a dense one-model edit beyond the edit limit fails",
243243
command="dense compile (one-model edit)",
244-
wall_ratio=1.26,
244+
wall_ratio=1.36,
245245
expected_regressed=True,
246246
),
247247
ConfiguredTimeLimitTestCase(

0 commit comments

Comments
 (0)