fix(knowledge): keep the corpus size on a failed completion count, unschedule only connectors left without an auth source, and give fixture connectors a credential

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connector-recovery.tsx

@@ -4,6 +4,7 @@ import { useEffect, useState } from 'react'
 import { Chip } from '@sim/emcn'
 import type { ConnectorData } from '@/lib/api/contracts/knowledge/connectors'
 import { type ResourceScope, resourceScopeFields } from '@/lib/core/resource-scope'
+import { CREDENTIAL_REMOVED_SYNC_ERROR } from '@/lib/knowledge/connectors/sync-limits'
 import { getCanonicalScopesForProvider, getProviderIdFromServiceId } from '@/lib/oauth'
 import { getMissingRequiredScopes } from '@/lib/oauth/utils'
 import { ConnectOAuthModal } from '@/app/workspace/[workspaceId]/components/connect-oauth-modal'
@@ -79,6 +80,10 @@ export function ConnectorRecovery({
   }
 
   const docsUrl = isSearchIndex ? connectorDef?.searchDocsUrl : undefined
+  const credentialRemoved = connector.lastSyncError === CREDENTIAL_REMOVED_SYNC_ERROR
+  const pausedTitle = credentialRemoved
+    ? 'Reconnect to resume syncing'
+    : 'Sync paused after repeated failures'
 
   return (
     <>
@@ -91,16 +96,16 @@ export function ConnectorRecovery({
           }
         />
       )}
-      {connector.status === 'disabled' ? (
+      {connector.status === 'disabled' || credentialRemoved ? (
         <SettingsResourceRow
           title={
             !canEdit
-              ? 'Sync paused after repeated failures'
+              ? pausedTitle
               : requiresAccountSettings
                 ? 'Update the source account, then resume syncing'
                 : serviceId
                   ? 'Reconnect to resume syncing'
-                  : 'Sync paused after repeated failures'
+                  : pausedTitle
           }
           trailing={
             canEdit && requiresAccountSettings && onEdit ? (

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.test.tsx

@@ -8,6 +8,7 @@ import { afterEach, describe, expect, it, vi } from 'vitest'
 import type { SyncLogData } from '@/lib/api/contracts/knowledge/connectors'
 import {
   CONNECTOR_SYNC_STALE_LOCK_TTL_MS,
+  CREDENTIAL_REMOVED_SYNC_ERROR,
   MEMBER_SYNC_STALE_LOCK_TTL_MS,
 } from '@/lib/knowledge/connectors/sync-limits'
 
@@ -480,6 +481,21 @@ describe('Connector credential reauthorization', () => {
     expect(container.textContent).toContain('No connected sources yet.')
   })
 
+  it('offers reconnect for a connector whose credential was removed', () => {
+    oauthCredentialsState.current = [
+      { id: 'credential-1', name: 'Workspace Slack', provider: 'slack-custom' },
+    ]
+    const container = renderSection(
+      makeConnector({
+        status: 'error',
+        credentialId: null,
+        lastSyncError: CREDENTIAL_REMOVED_SYNC_ERROR,
+      })
+    )
+    expect(container.textContent).toContain('Reconnect to resume syncing')
+    expect(findButton(container, 'Reconnect')).not.toBeDisabled()
+  })
+
   it('reauthorizes with the resolved credential provider and identity', () => {
     oauthCredentialsState.current = [
       { id: 'credential-1', name: 'Workspace Slack', provider: 'slack-custom' },

apps/sim/background/drain-governed-subject.test.ts

@@ -49,9 +49,11 @@ vi.mock('@/enrichments/run', () => ({
 }))
 vi.mock('@/lib/billing/core/billing-attribution', () => ({
   assertBillingAttributionSnapshot: (snapshot: unknown) => snapshot,
-  checkAttributedUsageLimits: mocks.checkAttributedUsageLimits,
   toBillingContext: () => ({}),
 }))
+vi.mock('@/lib/billing/core/usage-gate-cache', () => ({
+  checkExecutionUsageLimits: mocks.checkAttributedUsageLimits,
+}))
 vi.mock('@/lib/table/rows/secret-provenance', () => ({
   createExactEmptyTableRowSecretProvenance: () => ({ complete: true, columns: {} }),
   createTableRowSecretProvenanceFromRegistry: () => ({ complete: true, columns: {} }),

apps/sim/background/enrichment-capability-subject.test.ts

@@ -58,9 +58,11 @@ vi.mock('@/enrichments/run', () => ({
 }))
 vi.mock('@/lib/billing/core/billing-attribution', () => ({
   assertBillingAttributionSnapshot: vi.fn((value) => value),
-  checkAttributedUsageLimits: mocks.checkAttributedUsageLimits,
   toBillingContext: vi.fn(() => ({})),
 }))
+vi.mock('@/lib/billing/core/usage-gate-cache', () => ({
+  checkExecutionUsageLimits: mocks.checkAttributedUsageLimits,
+}))
 vi.mock('@/lib/table/rows/secret-provenance', () => ({
   createExactEmptyTableRowSecretProvenance: vi.fn(() => undefined),
   createTableRowSecretProvenanceFromRegistry: vi.fn(() => undefined),

apps/sim/background/knowledge-connector-sync.test.ts

@@ -5,12 +5,16 @@
 import { AbortTaskRunError } from '@trigger.dev/sdk'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
-const { mockAssertConnectorSyncPayload, mockExecuteSync, mockTask } = vi.hoisted(() => ({
+const { mockAssertConnectorSyncPayload, mockExecuteSync, mockTask, mockWarn } = vi.hoisted(() => ({
+  mockWarn: vi.fn(),
   mockAssertConnectorSyncPayload: vi.fn(),
   mockExecuteSync: vi.fn(),
   mockTask: vi.fn((config) => config),
 }))
 
+vi.mock('@sim/logger', () => ({
+  createLogger: () => ({ info: vi.fn(), warn: mockWarn, error: vi.fn(), debug: vi.fn() }),
+}))
 vi.mock('@trigger.dev/sdk', () => ({
   task: mockTask,
   AbortTaskRunError: class AbortTaskRunError extends Error {},
@@ -142,6 +146,9 @@ describe('knowledge connector sync worker', () => {
       docsFailed: 1,
       processingDispatch: { failed: 1 },
     })
+    expect(mockWarn).toHaveBeenCalledWith(
+      expect.stringContaining('1 source failures, 1 dispatch failures')
+    )
   })
 
   it('completes a durably scheduled capacity wait while preserving existing source failures', async () => {
@@ -270,6 +277,7 @@ describe('knowledge connector sync worker', () => {
       outcome: 'partial',
       listingIncomplete: true,
     })
+    expect(mockWarn).not.toHaveBeenCalled()
   })
 
   it('classifies a persisted connector error as a failed task', () => {

apps/sim/background/workflow-group-governed-subject.test.ts

@@ -93,9 +93,11 @@ vi.mock('@/executor/utils/resolved-secret-trace-registry', () => ({
 }))
 vi.mock('@/lib/billing/core/billing-attribution', () => ({
   assertBillingAttributionSnapshot: (snapshot: unknown) => snapshot,
-  checkAttributedUsageLimits: async () => ({ isExceeded: false }),
   toBillingContext: () => ({}),
 }))
+vi.mock('@/lib/billing/core/usage-gate-cache', () => ({
+  checkExecutionUsageLimits: async () => ({ isExceeded: false }),
+}))
 /** Real pacing would sleep jittered backoff against the global db mock. */
 vi.mock('@/lib/core/rate-limiter/rate-limiter', () => ({
   RateLimiter: class {

apps/sim/lib/copilot/request/tools/workflow-context.test.ts

@@ -13,9 +13,11 @@ const { checkAttributedUsageLimitsMock, reserveExecutionSlotMock, resolveBilling
   }))
 
 vi.mock('@/lib/billing/core/billing-attribution', () => ({
-  checkAttributedUsageLimits: checkAttributedUsageLimitsMock,
   resolveBillingAttribution: resolveBillingAttributionMock,
 }))
+vi.mock('@/lib/billing/core/usage-gate-cache', () => ({
+  checkExecutionUsageLimits: checkAttributedUsageLimitsMock,
+}))
 
 vi.mock('@/lib/billing/calculations/usage-reservation', () => ({
   reserveExecutionSlot: reserveExecutionSlotMock,

apps/sim/lib/credentials/deletion.test.ts

@@ -215,6 +215,7 @@ describe('clearCredentialRefs', () => {
       `CASE WHEN "knowledge_connector"."status" IN ('paused', 'disabled')`
     )
     expect(statement).toContain('"access_mode" in ($')
+    expect(statement).toContain('"encrypted_api_key" is null')
     expect(updates[0].params).toEqual(
       expect.arrayContaining([
         'Credential removed. Reconnect the connector to resume syncing.',

apps/sim/lib/credentials/deletion.ts

@@ -2,7 +2,7 @@ import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { db } from '@sim/db'
 import * as schema from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
-import { and, eq, inArray, notExists, or, sql } from 'drizzle-orm'
+import { and, eq, inArray, isNull, notExists, or, sql } from 'drizzle-orm'
 import type { AnyPgColumn, PgTable } from 'drizzle-orm/pg-core'
 import type { NextRequest } from 'next/server'
 import {
@@ -342,8 +342,8 @@ async function readWorkspaceCredentialRefs(
 /**
  * A content-engine connector whose credential is gone cannot sync until it is reconnected, so
  * it leaves the due sweep with the reconnect error; paused and disabled connectors keep their
- * status. A members-mode connector only loses its optional dedicated content credential: its
- * member crawls keep running, so it merely drops the reference.
+ * status. A connector that still holds an API key, or a members-mode connector that only loses
+ * its optional dedicated content credential, keeps running and merely drops the reference.
  */
 async function clearInKnowledgeConnectors(credentialId: string): Promise<void> {
   const now = new Date()
@@ -357,7 +357,8 @@ async function clearInKnowledgeConnectors(credentialId: string): Promise<void> {
     .where(
       and(
         eq(schema.knowledgeConnector.credentialId, credentialId),
-        inArray(schema.knowledgeConnector.accessMode, [...CONTENT_ENGINE_ACCESS_MODES])
+        inArray(schema.knowledgeConnector.accessMode, [...CONTENT_ENGINE_ACCESS_MODES]),
+        isNull(schema.knowledgeConnector.encryptedApiKey)
       )
     )
   await db

apps/sim/lib/execution/preprocessing.webhook-correlation.test.ts

@@ -14,10 +14,12 @@ vi.mock('@/lib/billing/calculations/usage-monitor', () => ({
 }))
 vi.mock('@/lib/billing/core/billing-attribution', () => ({
   assertBillingAttributionSnapshot: vi.fn((value) => value),
-  checkAttributedUsageLimits: vi.fn(),
   resolveBillingAttribution: vi.fn(),
   resolveSystemBillingAttribution: mockResolveSystemBillingAttribution,
 }))
+vi.mock('@/lib/billing/core/usage-gate-cache', () => ({
+  checkExecutionUsageLimits: vi.fn(),
+}))
 vi.mock('@/lib/billing/core/subscription', () => ({
   getHighestPrioritySubscription: vi.fn(),
 }))