Skip to content

Commit c9a3eb5

Browse files
committed
fix(docs): normalize feedback paths and scope error assertions
1 parent 4ea19dc commit c9a3eb5

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎apps/docs/app/api/feedback/route.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export async function POST(request: Request) {
5353
} catch {
5454
return fail('Check your feedback and try again.', 400)
5555
}
56-
const page = getPage(input.page)
56+
const page = getPage(input.page.replace(/\/$/, '') || '/')
5757
if (!page || page.url === '/') return fail('Documentation page not found.', 404)
5858
const endpoint = process.env.DOCS_FEEDBACK_WEBHOOK_URL
5959
const token = process.env.DOCS_FEEDBACK_WEBHOOK_TOKEN

‎apps/docs/scripts/test-navigation-e2e.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,9 @@ try {
203203
)
204204
await send.click()
205205
expect((await response).status()).toBe(502)
206-
await expect(page.getByRole('alert')).toContainText('Could not send feedback.')
206+
await expect(page.getByRole('main').getByRole('alert')).toContainText(
207+
'Could not send feedback.'
208+
)
207209
await expect(comment).toHaveValue(' Explain deployment prerequisites. ')
208210
await expect(send).toBeEnabled()
209211
}

0 commit comments

Comments
 (0)