fix(knowledge): leave values at the limit untouched and refuse over-long tag values on the tag-data and tag-update paths

Author: waleedlatif1

apps/sim/lib/knowledge/application/documents.ts

@@ -68,7 +68,7 @@ import {
   toKnowledgeTagFilterConditions,
 } from '@/lib/knowledge/tags/filter-resolution'
 import { getDocumentTagDefinitions } from '@/lib/knowledge/tags/service'
-import { validateTagValue } from '@/lib/knowledge/tags/utils'
+import { validateTagValue, validateTagValueLength } from '@/lib/knowledge/tags/utils'
 import { StorageService } from '@/lib/uploads'
 import { generateKnowledgeBaseFileKey } from '@/lib/uploads/contexts/knowledge-base/knowledge-base-file-manager'
 import { recordKnowledgeBaseFileOwnership } from '@/lib/uploads/server/metadata'
@@ -252,7 +252,9 @@ async function resolveKnowledgeDocumentTagValueUpdates(
         `Tag "${definition.displayName}" requires a value; use null to clear it`
       )
     }
-    const validationError = validateTagValue(definition.displayName, value, definition.fieldType)
+    const validationError =
+      validateTagValueLength(definition.displayName, value) ??
+      validateTagValue(definition.displayName, value, definition.fieldType)
     if (validationError) {
       throw new OrchestrationError('validation', validationError)
     }

apps/sim/lib/knowledge/connectors/sync-persistence.test.ts

@@ -450,6 +450,16 @@ describe('resolveTagMapping', () => {
     expect(tags?.tag2).toBe('Purchasing')
   })
 
+  it('keeps a value exactly at the limit untouched', () => {
+    const atLimit = 'z'.repeat(512)
+    const tags = resolveTagMapping(
+      'fixture',
+      { label: atLimit },
+      { tagSlotMapping: { label: 'tag1' } }
+    )
+    expect(tags?.tag1).toBe(atLimit)
+  })
+
   it('cuts by code point so a bounded value never ends in half a surrogate pair', () => {
     const tags = resolveTagMapping(
       'fixture',

apps/sim/lib/knowledge/connectors/sync-persistence.ts

@@ -184,6 +184,7 @@ const INDEXED_TEXT_CUT_SUFFIX = '...'
  * never inside a surrogate pair. The result always passes the document APIs' own bound.
  */
 function boundIndexedText(value: string): string {
+  if (value.length <= MAX_DOCUMENT_INDEXED_TEXT_LENGTH) return value
   return truncateAtCodePoint(
     value,
     MAX_DOCUMENT_INDEXED_TEXT_LENGTH - INDEXED_TEXT_CUT_SUFFIX.length,

apps/sim/lib/knowledge/documents/service.ts

@@ -179,6 +179,7 @@ import {
   parseNumberValue,
   uncompilableTagFilterError,
   validateTagValue,
+  validateTagValueLength,
 } from '@/lib/knowledge/tags/utils'
 import type { ProcessedDocumentTags } from '@/lib/knowledge/types'
 import { embeddingVectorValues } from '@/lib/knowledge/vector-columns'
@@ -552,7 +553,9 @@ function resolveDocumentTags(
 
     const rawValue = typeof tag.value === 'string' ? tag.value.trim() : tag.value
     const actualFieldType = existingDef.fieldType || fieldType
-    const validationError = validateTagValue(tagName, String(rawValue), actualFieldType)
+    const validationError =
+      validateTagValueLength(tagName, String(rawValue)) ??
+      validateTagValue(tagName, String(rawValue), actualFieldType)
     if (validationError) {
       typeErrors.push(validationError)
     }

apps/sim/lib/knowledge/tags/utils.test.ts

@@ -2,7 +2,11 @@
  * @vitest-environment node
  */
 import { describe, expect, it } from 'vitest'
-import { coerceTagFilterValue, validateTagValue } from '@/lib/knowledge/tags/utils'
+import {
+  coerceTagFilterValue,
+  validateTagValue,
+  validateTagValueLength,
+} from '@/lib/knowledge/tags/utils'
 
 describe('coerceTagFilterValue', () => {
   it('accepts exactly what validateTagValue accepts', () => {
@@ -68,3 +72,12 @@ describe('validateTagValue', () => {
     expect(validateTagValue('name', 'anything', 'json')).toBeNull()
   })
 })
+
+describe('validateTagValueLength', () => {
+  it('accepts a value at the indexed-text limit and names the tag past it', () => {
+    expect(validateTagValueLength('Labels', 'a'.repeat(512))).toBeNull()
+    expect(validateTagValueLength('Labels', 'a'.repeat(513))).toBe(
+      'Tag "Labels" cannot exceed 512 characters'
+    )
+  })
+})

apps/sim/lib/knowledge/tags/utils.ts

@@ -1,4 +1,5 @@
 import { OrchestrationError } from '@/lib/core/orchestration/types'
+import { MAX_DOCUMENT_INDEXED_TEXT_LENGTH } from '@/lib/knowledge/constants'
 
 const DATE_ONLY_PATTERN = /^\d{4}-\d{2}-\d{2}$/
 
@@ -94,6 +95,17 @@ export function uncompilableTagFilterError(filter: {
  * Validate a tag value against its expected field type
  * Returns an error message if invalid, or null if valid
  */
+/**
+ * Text tag values sit under an index whose rows Postgres caps in size; a value past
+ * {@link MAX_DOCUMENT_INDEXED_TEXT_LENGTH} would fail the document write itself, so it is
+ * refused with a message naming the tag instead.
+ */
+export function validateTagValueLength(tagName: string, value: string): string | null {
+  return value.length > MAX_DOCUMENT_INDEXED_TEXT_LENGTH
+    ? `Tag "${tagName}" cannot exceed ${MAX_DOCUMENT_INDEXED_TEXT_LENGTH} characters`
+    : null
+}
+
 export function validateTagValue(tagName: string, value: string, fieldType: string): string | null {
   if (fieldType !== 'boolean' && fieldType !== 'number' && fieldType !== 'date') return null