|
| 1 | +/** @vitest-environment node */ |
| 2 | +import { authMockFns, dbChainMockFns } from '@sim/testing' |
| 3 | +import { NextRequest } from 'next/server' |
| 4 | +import { beforeEach, describe, expect, it, vi } from 'vitest' |
| 5 | +import { OrchestrationError } from '@/lib/core/orchestration/types' |
| 6 | + |
| 7 | +const m = vi.hoisted(() => ({ |
| 8 | + authenticate: vi.fn(), |
| 9 | + complete: vi.fn(), |
| 10 | + rate: vi.fn(), |
| 11 | +})) |
| 12 | +vi.mock('@/lib/slack-search/public-install-auth', () => ({ |
| 13 | + authenticateSlackPublicInstallation: m.authenticate, |
| 14 | +})) |
| 15 | +vi.mock('@/lib/knowledge/application/slack-search/setup', () => ({ |
| 16 | + completeSlackSearchSetup: { execute: m.complete }, |
| 17 | +})) |
| 18 | +vi.mock('@/lib/core/rate-limiter', async (importOriginal) => ({ |
| 19 | + ...(await importOriginal<typeof import('@/lib/core/rate-limiter')>()), |
| 20 | + enforceIpRateLimit: m.rate, |
| 21 | + enforceUserRateLimit: m.rate, |
| 22 | +})) |
| 23 | +vi.mock('@/lib/core/utils/urls', () => ({ |
| 24 | + getBaseUrl: () => 'https://www.sim.ai', |
| 25 | + SITE_URL: 'https://www.sim.ai', |
| 26 | +})) |
| 27 | + |
| 28 | +import { GET, HEAD } from '@/app/api/knowledge/slack/oauth/callback/route' |
| 29 | + |
| 30 | +const request = (query: string) => |
| 31 | + new NextRequest(`https://www.sim.ai/api/knowledge/slack/oauth/callback?${query}`) |
| 32 | +beforeEach(() => { |
| 33 | + vi.clearAllMocks() |
| 34 | + authMockFns.mockGetSession.mockResolvedValue({ |
| 35 | + user: { id: 'admin' }, |
| 36 | + session: { id: 'session' }, |
| 37 | + }) |
| 38 | + m.rate.mockResolvedValue(null) |
| 39 | + m.authenticate.mockResolvedValue({ teamId: 'T1' }) |
| 40 | + m.complete.mockResolvedValue({ organizationId: 'org1' }) |
| 41 | +}) |
| 42 | +describe('Slack OAuth callback', () => { |
| 43 | + it.each(['code=code', 'state=&code=code'])( |
| 44 | + 'accepts Slack-initiated install without Sim login: %s', |
| 45 | + async (query) => { |
| 46 | + authMockFns.mockGetSession.mockResolvedValue(null) |
| 47 | + const response = await GET(request(query)) |
| 48 | + expect(response.status).toBe(303) |
| 49 | + expect(response.headers.get('location')).toBe('https://www.sim.ai/slack-search/install/T1') |
| 50 | + expect(response.headers.get('cache-control')).toBe('no-store') |
| 51 | + expect(response.headers.get('referrer-policy')).toBe('no-referrer') |
| 52 | + expect(authMockFns.mockGetSession).not.toHaveBeenCalled() |
| 53 | + expect(dbChainMockFns.insert).not.toHaveBeenCalled() |
| 54 | + expect(dbChainMockFns.update).not.toHaveBeenCalled() |
| 55 | + expect(m.complete).not.toHaveBeenCalled() |
| 56 | + } |
| 57 | + ) |
| 58 | + it('does not attach a public grant to an existing browser session', async () => { |
| 59 | + await GET(request('code=code&organizationId=attacker')) |
| 60 | + expect(authMockFns.mockGetSession).not.toHaveBeenCalled() |
| 61 | + expect(dbChainMockFns.insert).not.toHaveBeenCalled() |
| 62 | + expect(dbChainMockFns.update).not.toHaveBeenCalled() |
| 63 | + expect(m.complete).not.toHaveBeenCalled() |
| 64 | + }) |
| 65 | + it('keeps org-initiated installs on the existing session/state path', async () => { |
| 66 | + const response = await GET(request('state=state&code=code')) |
| 67 | + expect(response.status).toBe(303) |
| 68 | + expect(response.headers.get('location')).toBe( |
| 69 | + 'https://www.sim.ai/o/org1/settings/search-slack?slackSetup=complete' |
| 70 | + ) |
| 71 | + expect(m.complete).toHaveBeenCalledWith( |
| 72 | + expect.objectContaining({ |
| 73 | + principal: { kind: 'session', userId: 'admin', sessionId: 'session' }, |
| 74 | + input: { state: 'state', code: 'code', error: undefined }, |
| 75 | + }) |
| 76 | + ) |
| 77 | + expect(m.authenticate).not.toHaveBeenCalled() |
| 78 | + }) |
| 79 | + it('never falls back to public install on an invalid nonempty state', async () => { |
| 80 | + m.complete.mockRejectedValueOnce(new OrchestrationError('validation', 'Expired state')) |
| 81 | + expect((await GET(request('state=expired&code=code'))).status).toBe(400) |
| 82 | + expect(m.authenticate).not.toHaveBeenCalled() |
| 83 | + }) |
| 84 | + it('still requires a Sim session for an org-bound state', async () => { |
| 85 | + authMockFns.mockGetSession.mockResolvedValue(null) |
| 86 | + expect((await GET(request('state=state&code=code'))).status).toBe(401) |
| 87 | + expect(m.authenticate).not.toHaveBeenCalled() |
| 88 | + expect(m.complete).not.toHaveBeenCalled() |
| 89 | + }) |
| 90 | + it.each(['error=access_denied', '', 'state=&state=other&code=code', 'code=a&code=b'])( |
| 91 | + 'rejects ambiguous or denied callbacks: %s', |
| 92 | + async (query) => { |
| 93 | + expect((await GET(request(query))).status).toBe(400) |
| 94 | + expect(m.authenticate).not.toHaveBeenCalled() |
| 95 | + expect(m.complete).not.toHaveBeenCalled() |
| 96 | + } |
| 97 | + ) |
| 98 | + it('does not consume codes on HEAD requests or after rate limiting', async () => { |
| 99 | + expect((await HEAD(request('code=code'))).status).toBe(405) |
| 100 | + m.rate.mockResolvedValue(new Response(null, { status: 429 })) |
| 101 | + expect((await GET(request('code=code'))).status).toBe(429) |
| 102 | + expect(m.authenticate).not.toHaveBeenCalled() |
| 103 | + }) |
| 104 | +}) |
0 commit comments