fix(chat): preserve external downloads and report bulk failures

Author: icecrasher321

apps/sim/app/(interfaces)/chat/components/message/components/file-download.test.tsx

@@ -136,11 +136,14 @@ describe('chat file downloads', () => {
     }
   )
 
-  it('keeps external URL files on their existing URL path', async () => {
-    fetchMock.mockResolvedValue(new Response('external bytes'))
-    await clickDownload(renderFile({ ...imageFile, base64: undefined, key: 'url/external' }))
-    expect(fetchMock).toHaveBeenCalledExactlyOnceWith(imageFile.url, { cache: 'no-store' })
-  })
+  it.each(['url/external', 'result-123', ''])(
+    'keeps external URL files with key "%s" on their existing URL path',
+    async (key) => {
+      fetchMock.mockResolvedValue(new Response('external bytes'))
+      await clickDownload(renderFile({ ...imageFile, base64: undefined, key }))
+      expect(fetchMock).toHaveBeenCalledExactlyOnceWith(imageFile.url, { cache: 'no-store' })
+    }
+  )
 
   it('preserves delivered signed access for public visitors without a workspace session', async () => {
     fetchMock
@@ -183,6 +186,36 @@ describe('chat file downloads', () => {
     })
     expect(fetchMock).toHaveBeenCalledTimes(1)
   })
+
+  it('reports partial bulk failures, continues the batch, and clears the alert after a successful retry', async () => {
+    fetchMock.mockResolvedValue(new Response(null, { status: 403 }))
+    const stored = { ...imageFile, id: 'stored', name: 'stored.png', base64: undefined }
+    const container = renderFile([stored, imageFile])
+    await clickDownload(container)
+    expect(downloadedNames).toEqual(['generated.png'])
+    expect(container.querySelector('[role="alert"]')?.textContent).toContain(
+      'Unable to download 1 file'
+    )
+    fetchMock.mockResolvedValue(new Response('stored bytes'))
+    await act(async () => {
+      container.querySelector('button')!.click()
+      await vi.waitFor(() =>
+        expect(downloadedNames).toEqual(['generated.png', 'stored.png', 'generated.png'])
+      )
+    })
+    expect(container.querySelector('[role="alert"]')).toBeNull()
+  })
+
+  it('uses the recognized key context when metadata omits it', async () => {
+    fetchMock.mockResolvedValue(new Response('workspace bytes'))
+    await clickDownload(
+      renderFile({ ...imageFile, base64: undefined, key: 'workspace/id/file.png' })
+    )
+    expect(fetchMock).toHaveBeenCalledExactlyOnceWith(
+      '/api/files/serve/workspace%2Fid%2Ffile.png?context=workspace',
+      { cache: 'no-store' }
+    )
+  })
 })
 
 it('refuses unsafe external file URLs', async () => {

apps/sim/app/(interfaces)/chat/components/message/components/file-download.tsx

@@ -8,6 +8,7 @@ import { sleep } from '@sim/utils/helpers'
 import { DefaultFileIcon, getDocumentIcon } from '@/components/icons/document-icons'
 import { isSafeHttpUrl } from '@/lib/core/utils/urls'
 import { saveBlob } from '@/lib/uploads/client/download'
+import { tryInferContextFromKey } from '@/lib/uploads/utils/file-utils'
 import type { ChatFile } from '@/app/(interfaces)/chat/components/message/message'
 
 const logger = createLogger('ChatFileDownload')
@@ -69,9 +70,10 @@ async function triggerDownload(file: ChatFile): Promise<void> {
     return
   }
 
-  const hasStorageKey = Boolean(file.key && !file.key.startsWith('url/'))
+  const storageContext = tryInferContextFromKey(file.key)
+  const hasStorageKey = storageContext !== null
   const url = hasStorageKey
-    ? `/api/files/serve/${encodeURIComponent(file.key)}?context=${encodeURIComponent(file.context || 'execution')}`
+    ? `/api/files/serve/${encodeURIComponent(file.key)}?context=${encodeURIComponent(storageContext)}`
     : isSafeHttpUrl(file.url)
       ? file.url
       : null
@@ -167,13 +169,16 @@ export function ChatFileDownload({ file }: ChatFileDownloadProps) {
 
 export function ChatFileDownloadAll({ files }: ChatFileDownloadAllProps) {
   const [isDownloading, setIsDownloading] = useState(false)
+  const [failedCount, setFailedCount] = useState(0)
 
   if (!files || files.length === 0) return null
 
   const handleDownloadAll = async () => {
     if (isDownloading) return
 
     setIsDownloading(true)
+    setFailedCount(0)
+    let failures = 0
 
     try {
       logger.info(`Initiating download for ${files.length} files`)
@@ -189,25 +194,35 @@ export function ChatFileDownloadAll({ files }: ChatFileDownloadAllProps) {
           }
         } catch (error) {
           logger.error(`Failed to download file ${file.name}:`, error)
+          failures++
         }
       }
     } finally {
+      setFailedCount(failures)
       setIsDownloading(false)
     }
   }
 
   return (
-    <Button
-      variant='ghost-secondary'
-      onClick={handleDownloadAll}
-      disabled={isDownloading}
-      className='p-0'
-    >
-      {isDownloading ? (
-        <Loader className='size-3' animate />
-      ) : (
-        <Download className='size-3' strokeWidth={2} />
+    <div className='flex flex-col items-start gap-2'>
+      <Button
+        variant='ghost-secondary'
+        onClick={handleDownloadAll}
+        disabled={isDownloading}
+        className='p-0'
+      >
+        {isDownloading ? (
+          <Loader className='size-3' animate />
+        ) : (
+          <Download className='size-3' strokeWidth={2} />
+        )}
+      </Button>
+      {failedCount > 0 && (
+        <p role='alert' className='text-[var(--text-error)] text-xs'>
+          Unable to download {failedCount} {failedCount === 1 ? 'file' : 'files'}. Please try
+          downloading them individually.
+        </p>
       )}
-    </Button>
+    </div>
   )
 }