Skip to content

Commit 277abfe

Browse files
committed
fix(sso): label the SAML toggles for the chip control
The chip switch takes no id, so the labels' htmlFor pointed at elements that no longer exist and clicking one did nothing. They are plain labels beside an aria-labelled control now, matching inbox-enable-toggle. The new field hint also uses the text-caption token rather than text-xs.
1 parent 6aee268 commit 277abfe

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

‎apps/sim/ee/sso/components/sso-provider-settings.tsx‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,9 +1111,7 @@ export function SsoProviderSettings({
11111111
</SettingRow>
11121112

11131113
<div className='flex items-center justify-between gap-4'>
1114-
<Label htmlFor='sso-signed-assertions'>
1115-
Require signed SAML assertions
1116-
</Label>
1114+
<Label>Require signed SAML assertions</Label>
11171115
<ChipSwitch
11181116
aria-label='Require signed SAML assertions'
11191117
options={TOGGLE_OPTIONS}
@@ -1125,7 +1123,7 @@ export function SsoProviderSettings({
11251123
</div>
11261124

11271125
<div className='flex items-center justify-between gap-4'>
1128-
<Label htmlFor='sso-encrypt-assertions'>Encrypt SAML assertions</Label>
1126+
<Label>Encrypt SAML assertions</Label>
11291127
<ChipSwitch
11301128
aria-label='Encrypt SAML assertions'
11311129
options={TOGGLE_OPTIONS}
@@ -1163,7 +1161,7 @@ export function SsoProviderSettings({
11631161
error={showErrors && errors.spEncryptionCert?.length > 0}
11641162
rows={3}
11651163
/>
1166-
<p className='mt-1 text-[var(--text-muted)] text-xs'>
1164+
<p className='mt-1 text-[var(--text-muted)] text-caption'>
11671165
Upload this certificate to your identity provider so it can encrypt
11681166
assertions to Sim.
11691167
</p>

0 commit comments

Comments
 (0)