Match chat attachment guidance to supported file capabilities

Author: Sg312

apps/sim/lib/mothership/chat/payload.test.ts

@@ -518,7 +518,7 @@ describe('buildCopilotRequestPayload', () => {
           content: [
             'File "payroll.xlsx" (application/octet-stream, 1 bytes) uploaded to this chat as "uploads/payroll.xlsx" (a chat upload: readable here, not listed under workspace files/).',
             'Read it with: sim --output json files read "uploads/payroll.xlsx"',
-            'Pass the same path "uploads/payroll.xlsx" as inputs.files[].path to mount it in run_code or use it as a reference image in generate_image.',
+            'Pass the same path "uploads/payroll.xlsx" as inputs.files[].path to mount it in run_code.',
           ].join('\n'),
         },
       ])
@@ -559,7 +559,7 @@ describe('buildCopilotRequestPayload', () => {
           type: 'uploaded_file',
           content: [
             'File "photo.png" (image/png, 10 bytes) uploaded to this chat as "uploads/photo.png" (a chat upload: readable here, not listed under workspace files/).',
-            'Read it with: sim --output json files read "uploads/photo.png"',
+            'Inspect it with sim_cli: {"args":["files","view","uploads/photo.png"]}',
             'Pass the same path "uploads/photo.png" as inputs.files[].path to mount it in run_code or use it as a reference image in generate_image.',
           ].join('\n'),
         },

apps/sim/lib/mothership/chat/upload-context.test.ts

@@ -0,0 +1,72 @@
+import { describe, expect, it } from 'vitest'
+import { buildUploadedFileContext } from '@/lib/mothership/chat/upload-context'
+
+describe('uploaded file discovery guidance', () => {
+  it.each([
+    ['photo.png', 'image/png'],
+    ['photo.jpeg', 'image/jpeg'],
+    ['photo.webp', 'image/webp'],
+    ['photo.gif', 'image/gif'],
+    ['report.pdf', 'application/pdf'],
+    ['photo.png', 'image/png; charset=binary'],
+  ])('routes supported visual %s through the agent vision command', (name, mediaType) => {
+    const { content } = buildUploadedFileContext(name, mediaType, 10)
+
+    expect(content).toContain(
+      `Inspect it with sim_cli: ${JSON.stringify({ args: ['files', 'view', `uploads/${name}`] })}`
+    )
+    expect(content).not.toContain('files read')
+    expect(content).toContain('inputs.files[].path to mount it in run_code')
+    if (mediaType === 'application/pdf') expect(content).not.toContain('reference image')
+  })
+
+  it.each([
+    ['notes.txt', 'text/plain'],
+    ['report.md', 'text/markdown'],
+    ['payroll.xlsx', 'application/octet-stream'],
+  ])('retains text extraction for supported %s', (name, mediaType) => {
+    const { content } = buildUploadedFileContext(name, mediaType, 10)
+
+    expect(content).toContain(`files read "uploads/${name}"`)
+    expect(content).not.toContain('files","view')
+    expect(content).not.toContain('reference image')
+  })
+
+  it.each([
+    ['clip.mp4', 'video/mp4'],
+    ['audio.mp3', 'audio/mpeg'],
+    ['drawing.svg', 'image/svg+xml'],
+    ['scan.tiff', 'image/tiff'],
+    ['unknown.bin', 'application/octet-stream'],
+  ])('offers a code mount without unsupported read/view instructions for %s', (name, mediaType) => {
+    const { content } = buildUploadedFileContext(name, mediaType, 10)
+
+    expect(content).toContain(`"uploads/${name}" as inputs.files[].path to mount it in run_code.`)
+    expect(content).not.toContain('files read')
+    expect(content).not.toContain('files","view')
+    expect(content).not.toContain('reference image')
+  })
+
+  it('keeps the same encoded reference in vision and code guidance', () => {
+    const { content } = buildUploadedFileContext('screen shot #1.png', 'image/png', 10)
+
+    expect(content).toContain('"args":["files","view","uploads/screen%20shot%20%231.png"]')
+    expect(content).toContain('"uploads/screen%20shot%20%231.png" as inputs.files[].path')
+  })
+
+  it('retains workflow JSON import guidance', () => {
+    const { content } = buildUploadedFileContext('workflow.json', 'application/json', 10)
+
+    expect(content).toContain('files read "uploads/workflow.json"')
+    expect(content).toContain('workflows import --workflow')
+  })
+
+  it('retains archive extraction without suggesting direct reads or vision', () => {
+    const { content } = buildUploadedFileContext('bundle.zip', 'application/zip', 10)
+
+    expect(content).toContain('Archive "bundle.zip"')
+    expect(content).toContain('unzip it there')
+    expect(content).not.toContain('Read it with:')
+    expect(content).not.toContain('Inspect it with sim_cli:')
+  })
+})

apps/sim/lib/mothership/chat/upload-context.ts

@@ -1,6 +1,12 @@
+import { isSupportedFileType } from '@/lib/file-parsers'
+import { ObservationMediaType } from '@/lib/mothership/generated/observations'
 import type { ChatContextItem } from '@/lib/mothership/generated/protocol'
 import { encodeVfsSegment } from '@/lib/mothership/vfs/path-utils'
-import { buildArchiveExtractGuidance, isArchiveFileName } from '@/lib/uploads/utils/file-utils'
+import {
+  buildArchiveExtractGuidance,
+  getFileExtension,
+  isArchiveFileName,
+} from '@/lib/uploads/utils/file-utils'
 
 /** The same chat upload path works for CLI reads, code mounts and image references. */
 export function buildUploadedFileContext(
@@ -23,11 +29,19 @@ export function buildUploadedFileContext(
       ].join('\n'),
     }
   }
+  const reference = `uploads/${encodedUploadName}`
+  const visualType = ObservationMediaType.safeParse(mediaType.split(';')[0]?.trim())
   const lines = [
     `File "${displayName}" (${mediaType}, ${size} bytes) uploaded to this chat as "uploads/${encodedUploadName}" (a chat upload: readable here, not listed under workspace files/).`,
-    `Read it with: sim --output json files read "uploads/${encodedUploadName}"`,
-    `Pass the same path "uploads/${encodedUploadName}" as inputs.files[].path to mount it in run_code or use it as a reference image in generate_image.`,
   ]
+  if (visualType.success) {
+    lines.push(`Inspect it with sim_cli: ${JSON.stringify({ args: ['files', 'view', reference] })}`)
+  } else if (isSupportedFileType(getFileExtension(displayName))) {
+    lines.push(`Read it with: sim --output json files read "${reference}"`)
+  }
+  lines.push(
+    `Pass the same path "${reference}" as inputs.files[].path to mount it in run_code${visualType.success && visualType.data.startsWith('image/') ? ' or use it as a reference image in generate_image' : ''}.`
+  )
   if (displayName.endsWith('.json')) {
     lines.push(
       "If it is a workflow export: read it with files read, then import the JSON with: sim --output json workflows import --workflow '<the JSON>'"