fix(knowledge): remember a saturated reach only once its count succeeded, and read the Tin flag before the index

Author: waleedlatif1

apps/sim/lib/knowledge/search/queries.test.ts

@@ -1909,6 +1909,38 @@ describe('permitted-document planner', () => {
       expect(reachCounts()).toHaveLength(2)
     })
 
+    it('does not remember a saturated reach whose count ran out of time', async () => {
+      dbChainMockFns.execute.mockImplementation(async (query) => {
+        const statement = render(query).sql
+        if (isProbeStatement(statement)) return [{ id: null, connectorId: null, saturated: true }]
+        if (statement.includes('EXPLAIN'))
+          return [{ 'QUERY PLAN': [{ Plan: { 'Plan Rows': 1_000_000 } }] }]
+        if (statement.includes(') reached'))
+          throw Object.assign(new Error('canceling statement due to statement timeout'), {
+            code: '57014',
+          })
+        return []
+      })
+      const reachCounts = () => statements().filter((query) => query.sql.includes(') reached'))
+      const budget = () => new SearchBudget('vector', performance.now() + 10_000)
+      expect(
+        await resolvePermittedDocuments({
+          knowledgeBaseIds: ['org-index'],
+          access: scope('timed-saturated'),
+          budget: budget(),
+        })
+      ).toEqual({ kind: 'unbounded', broad: true })
+      expect(reachCounts()).toHaveLength(1)
+      /** The next search probes and counts again rather than trusting a reach that was never measured. */
+      await resolvePermittedDocuments({
+        knowledgeBaseIds: ['org-index'],
+        access: scope('timed-saturated'),
+        budget: budget(),
+      })
+      expect(probes()).toBe(2)
+      expect(reachCounts()).toHaveLength(2)
+    })
+
     it('counts a resolved reach against a small index instead of assuming it broad', async () => {
       /** A bound inside the probe limit proves nothing without a saturated probe. */
       dbChainMockFns.execute.mockImplementation(async (query) => {

apps/sim/lib/knowledge/search/queries.ts

@@ -1390,10 +1390,11 @@ export async function resolvePermittedDocuments(params: {
           params.accessPlan,
           true
         )
+        if (key) saturatedReach.set(key, { broad })
       } catch (error) {
         if (!params.budget?.isTimeout(error)) throw error
+        /** A count that ran out of time decides this search only; the next one counts again. */
       }
-      if (key) saturatedReach.set(key, { broad })
     }
   }
   const permitted: PermittedDocuments =

apps/sim/lib/knowledge/search/tin-keyword.test.ts

@@ -36,11 +36,7 @@ describe('resolveTinKeywordQuery', () => {
   it('is off while the rollout flag is off, without touching the database', async () => {
     mockIsFeatureEnabled.mockResolvedValue(false)
     expect(await resolveTinKeywordQuery(true, 'release notes', 'english', undefined)).toBeNull()
-    expect(
-      dbChainMockFns.execute.mock.calls.some(([query]) =>
-        JSON.stringify(query).includes('websearch_to_tsquery')
-      )
-    ).toBe(false)
+    expect(dbChainMockFns.execute).not.toHaveBeenCalled()
   })
 
   it('translates the analyzed query when every base is a search index', async () => {

apps/sim/lib/knowledge/search/tin-keyword.ts

@@ -52,12 +52,9 @@ export async function resolveTinKeywordQuery(
 ): Promise<string | null> {
   if (!searchIndexOnly) return null
   try {
-    /** The flag and the index are independent facts; the search waits for the slower one only. */
-    const [enabled, ready] = await Promise.all([
-      isFeatureEnabled('knowledge-tin-keyword'),
-      indexReadiness.fetch('index', { context: budget }),
-    ])
-    if (!enabled || !ready) return null
+    /** The flag is read from memory and decides whether the index is worth asking about at all. */
+    if (!(await isFeatureEnabled('knowledge-tin-keyword'))) return null
+    if (!(await indexReadiness.fetch('index', { context: budget }))) return null
     const [{ rendered }] = await runSearchQuery(budget, 'keyword.tin_query', (executor) =>
       executor.execute<{ rendered: string }>(
         sql`SELECT websearch_to_tsquery(${ftsConfig}::regconfig, ${query})::text AS rendered`