fix(realtime): reject locked-block tool updates and tighten new types

Author: waleedlatif1

apps/realtime/src/database/operations.test.ts

@@ -164,8 +164,8 @@ describe('subblock update with canonical modes persistence', () => {
     )
   })
 
-  it('skips a locked block without writing either field', async () => {
-    await expect(updateTools({ locked: true })).resolves.toBeUndefined()
+  it('rejects a locked block without writing either field', async () => {
+    await expect(updateTools({ locked: true })).rejects.toThrow('is locked')
     expect(mockSet).toHaveBeenCalledTimes(1)
   })
 })

apps/realtime/src/database/operations.ts

@@ -1998,10 +1998,10 @@ interface SubblockUpdateBlockRecord {
 
 /** Every block in the workflow by id, for the locked-container check subblock writes need. */
 async function loadSubblockUpdateBlocks(
-  tx: any,
+  tx: Pick<typeof db, 'select'>,
   workflowId: string
 ): Promise<Record<string, SubblockUpdateBlockRecord>> {
-  const allBlocks: SubblockUpdateBlockRecord[] = await tx
+  const allBlocks = await tx
     .select({
       id: workflowBlocks.id,
       subBlocks: workflowBlocks.subBlocks,
@@ -2083,11 +2083,12 @@ async function handleSubblockOperationTx(
         throw new Error(`Block ${blockId} not found`)
       }
       if (isWorkflowBlockProtected(blockId, blocksById)) {
-        logger.info(`Skipping subblock update of locked block ${blockId}`)
-        break
+        throw new Error(`Block ${blockId} is locked or inside a locked container`)
       }
 
-      const subBlocks = { ...((block.subBlocks as Record<string, any>) || {}) }
+      const subBlocks = {
+        ...((block.subBlocks as Record<string, Record<string, unknown>> | null) || {}),
+      }
       const currentSubBlock = subBlocks[subblockId]
       subBlocks[subblockId] = currentSubBlock
         ? { ...currentSubBlock, value }

apps/sim/lib/workflows/editing/engine.ts

@@ -261,7 +261,10 @@ export function applyOperationsToWorkflowState(
   // blocks that are both being moved into the same subflow in one batch.
   removeInvalidScopeEdges(modifiedState, skippedItems)
 
-  reindexToolCanonicalModesAfterEdits((workflowState as any).blocks, (modifiedState as any).blocks)
+  reindexToolCanonicalModesAfterEdits(
+    workflowState.blocks as Record<string, BlockState> | undefined,
+    modifiedState.blocks as Record<string, BlockState> | undefined
+  )
 
   // Regenerate loops and parallels after modifications
   ;(modifiedState as any).loops = generateLoopBlocks((modifiedState as any).blocks)