Fixes

Author: aritchie

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -20,7 +20,7 @@ body:
         - Azure Relay (Shiny.Net.HttpServer.AzureRelay)
         - MCP (Shiny.Net.HttpServer.Mcp)
         - SSH Tunnel (Shiny.Net.HttpServer.Ssh)
-        - Source Generator (Shiny.Net.HttpServer.SourceGenerators)
+        - Source Generator (typed endpoints, in Shiny.Net.HttpServer)
         - Other
     validations:
       required: true

readme.md

@@ -14,8 +14,7 @@ JWT, OpenAPI, HPACK, QPACK — is built on what is in the box.
 
 | Package | Description |
 | --- | --- |
-| [Shiny.Net.HttpServer](https://www.nuget.org/packages/Shiny.Net.HttpServer) | The server: HTTP/1.1, HTTP/2 & HTTP/3, routing, middleware, DI scopes, static files, WebSockets, SSE, sessions, OpenAPI, CORS, rate limiting, IP filtering, tunnelling |
-| [Shiny.Net.HttpServer.SourceGenerators](https://www.nuget.org/packages/Shiny.Net.HttpServer.SourceGenerators) | Compile-time typed endpoints — route registration, parameter binding, OpenAPI. Zero reflection |
+| [Shiny.Net.HttpServer](https://www.nuget.org/packages/Shiny.Net.HttpServer) | The server: HTTP/1.1, HTTP/2 & HTTP/3, routing, middleware, DI scopes, static files, WebSockets, SSE, sessions, OpenAPI, CORS, rate limiting, IP filtering, tunnelling. Includes the typed-endpoint source generator |
 | [Shiny.Net.HttpServer.Jwt](https://www.nuget.org/packages/Shiny.Net.HttpServer.Jwt) | JWT authentication on in-box crypto — no `Microsoft.IdentityModel` dependency |
 | [Shiny.Net.HttpServer.AzureRelay](https://www.nuget.org/packages/Shiny.Net.HttpServer.AzureRelay) | Azure Relay tunnel provider |
 | [Shiny.Net.HttpServer.Ssh](https://www.nuget.org/packages/Shiny.Net.HttpServer.Ssh) | SSH remote-forwarding tunnel provider, including zero-account quick tunnels |

samples/Sample.Api/Sample.Api.csproj

@@ -15,6 +15,9 @@
         <ProjectReference Include="../../src/Shiny.Net.HttpServer/Shiny.Net.HttpServer.csproj"/>
         <ProjectReference Include="../../src/Shiny.Net.HttpServer.Jwt/Shiny.Net.HttpServer.Jwt.csproj"/>
         <ProjectReference Include="../../src/Shiny.Net.HttpServer.WebDav/Shiny.Net.HttpServer.WebDav.csproj"/>
+        <!-- The endpoint generator reaches a consumer through the Shiny.Net.HttpServer package's
+             analyzers/ folder. Analyzers do not flow across a ProjectReference, so referencing it
+             in-repo takes the explicit route the package does for everyone else. -->
         <ProjectReference Include="../../src/Shiny.Net.HttpServer.SourceGenerators/Shiny.Net.HttpServer.SourceGenerators.csproj"
                           OutputItemType="Analyzer"
                           ReferenceOutputAssembly="false"/>

skills/shiny-httpserver/SKILL.md

@@ -184,8 +184,7 @@ must hold that line, or it fails on a trimmed device build.
 ### Packages
 
 ```bash
-dotnet add package Shiny.Net.HttpServer                  # the server
-dotnet add package Shiny.Net.HttpServer.SourceGenerators # typed endpoints (analyzer)
+dotnet add package Shiny.Net.HttpServer                  # the server + the typed-endpoint generator
 dotnet add package Shiny.Net.HttpServer.Jwt              # JWT auth
 dotnet add package Shiny.Net.HttpServer.Ssh              # SSH + quick tunnels
 dotnet add package Shiny.Net.HttpServer.AzureRelay       # Azure Relay tunnel (NOT AOT-clean)

src/Shiny.Net.HttpServer.SourceGenerators/Shiny.Net.HttpServer.SourceGenerators.csproj

@@ -5,23 +5,23 @@
          which is netstandard2.0, not into the app being compiled. -->
     <TargetFramework>netstandard2.0</TargetFramework>
     <RootNamespace>Shiny.Net.HttpServer.SourceGenerators</RootNamespace>
-    <Description>Source generator for Shiny.Net.HttpServer typed endpoints.</Description>
 
     <IsRoslynComponent>true</IsRoslynComponent>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
     <!-- RS2008 wants AnalyzerReleases.*.md release-tracking files, which only earn their keep for
          an analyzer package with a public support contract. -->
     <NoWarn>$(NoWarn);RS2008</NoWarn>
+
+    <!-- Not a package of its own: Shiny.Net.HttpServer packs this output under analyzers/dotnet/cs.
+         The [Route]/[Get]/[Post] attributes and the generator that reads them are one feature, and
+         shipping them separately only creates a way to reference half of it — a user with the
+         attributes and no generator gets endpoint classes that silently never map. -->
+    <IsPackable>false</IsPackable>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <DevelopmentDependency>true</DevelopmentDependency>
-
-    <!-- The build output ships under analyzers/dotnet/cs, not lib/, which is exactly what NU5128
-         complains about. With no lib/ assembly there is also nothing for a symbol package to carry,
-         and an empty .snupkg is a hard pack error (NU5017) - so the Release symbol/source settings
-         from the root Directory.Build.props are turned back off here. -->
-    <NoWarn>$(NoWarn);NU5128</NoWarn>
     <IncludeSymbols>false</IncludeSymbols>
     <IncludeSource>false</IncludeSource>
+    <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
   </PropertyGroup>
 
   <!-- The trim/AOT analyzers inherited from src/Directory.Build.props do not apply to a
@@ -39,8 +39,4 @@
     <PackageReference Include="PolySharp" PrivateAssets="all" />
   </ItemGroup>
 
-  <ItemGroup>
-    <None Include="$(OutputPath)$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
-  </ItemGroup>
-
 </Project>

src/Shiny.Net.HttpServer/Shiny.Net.HttpServer.csproj

@@ -12,6 +12,24 @@
         <PackageReference Include="Microsoft.Extensions.Primitives"/>
     </ItemGroup>
 
+    <!-- The typed-endpoint generator ships inside this package rather than beside it. The [Route],
+         [Get], [Post] … attributes live here, and the generator is what turns them into a
+         MapXxxEndpoints() call — one feature in one package, so there is no second reference to
+         forget and no way to end up with attributes that silently do nothing. -->
+    <ItemGroup>
+        <ProjectReference Include="../Shiny.Net.HttpServer.SourceGenerators/Shiny.Net.HttpServer.SourceGenerators.csproj"
+                          OutputItemType="Analyzer"
+                          ReferenceOutputAssembly="false"
+                          PrivateAssets="all"/>
+    </ItemGroup>
+
+    <ItemGroup>
+        <None Include="../Shiny.Net.HttpServer.SourceGenerators/bin/$(Configuration)/netstandard2.0/Shiny.Net.HttpServer.SourceGenerators.dll"
+              Pack="true"
+              PackagePath="analyzers/dotnet/cs"
+              Visible="false"/>
+    </ItemGroup>
+
     <ItemGroup>
         <InternalsVisibleTo Include="Shiny.Net.HttpServer.Tests"/>