From 237f53bd0f80dabc609c14ef0355183e3e9047a6 Mon Sep 17 00:00:00 2001 From: G Date: Sun, 23 Aug 2026 20:40:13 +0530 Subject: [PATCH 1/2] refactor: clean up invalid log tags (#426) --- app/src/main/java/be/scri/helpers/KeyboardBase.kt | 3 ++- .../java/be/scri/ui/screens/LanguageSettingsScreen.kt | 8 +++++--- app/src/main/java/be/scri/views/KeyboardView.kt | 4 +++- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/be/scri/helpers/KeyboardBase.kt b/app/src/main/java/be/scri/helpers/KeyboardBase.kt index 4c1ee3df..09acc56f 100644 --- a/app/src/main/java/be/scri/helpers/KeyboardBase.kt +++ b/app/src/main/java/be/scri/helpers/KeyboardBase.kt @@ -75,6 +75,7 @@ class KeyboardBase { * Constants for keyboard layouts and the function to retrieve them. */ companion object { + private const val TAG = "KeyboardBase" private const val TAG_KEYBOARD = "Keyboard" private const val TAG_ROW = "Row" private const val TAG_KEY = "Key" @@ -221,7 +222,7 @@ class KeyboardBase { else -> res.getDimension(R.dimen.conjugate_view_key_height_3x3).toInt() } } else { - Log.i("≠", "The current state is not conjugate view") + Log.i(TAG, "The current state is not conjugate view") when (resources.configuration.orientation) { Configuration.ORIENTATION_LANDSCAPE -> { res.getDimension(R.dimen.key_height_landscape).toInt() diff --git a/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt b/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt index 618e8036..d6e48270 100644 --- a/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt +++ b/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt @@ -24,6 +24,8 @@ import be.scri.ui.common.components.ItemCardContainerWithTitle import be.scri.ui.models.ScribeItem import be.scri.ui.models.ScribeItemList +private const val TAG = "LanguageSettingsScreen" + /** * Data class to hold functionality settings state and callbacks */ @@ -387,7 +389,7 @@ private fun getLayoutListData( title = R.string.i18n_app_settings_keyboard_layout_default_layout, desc = R.string.i18n_app_settings_keyboard_layout_default_layout_description, action = { - Log.d("Navigation", "onDefaultLayoutSelect clicked") + Log.d(TAG, "onDefaultLayoutSelect clicked") onDefaultLayoutSelect() }, ), @@ -398,7 +400,7 @@ private fun getLayoutListData( title = R.string.i18n_app_settings_keyboard_layout_default_currency, desc = R.string.i18n_app_settings_keyboard_layout_default_currency_description, action = { - Log.d("Navigation", "onCurrencySelect clicked") + Log.d(TAG, "onCurrencySelect clicked") onCurrencySelect() }, ), @@ -470,7 +472,7 @@ private fun getTranslationSourceLanguageListData(onTranslationLanguageSelect: () title = R.string.i18n_app_settings_keyboard_translation_select_source, desc = R.string.i18n_app_settings_keyboard_translation_select_source_description, action = { - Log.d("Navigation", "onTranslationLanguageSelect clicked") + Log.d(TAG, "onTranslationLanguageSelect clicked") onTranslationLanguageSelect() }, ), diff --git a/app/src/main/java/be/scri/views/KeyboardView.kt b/app/src/main/java/be/scri/views/KeyboardView.kt index 3bd08f38..7ec909a3 100644 --- a/app/src/main/java/be/scri/views/KeyboardView.kt +++ b/app/src/main/java/be/scri/views/KeyboardView.kt @@ -72,6 +72,8 @@ import be.scri.models.ScribeState import java.util.Arrays import java.util.Locale +private const val TAG = "SoundCheck" + /** * The base keyboard view for Scribe language keyboards application. */ @@ -685,7 +687,7 @@ class KeyboardView } fun soundIfNeeded() { - Log.d("Souncheck", "soundIfNeeded: $setSound") + Log.d(TAG, "soundIfNeeded: $setSound") if (setSound) { performSoundFeedback() } From d5a2cc44c34378e46907b3f2b5f10c32202cdaea Mon Sep 17 00:00:00 2001 From: G Date: Mon, 31 Aug 2026 08:24:59 +0530 Subject: [PATCH 2/2] refactor: remove low-value debug logs, correct log levels per maintainer feedback (#426) --- app/src/keyboards/java/be/scri/helpers/KeyHandler.kt | 2 +- app/src/main/java/be/scri/helpers/KeyboardBase.kt | 2 -- .../main/java/be/scri/helpers/data/ContractDataLoader.kt | 2 +- .../main/java/be/scri/ui/screens/LanguageSettingsScreen.kt | 6 ------ app/src/main/java/be/scri/views/KeyboardView.kt | 4 ---- 5 files changed, 2 insertions(+), 14 deletions(-) diff --git a/app/src/keyboards/java/be/scri/helpers/KeyHandler.kt b/app/src/keyboards/java/be/scri/helpers/KeyHandler.kt index 25663f03..f723d6f4 100644 --- a/app/src/keyboards/java/be/scri/helpers/KeyHandler.kt +++ b/app/src/keyboards/java/be/scri/helpers/KeyHandler.kt @@ -329,7 +329,7 @@ class KeyHandler( editor.apply() ime.updateUI() - Log.i(TAG, "New conjugate_index: $currentValue") + Log.d(TAG, "New conjugate_index: $currentValue") } /** diff --git a/app/src/main/java/be/scri/helpers/KeyboardBase.kt b/app/src/main/java/be/scri/helpers/KeyboardBase.kt index 09acc56f..9704e93f 100644 --- a/app/src/main/java/be/scri/helpers/KeyboardBase.kt +++ b/app/src/main/java/be/scri/helpers/KeyboardBase.kt @@ -75,7 +75,6 @@ class KeyboardBase { * Constants for keyboard layouts and the function to retrieve them. */ companion object { - private const val TAG = "KeyboardBase" private const val TAG_KEYBOARD = "Keyboard" private const val TAG_ROW = "Row" private const val TAG_KEY = "Key" @@ -222,7 +221,6 @@ class KeyboardBase { else -> res.getDimension(R.dimen.conjugate_view_key_height_3x3).toInt() } } else { - Log.i(TAG, "The current state is not conjugate view") when (resources.configuration.orientation) { Configuration.ORIENTATION_LANDSCAPE -> { res.getDimension(R.dimen.key_height_landscape).toInt() diff --git a/app/src/main/java/be/scri/helpers/data/ContractDataLoader.kt b/app/src/main/java/be/scri/helpers/data/ContractDataLoader.kt index 9f6e3886..31c5945c 100644 --- a/app/src/main/java/be/scri/helpers/data/ContractDataLoader.kt +++ b/app/src/main/java/be/scri/helpers/data/ContractDataLoader.kt @@ -27,7 +27,7 @@ class ContractDataLoader( */ fun loadContract(language: String): DataContract? { val contractName = "${language.lowercase()}.yaml" - Log.i("ContractDataLoader", "Attempting to load contract: $contractName") + Log.d("ContractDataLoader", "Attempting to load contract: $contractName") return try { context.assets.open("data-contracts/$contractName").use { contractFile -> diff --git a/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt b/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt index d6e48270..dff4031f 100644 --- a/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt +++ b/app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt @@ -3,7 +3,6 @@ package be.scri.ui.screens import android.annotation.SuppressLint -import android.util.Log import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.height @@ -24,8 +23,6 @@ import be.scri.ui.common.components.ItemCardContainerWithTitle import be.scri.ui.models.ScribeItem import be.scri.ui.models.ScribeItemList -private const val TAG = "LanguageSettingsScreen" - /** * Data class to hold functionality settings state and callbacks */ @@ -389,7 +386,6 @@ private fun getLayoutListData( title = R.string.i18n_app_settings_keyboard_layout_default_layout, desc = R.string.i18n_app_settings_keyboard_layout_default_layout_description, action = { - Log.d(TAG, "onDefaultLayoutSelect clicked") onDefaultLayoutSelect() }, ), @@ -400,7 +396,6 @@ private fun getLayoutListData( title = R.string.i18n_app_settings_keyboard_layout_default_currency, desc = R.string.i18n_app_settings_keyboard_layout_default_currency_description, action = { - Log.d(TAG, "onCurrencySelect clicked") onCurrencySelect() }, ), @@ -472,7 +467,6 @@ private fun getTranslationSourceLanguageListData(onTranslationLanguageSelect: () title = R.string.i18n_app_settings_keyboard_translation_select_source, desc = R.string.i18n_app_settings_keyboard_translation_select_source_description, action = { - Log.d(TAG, "onTranslationLanguageSelect clicked") onTranslationLanguageSelect() }, ), diff --git a/app/src/main/java/be/scri/views/KeyboardView.kt b/app/src/main/java/be/scri/views/KeyboardView.kt index 7ec909a3..b2cdaa57 100644 --- a/app/src/main/java/be/scri/views/KeyboardView.kt +++ b/app/src/main/java/be/scri/views/KeyboardView.kt @@ -20,7 +20,6 @@ import android.os.Handler import android.os.Looper import android.os.Message import android.util.AttributeSet -import android.util.Log import android.util.TypedValue import android.view.Gravity import android.view.LayoutInflater @@ -72,8 +71,6 @@ import be.scri.models.ScribeState import java.util.Arrays import java.util.Locale -private const val TAG = "SoundCheck" - /** * The base keyboard view for Scribe language keyboards application. */ @@ -687,7 +684,6 @@ class KeyboardView } fun soundIfNeeded() { - Log.d(TAG, "soundIfNeeded: $setSound") if (setSound) { performSoundFeedback() }