From afccabbda35beb0e7ae790879dcb78bc27191e24 Mon Sep 17 00:00:00 2001
From: ppjsw <123859511+ppjsw@users.noreply.github.com>
Date: Sat, 10 Oct 2026 01:10:26 +0800
Subject: [PATCH] Fix /settings/update clobbering subscriptions and filters
 cookies

set_cookies_method(req, false) means "only touch preferences named in the
query string", and the PREFS loop honours that via the remove_cookies flag.
The subscriptions and filters else-branches did not, so any /settings/update
request (e.g. the "Enable HLS" link, ?use_hls=on) emitted deletion cookies
for subscriptions and filters and silently wiped the user's lists.

Gate both else branches on remove_cookies. /settings/restore still passes
true and keeps clearing absent cookies; POST /settings is a separate handler
and is unchanged.

Fixes #562
---
 src/settings.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/settings.rs b/src/settings.rs
index 84cd41a5..8b27c27e 100644
--- a/src/settings.rs
+++ b/src/settings.rs
@@ -192,7 +192,7 @@ fn set_cookies_method(req: Request<Body>, remove_cookies: bool) -> Response<Body
 			// Increment subscriptions cookie number
 			subscriptions_number_to_delete_from += 1;
 		}
-	} else {
+	} else if remove_cookies {
 		// Remove unnumbered subscriptions cookie
 		response.remove_cookie("subscriptions".to_string());
 
@@ -243,7 +243,7 @@ fn set_cookies_method(req: Request<Body>, remove_cookies: bool) -> Response<Body
 			// Increment filters cookie number
 			filters_number_to_delete_from += 1;
 		}
-	} else {
+	} else if remove_cookies {
 		// Remove unnumbered filters cookie
 		response.remove_cookie("filters".to_string());