From 1ba86e6fe7e0f97dc47966f1d818188bb2e878eb Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Fri, 20 Nov 2026 19:50:37 +0000 Subject: [PATCH] Use cloneChildIfNeeded for Yoga child cloning --- .../ReactCommon/yoga/yoga/node/Node.cpp | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/packages/react-native/ReactCommon/yoga/yoga/node/Node.cpp b/packages/react-native/ReactCommon/yoga/yoga/node/Node.cpp index 3ed017ce8aeb..885e73b9f884 100644 --- a/packages/react-native/ReactCommon/yoga/yoga/node/Node.cpp +++ b/packages/react-native/ReactCommon/yoga/yoga/node/Node.cpp @@ -418,26 +418,11 @@ void Node::clearChildren() { // Other Methods void Node::cloneChildrenIfNeeded() { - size_t i = 0; - for (Node*& child : children_) { - if (child->getOwner() != this) { - child = resolveRef(config_->cloneNode(child, this, i)); - child->setOwner(this); - - if (child->style().display() == Display::Contents) [[unlikely]] { - // The contents node's children are treated as children of the - // contents node's parent for layout purposes, so they need - // to be cloned as well. - child->cloneChildrenIfNeeded(); - } else if (child->hasContentsChildren()) [[unlikely]] { - child->cloneContentsChildrenIfNeeded(); - } - } - i += 1; + for (size_t i = 0; i < children_.size(); i++) { + cloneChildIfNeeded(i); } } -// cloneChildrenIfNeeded keeps its own copy: every layout runs it per child. void Node::cloneChildIfNeeded(size_t index) { Node*& child = children_[index]; if (child->getOwner() == this) {