From cf8cfc61de86cbbd64be7c26f504563b766bbc03 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Tue, 29 Sep 2026 06:13:52 -0700 Subject: [PATCH] Use module umbrella headers in react/renderer/animations (#58728) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58728 Headers in `react/renderer/animations` included fine-grained public headers from other modules that are protected by `UmbrellaGuard.h`, which hard-errors under `RN_STRICT_API` unless included through the module umbrella. Switch these includes to the corresponding umbrellas: - `react/renderer/core/ReactPrimitives.h` -> `React/RendererCore.h` - `react/renderer/core/RawValue.h` -> `React/RawValue.h` - `react/renderer/debug/flags.h` -> `React/RendererDebug.h` - `react/renderer/graphics/Float.h` -> `React/Graphics.h` - `ReactCommon/RuntimeExecutor.h` -> `React/RuntimeExecutor.h` For-frameworks headers (`mounting`, `uimanager`) have no umbrella and are left as-is. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D122311313 --- .../react/renderer/animations/LayoutAnimationDriver.h | 2 +- .../renderer/animations/LayoutAnimationKeyFrameManager.h | 6 +++--- .../ReactCommon/react/renderer/animations/primitives.h | 4 ++-- .../ReactCommon/react/renderer/animations/utils.h | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h index 9fb2f666201c..63e7ad9ddfa2 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h @@ -9,8 +9,8 @@ #include +#include #include -#include #include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h index 9edf8e713019..54a78ef0dc20 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h @@ -9,11 +9,11 @@ #include -#include +#include +#include +#include #include #include -#include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/primitives.h b/packages/react-native/ReactCommon/react/renderer/animations/primitives.h index 289bc634e4ed..57fbd807068b 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/primitives.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/primitives.h @@ -9,9 +9,9 @@ #include +#include +#include #include -#include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/utils.h b/packages/react-native/ReactCommon/react/renderer/animations/utils.h index 9f1bb4d8349a..4302910e932e 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/utils.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/utils.h @@ -9,8 +9,8 @@ #include +#include #include -#include #include namespace facebook::react {