Remove hasTVPreferredFocus (#58700)

Summary:
Pull Request resolved: #58700

Remove the deprecated `hasTVPreferredFocus` prop from the core `View`, `Button`, and Touchable APIs and from Android native prop registration and Fabric. Persistent focus eligibility remains available through `focusable`, while imperative focus requests are available through `focus()`.

Keep a deprecated no-op `ReactViewManager.setTVPreferredFocus` method solely for binary compatibility with independently compiled `ViewManager` subclasses; it no longer registers a React prop or changes focus.

Changelog:
[General][Removed] - Remove the deprecated `hasTVPreferredFocus` prop

Reviewed By: andrewdacenko

Differential Revision: D122080657

fbshipit-source-id: f7fc8b978e5e8c1234ad9bf4c05cba8270fc0558

Author: Abbondanzo

packages/react-native/Libraries/Components/Button.js

@@ -56,16 +56,6 @@ type ButtonPropsCore = Readonly<{
    */
   color?: ?ColorValue,
 
-  /**
-   * TV preferred focus.
-   *
-   * @platform tv
-   *
-   * @default `false`
-   * @deprecated Use `focusable` instead
-   */
-  hasTVPreferredFocus?: ?boolean,
-
   /**
    * Designates the next view to receive focus when the user navigates down. See
    * the [Android documentation][android:nextFocusDown].
@@ -219,7 +209,6 @@ const Button: component(
     onPress,
     touchSoundDisabled,
     title,
-    hasTVPreferredFocus,
     nextFocusDown,
     nextFocusForward,
     nextFocusLeft,
@@ -290,7 +279,6 @@ const Button: component(
       accessibilityRole="button"
       accessibilityState={_accessibilityState}
       importantForAccessibility={_importantForAccessibility}
-      hasTVPreferredFocus={hasTVPreferredFocus}
       nextFocusDown={nextFocusDown}
       nextFocusForward={nextFocusForward}
       nextFocusLeft={nextFocusLeft}

packages/react-native/Libraries/Components/Touchable/TouchableHighlight.js

@@ -34,13 +34,6 @@ type AndroidProps = Readonly<{
   nextFocusUp?: ?number,
 }>;
 
-type IOSProps = Readonly<{
-  /**
-   * @deprecated Use `focusable` instead
-   */
-  hasTVPreferredFocus?: ?boolean,
-}>;
-
 type TouchableHighlightBaseProps = Readonly<{
   /**
    * Opacity of the wrapped view when touch is active. Requires `underlayColor` to be set.
@@ -75,7 +68,6 @@ type TouchableHighlightBaseProps = Readonly<{
 export type TouchableHighlightProps = Readonly<{
   ...TouchableWithoutFeedbackProps,
   ...AndroidProps,
-  ...IOSProps,
   ...TouchableHighlightBaseProps,
 }>;
 
@@ -281,7 +273,6 @@ class TouchableHighlightImpl extends React.Component<
         )}
         onLayout={this.props.onLayout}
         hitSlop={this.props.hitSlop}
-        hasTVPreferredFocus={this.props.hasTVPreferredFocus}
         nextFocusDown={this.props.nextFocusDown}
         nextFocusForward={this.props.nextFocusForward}
         nextFocusLeft={this.props.nextFocusLeft}

packages/react-native/Libraries/Components/Touchable/TouchableNativeFeedback.js

@@ -26,14 +26,6 @@ import * as React from 'react';
 import {cloneElement} from 'react';
 
 type TouchableNativeFeedbackTVProps = {
-  /**
-   * *(Apple TV only)* TV preferred focus (see documentation for the View component).
-   *
-   * @platform ios
-   * @deprecated Use `focusable` instead
-   */
-  hasTVPreferredFocus?: ?boolean,
-
   /**
    * Designates the next view to receive focus when the user navigates down. See the Android documentation.
    *
@@ -345,7 +337,6 @@ class TouchableNativeFeedback extends React.Component<
         accessibilityLiveRegion: accessibilityLiveRegion,
         accessibilityElementsHidden:
           this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden,
-        hasTVPreferredFocus: this.props.hasTVPreferredFocus,
         hitSlop: this.props.hitSlop,
         focusable:
           this.props.focusable !== false &&

packages/react-native/Libraries/Components/Touchable/TouchableOpacity.js

@@ -25,14 +25,6 @@ import * as React from 'react';
 export type TouchableOpacityInstance = HostInstance;
 
 export type TouchableOpacityTVProps = Readonly<{
-  /**
-   * *(Apple TV only)* TV preferred focus (see documentation for the View component).
-   *
-   * @platform ios
-   * @deprecated Use `focusable` instead
-   */
-  hasTVPreferredFocus?: ?boolean,
-
   /**
    * Designates the next view to receive focus when the user navigates down. See the Android documentation.
    *
@@ -261,7 +253,6 @@ class TouchableOpacity extends React.Component<
         nextFocusLeft={this.props.nextFocusLeft}
         nextFocusRight={this.props.nextFocusRight}
         nextFocusUp={this.props.nextFocusUp}
-        hasTVPreferredFocus={this.props.hasTVPreferredFocus}
         hitSlop={this.props.hitSlop}
         focusable={
           this.props.focusable !== false &&

packages/react-native/Libraries/Components/View/ViewPropTypes.js

@@ -305,14 +305,6 @@ export type ViewPropsAndroid = Readonly<{
    */
   renderToHardwareTextureAndroid?: ?boolean,
 
-  /**
-   * Whether to force the Android TV focus engine to move focus to this view.
-   *
-   * @platform android
-   * @deprecated Use `focusable` instead
-   */
-  hasTVPreferredFocus?: ?boolean,
-
   /**
    * Designates the next view to receive focus when the user navigates down.
    * The value is the `nativeID` of the target view.
@@ -390,14 +382,6 @@ export type TVViewPropsIOS = Readonly<{
    */
   isTVSelectable?: boolean,
 
-  /**
-   * *(Apple TV only)* May be set to true to force the Apple TV focus engine to move focus to this view.
-   *
-   * @platform ios
-   * @deprecated Use `focusable` instead
-   */
-  hasTVPreferredFocus?: boolean,
-
   /**
    * *(Apple TV only)* May be used to change the appearance of the Apple TV parallax effect when this view goes in or out of focus.  Defaults to 2.0.
    *

packages/react-native/Libraries/Components/View/__tests__/View-benchmark-itest.js

@@ -53,7 +53,6 @@ function createViewsWithLargeAmountOfPropsAndStyles(count: number): React.Node {
         aria-live={'polite'}
         collapsable={false}
         focusable={i % 2 === 0}
-        hasTVPreferredFocus={i % 2 === 0}
         id={String(i)}
         importantForAccessibility={'no-hide-descendants'}
         nativeID={String(i)}

packages/react-native/Libraries/Components/View/__tests__/ViewProps-benchmark-itest.js

@@ -36,7 +36,6 @@ function buildViewsWithFullPropBag(
         aria-live="polite"
         collapsable={false}
         focusable={i % 2 === 0}
-        hasTVPreferredFocus={i % 2 === 0}
         id={String(i)}
         importantForAccessibility="no-hide-descendants"
         nativeID={String(i)}

packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js

@@ -360,7 +360,6 @@ const validAttributesForNonEventProps = {
 
   // ReactViewManager @ReactProps
   accessible: true,
-  hasTVPreferredFocus: true,
   nextFocusDown: true,
   nextFocusForward: true,
   nextFocusLeft: true,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.kt

@@ -124,14 +124,16 @@ public open class ReactViewManager : ReactClippingViewManager<ReactViewGroup>()
     view.axOrderList = axOrderList
   }
 
-  @ReactProp(name = "hasTVPreferredFocus")
-  public open fun setTVPreferredFocus(view: ReactViewGroup, hasTVPreferredFocus: Boolean) {
-    if (hasTVPreferredFocus) {
-      view.isFocusable = true
-      view.isFocusableInTouchMode = true
-      view.requestFocus()
-    }
-  }
+  /**
+   * Retained for binary compatibility with [ReactViewManager] subclasses.
+   *
+   * This method no longer registers a React prop or changes view focus.
+   */
+  @Deprecated("Use focusable or focus() instead")
+  public open fun setTVPreferredFocus(
+      view: ReactViewGroup,
+      hasTVPreferredFocus: Boolean,
+  ): Unit = Unit
 
   @ReactProp(name = ViewProps.BACKGROUND_IMAGE, customType = "BackgroundImage")
   public open fun setBackgroundImage(view: ReactViewGroup, backgroundImage: ReadableArray?) {

packages/react-native/ReactAndroid/src/main/jni/react/fabric/FocusOrderingHelper.cpp

@@ -207,8 +207,7 @@ void FocusOrderingHelper::traverseAndUpdateNextFocusableElement(
   // We only care about focusable elements since only they can be both
   // focused and present in the hierarchy
   if (currNode->getTraits().check(ShadowNodeTraits::Trait::KeyboardFocusable) ||
-      (props != nullptr &&
-       (props->focusable || props->accessible || props->hasTVPreferredFocus))) {
+      (props != nullptr && (props->focusable || props->accessible))) {
     LayoutMetrics nodeLayoutMetrics = uimanager.getRelativeLayoutMetrics(
         *currNode, parentShadowNode.get(), {.includeTransform = true});