From fb47e30e843c30893f3b4c573698d2270329c69e Mon Sep 17 00:00:00 2001 From: baku-ccron Date: Thu, 27 Aug 2026 04:06:19 +0000 Subject: [PATCH] Drop the "this repo has released none" comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both said the chain group has no subject and passes vacuously. It has one: `src/generated/0_1_7/` is frozen and the released libs declare `address-registry@0_1_7` and `migration-registry@0_1_7`. Correcting them to name 0_1_7 re-arms the same trap, since the next release falsifies it again and nothing expires a comment. Whether `releasedSuites()` is empty is a fact about a return value, readable at that function; what `RegistryDeployChainTest` covers belongs in its own doc rather than restated at the call site. The README keeps the durable half of step 2 — the chain test passes only once every released suite is live on every supported network, with the code that release froze — and the ordering rationale it needs is already in step 3. Closes #153 Co-Authored-By: Claude Opus 5 (1M context) --- README.md | 3 --- script/Deploy.sol | 6 ------ 2 files changed, 9 deletions(-) diff --git a/README.md b/README.md index 4ecabaa..0bda79c 100644 --- a/README.md +++ b/README.md @@ -390,9 +390,6 @@ Three separate steps, in this order. Nothing automatic ever broadcasts. partial run is fixed by running it again rather than by unpicking anything. 2. **Verify.** `RegistryDeployChainTest` passes only once every **released** suite is live on every supported network, with the code that release froze. - This repo has released none, so today it has nothing to check and passes; it - gets a subject the moment step 3 freezes one, and is red from then until step - 1 has been run everywhere. That is the order these steps are in. 3. **Tag.** Push a `sol-v*` tag, the sole release trigger. It verifies and publishes but never broadcasts, which is exactly why step 1 cannot be folded into it. The release mechanics are `rainix-tag-release`'s. diff --git a/script/Deploy.sol b/script/Deploy.sol index 9345fd7..0586759 100644 --- a/script/Deploy.sol +++ b/script/Deploy.sol @@ -27,10 +27,4 @@ import {RegistryDeploySuites} from "../src/abstract/RegistryDeploySuites.sol"; /// skips any network that already has code there, so a partial run — five /// chains of seven, one RPC down — is fixed by running it again rather than by /// unpicking anything. -/// -/// `RegistryDeployChainTest` is what says whether this has been run and worked -/// — but only for RELEASED suites, and this repo has released none, so today it -/// has nothing to check and passes. It gets a subject once a release is frozen, -/// and then fails until every supported network has that release's code, which -/// is why the deploy comes before the tag rather than after it. contract Deploy is RegistryDeploySuites, RainDeployBroadcast {}