Skip to content

Commit 47f27cd

Browse files
clementperonmiss-islington
authored andcommitted
gh-156115: Use the simulator deployment-target flag for iOS simulator builds (GH-156116)
Ensures that CFLAGS and LDFLAGS use -mios-simulator-version-min, rather than the device-based -mios-version-min. This only matters if the CFLAGS and LDFLAGS are used in a bare call to clang without a -target; but that is a legal usage, so it's worth catching. (cherry picked from commit d856402) Co-authored-by: Clément Péron <peron.clem@gmail.com>
1 parent f71fbc5 commit 47f27cd

3 files changed

Lines changed: 17 additions & 4 deletions

File tree

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
iOS simulator builds are now configured with
2+
``-mios-simulator-version-min`` instead of the device's
3+
``-mios-version-min``. The device flag made the linker reject libraries
4+
resolved from the simulator SDK, so library detection silently failed.

configure

Lines changed: 7 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

configure.ac

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -995,8 +995,12 @@ AS_CASE([$host],
995995
)
996996

997997
dnl Add the compiler flag for the iOS minimum supported OS version.
998-
AS_CASE([$ac_sys_system],
999-
[iOS], [
998+
AS_CASE([$host],
999+
[*-apple-ios*-simulator], [
1000+
AS_VAR_APPEND([CFLAGS], [" -mios-simulator-version-min=${IPHONEOS_DEPLOYMENT_TARGET}"])
1001+
AS_VAR_APPEND([LDFLAGS], [" -mios-simulator-version-min=${IPHONEOS_DEPLOYMENT_TARGET}"])
1002+
],
1003+
[*-apple-ios*], [
10001004
AS_VAR_APPEND([CFLAGS], [" -mios-version-min=${IPHONEOS_DEPLOYMENT_TARGET}"])
10011005
AS_VAR_APPEND([LDFLAGS], [" -mios-version-min=${IPHONEOS_DEPLOYMENT_TARGET}"])
10021006
],

0 commit comments

Comments
 (0)