Skip to content

Commit 09ad219

Browse files
committed
Address review
1 parent 90eb612 commit 09ad219

2 files changed

Lines changed: 21 additions & 5 deletions

File tree

‎Lib/test/test_tcl.py‎

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -602,10 +602,28 @@ class StrRaises:
602602
def __str__(self):
603603
raise RuntimeError("setvar evil")
604604

605-
setvar = self.interp.tk.setvar
606605
default = StrRaises()
607-
with self.assertRaisesRegex(RuntimeError, "setvar evil"):
608-
setvar("name1", "name2", default)
606+
607+
for getvar, setvar, unsetvar in [
608+
(
609+
self.interp.tk.getvar,
610+
self.interp.tk.setvar,
611+
self.interp.tk.unsetvar,
612+
),
613+
(
614+
self.interp.tk.globalgetvar,
615+
self.interp.tk.globalsetvar,
616+
self.interp.tk.globalunsetvar,
617+
)
618+
]:
619+
with self.subTest(getvar=getvar, setvar=setvar, unsetvar=unsetvar):
620+
with self.assertRaisesRegex(RuntimeError, "setvar evil"):
621+
setvar("name1", "name2", default)
622+
623+
self.assertRaises(TclError, getvar, "name1")
624+
self.assertIsNone(setvar("name1", "name2"))
625+
self.assertEqual(getvar("name1"), "name2")
626+
self.assertIsNone(unsetvar("name1"))
609627

610628
def test_user_command(self):
611629
result = None

‎Misc/NEWS.d/next/Library/2026-11-05-12-29-04.gh-issue-161388.s7ECT8.rst‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)