Fix /makeimage/ returning None after the merge

Author: StanFromIreland

codespeed/tests/test_views.py

@@ -420,6 +420,18 @@ def test_timeline(self):
         responsedata = response.content.decode()
         self.assertIn('My Own Title\n: Timeline', responsedata)
 
+    def test_makeimage(self):
+        response = self.client.get(reverse('makeimage'), {
+            'env': 'Dual Core', 'proj': 'MyProject', 'branch': 'master',
+            'exe': 'myexe O3 64bits', 'ben': 'float'})
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response['Content-Type'], 'image/png')
+        self.assertTrue(response.content.startswith(b'\x89PNG'))
+
+    def test_makeimage_bad_request(self):
+        response = self.client.get(reverse('makeimage'), {'env': 'Dual Core'})
+        self.assertEqual(response.status_code, 400)
+
     def test_gettimelinedata(self):
         """Test that gettimelinedata returns correct timeline data
         """

codespeed/views.py

@@ -1178,6 +1178,8 @@ def makeimage(request):
     response['Content-Length'] = len(image_data)
     response['Content-Disposition'] = 'attachment; filename=image.png'
 
+    return response
+
 
 def _get_current_commit():
     try:
@@ -1195,5 +1197,3 @@ def _get_current_commit():
 
 def about(request):
     return render(request, 'about.html', {'commit': _CURRENT_COMMIT})
-
-    return response