From eff1075a4030d26155b4c4aed429233cad801bc7 Mon Sep 17 00:00:00 2001 From: joshblack <3901764+joshblack@users.noreply.github.com> Date: Tue, 17 Nov 2026 21:46:24 +0000 Subject: [PATCH 1/2] Initial plan From d2e27e040af72e200376fbb0f380af1a2b02f3d5 Mon Sep 17 00:00:00 2001 From: joshblack <3901764+joshblack@users.noreply.github.com> Date: Tue, 17 Nov 2026 21:56:20 +0000 Subject: [PATCH 2/2] fix: ignore nested details toggle events Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> --- .changeset/nested-details-toggle.md | 5 +++++ .../src/Details/__tests__/Details.test.tsx | 21 +++++++++++++++++++ packages/react/src/hooks/useDetails.tsx | 8 ++++--- 3 files changed, 31 insertions(+), 3 deletions(-) create mode 100644 .changeset/nested-details-toggle.md diff --git a/.changeset/nested-details-toggle.md b/.changeset/nested-details-toggle.md new file mode 100644 index 00000000000..970a755009e --- /dev/null +++ b/.changeset/nested-details-toggle.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Details: Keep the outer disclosure state unchanged when a nested disclosure is toggled. diff --git a/packages/react/src/Details/__tests__/Details.test.tsx b/packages/react/src/Details/__tests__/Details.test.tsx index 939d4e4b1b5..030dfe036fa 100644 --- a/packages/react/src/Details/__tests__/Details.test.tsx +++ b/packages/react/src/Details/__tests__/Details.test.tsx @@ -93,6 +93,27 @@ describe('Details', () => { await expect.element(page.getByTestId('summary')).toHaveTextContent('Open') }) + it('does not synchronize the outer open state with a nested toggle', async () => { + const Component = () => { + const {getDetailsProps} = useDetails({defaultOpen: true}) + return ( +
+ Outer summary +
+ Inner summary +
+
+ ) + } + + render() + + await userEvent.click(page.getByText('Inner summary', {exact: true})) + + await expect.element(page.getByTestId('inner-details')).not.toHaveAttribute('open') + await expect.element(page.getByTestId('outer-details')).toHaveAttribute('open') + }) + describe('Details.Summary', () => { it('should support a custom `className` on the container element', async () => { render(test summary) diff --git a/packages/react/src/hooks/useDetails.tsx b/packages/react/src/hooks/useDetails.tsx index 37dfc94af56..46b52299057 100644 --- a/packages/react/src/hooks/useDetails.tsx +++ b/packages/react/src/hooks/useDetails.tsx @@ -39,10 +39,12 @@ function useDetails({ref, closeOnOutsideClick, defaultOpen, onClickOutside}: Use }, [open, closeOnOutsideClick, onClickOutsideInternal]) const handleToggle = (e: React.SyntheticEvent) => { - if (!e.defaultPrevented) { - const eventTarget = e.target as HTMLDetailsElement - setOpen(eventTarget.open) + if (e.target !== e.currentTarget || e.defaultPrevented) { + return } + + const eventTarget = e.currentTarget as HTMLDetailsElement + setOpen(eventTarget.open) } const getDetailsProps = () => {