From 79231a3e9e2dfb3635f7678b35bc149ba017fb92 Mon Sep 17 00:00:00 2001 From: vivanvv <117269843+vivanvv@users.noreply.github.com> Date: Sat, 7 Nov 2026 13:15:39 +0000 Subject: [PATCH] Fix breadcrumb indentation in RTL layouts --- .changeset/fix-breadcrumbs-rtl-padding.md | 5 +++++ .../src/Breadcrumbs/Breadcrumbs.module.css | 2 +- .../__tests__/Breadcrumbs.test.tsx | 19 +++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 .changeset/fix-breadcrumbs-rtl-padding.md diff --git a/.changeset/fix-breadcrumbs-rtl-padding.md b/.changeset/fix-breadcrumbs-rtl-padding.md new file mode 100644 index 00000000000..8b83dfcb4a6 --- /dev/null +++ b/.changeset/fix-breadcrumbs-rtl-padding.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Breadcrumbs: Remove the default list indentation in right-to-left layouts. diff --git a/packages/react/src/Breadcrumbs/Breadcrumbs.module.css b/packages/react/src/Breadcrumbs/Breadcrumbs.module.css index 7f0a0e49277..9662b8c7b4f 100644 --- a/packages/react/src/Breadcrumbs/Breadcrumbs.module.css +++ b/packages/react/src/Breadcrumbs/Breadcrumbs.module.css @@ -5,7 +5,7 @@ } .BreadcrumbsList { - padding-left: 0; + padding-inline-start: 0; margin-top: 0; margin-bottom: 0; } diff --git a/packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx b/packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx index 3f3c3e07c45..d3d2a4c2937 100644 --- a/packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx +++ b/packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx @@ -35,6 +35,25 @@ describe('Breadcrumbs', () => { expect(page.getByRole('navigation').element().nodeName).toEqual('NAV') }) + it.each(['ltr', 'rtl'] as const)('aligns the first crumb with the %s inline start edge', direction => { + HTMLRender( +
+ + Home + + Docs + + +
, + ) + + const navigation = page.getByRole('navigation').element().getBoundingClientRect() + const firstCrumb = page.getByRole('link', {name: 'Home', exact: true}).element().getBoundingClientRect() + const startEdge = direction === 'rtl' ? 'right' : 'left' + + expect(firstCrumb[startEdge]).toBeCloseTo(navigation[startEdge], 1) + }) + it('renders data-component attributes', async () => { const {container} = renderWithTheme(