From ab8e73bd9718405410281a75c254a59fbb68a217 Mon Sep 17 00:00:00 2001 From: AdamMagued Date: Tue, 29 Sep 2026 06:21:34 +0300 Subject: [PATCH 1/2] fix(Tooltip): support callback refs on Tooltip trigger --- .changeset/fix-tooltip-callback-ref.md | 5 +++++ .../src/TooltipV2/__tests__/Tooltip.test.tsx | 19 ++++++++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 .changeset/fix-tooltip-callback-ref.md diff --git a/.changeset/fix-tooltip-callback-ref.md b/.changeset/fix-tooltip-callback-ref.md new file mode 100644 index 00000000000..896dcc6795c --- /dev/null +++ b/.changeset/fix-tooltip-callback-ref.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Tooltip: Support callback refs on Tooltip trigger diff --git a/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx b/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx index b543c0c3d3d..0844f5e1866 100644 --- a/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx +++ b/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx @@ -3,7 +3,7 @@ import {describe, expect, it, vi} from 'vitest' import {page, userEvent} from 'vitest/browser' import type {TooltipProps} from '../Tooltip' import {Tooltip} from '../Tooltip' -import {act, fireEvent, render as HTMLRender} from '@testing-library/react' +import {act, fireEvent, render as HTMLRender, waitFor} from '@testing-library/react' import BaseStyles from '../../BaseStyles' import {Button, IconButton} from '../../Button' import {ActionMenu} from '../../ActionMenu' @@ -422,6 +422,23 @@ describe('Tooltip forwarded ref', () => { expect(refCallback).toHaveBeenCalledWith(button.element()) }) + it('calls a callback ref with the trigger element and opens the tooltip as expected', async () => { + const refCallback = vi.fn() + const {getByRole, getByText} = HTMLRender( + + + , + ) + const button = getByRole('button') + const tooltip = getByText('Tooltip text') + + expect(refCallback).toHaveBeenCalledWith(button) + expect(tooltip.matches(':popover-open')).toBe(false) + + fireEvent.mouseOver(button) + await waitFor(() => expect(tooltip.matches(':popover-open')).toBe(true)) + }) + it("preserves trigger element's own ref", () => { const buttonRefCallback = vi.fn() From 0923cbe83ab2c69770382ccf6851a0548d882cb7 Mon Sep 17 00:00:00 2001 From: AdamMagued Date: Tue, 29 Sep 2026 12:12:27 +0300 Subject: [PATCH 2/2] test(Tooltip): add test verifying callback ref with side effect --- .../src/TooltipV2/__tests__/Tooltip.test.tsx | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx b/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx index 0844f5e1866..59000a9286b 100644 --- a/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx +++ b/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx @@ -439,6 +439,28 @@ describe('Tooltip forwarded ref', () => { await waitFor(() => expect(tooltip.matches(':popover-open')).toBe(true)) }) + it('supports callback ref with side effects without interfering with tooltip trigger', async () => { + let sideEffectExecuted = false + const callbackRefWithSideEffect = (node: HTMLButtonElement | null) => { + if (node) { + sideEffectExecuted = true + } + } + + const {getByRole, getByText} = HTMLRender( + + + , + ) + const button = getByRole('button') + const tooltip = getByText('Tooltip text') + + expect(sideEffectExecuted).toBe(true) + expect(tooltip.matches(':popover-open')).toBe(false) + fireEvent.mouseOver(button) + await waitFor(() => expect(tooltip.matches(':popover-open')).toBe(true)) + }) + it("preserves trigger element's own ref", () => { const buttonRefCallback = vi.fn()