From d765c3f98b0f375e9f57450dc65f901d91cdd6a6 Mon Sep 17 00:00:00 2001 From: Alex Castillo Date: Wed, 11 Nov 2026 12:37:53 -0400 Subject: [PATCH 1/2] fix: preserve explode presence in parameter hashes --- datamodel/low/v3/parameter.go | 4 ++- datamodel/low/v3/parameter_test.go | 18 +++++++++++++ what-changed/model/parameter_test.go | 38 ++++++++++++++++++++++++++++ 3 files changed, 59 insertions(+), 1 deletion(-) diff --git a/datamodel/low/v3/parameter.go b/datamodel/low/v3/parameter.go index 0213e078..faedf866 100644 --- a/datamodel/low/v3/parameter.go +++ b/datamodel/low/v3/parameter.go @@ -184,7 +184,9 @@ func (p *Parameter) Hash() uint64 { if p.Style.Value != "" { low.HashString(h, "style", p.Style.Value) } - low.HashBool(h, p.Explode.Value) + if p.Explode.ValueNode != nil { + low.HashBool(h, p.Explode.Value) + } h.WriteByte(low.HASH_PIPE) low.HashBool(h, p.AllowReserved.Value) h.WriteByte(low.HASH_PIPE) diff --git a/datamodel/low/v3/parameter_test.go b/datamodel/low/v3/parameter_test.go index 8d1ba12b..6974d7a4 100644 --- a/datamodel/low/v3/parameter_test.go +++ b/datamodel/low/v3/parameter_test.go @@ -365,3 +365,21 @@ schema: hash2 := n.Hash() assert.NotEqual(t, hash1, hash2) } + +func TestParameter_Hash_ExplodePresence(t *testing.T) { + build := func(spec string) *Parameter { + var node yaml.Node + require.NoError(t, yaml.Unmarshal([]byte(spec), &node)) + var parameter Parameter + require.NoError(t, low.BuildModel(node.Content[0], ¶meter)) + require.NoError(t, parameter.Build(context.Background(), nil, node.Content[0], nil)) + return ¶meter + } + spec := "name: a\nin: query\nschema: {type: array}\n" + absent := build(spec) + explicitFalse := build(spec + "explode: false\n") + explicitTrue := build(spec + "explode: true\n") + assert.NotEqual(t, absent.Hash(), explicitFalse.Hash()) + assert.NotEqual(t, absent.Hash(), explicitTrue.Hash()) + assert.Equal(t, explicitTrue.Hash(), build(spec+"explode: true\n").Hash()) +} diff --git a/what-changed/model/parameter_test.go b/what-changed/model/parameter_test.go index 4a1298af..7b736da4 100644 --- a/what-changed/model/parameter_test.go +++ b/what-changed/model/parameter_test.go @@ -1069,3 +1069,41 @@ required: false` assert.Len(t, extChanges.GetAllChanges(), 1) assert.Equal(t, 1, extChanges.TotalBreakingChanges()) } + +func TestCompareParameters_V3_ExplodePresence(t *testing.T) { + low.ClearHashCache() + build := func(spec string) *v3.Parameter { + var node yaml.Node + if !assert.NoError(t, yaml.Unmarshal([]byte(spec), &node)) { + t.FailNow() + } + var parameter v3.Parameter + assert.NoError(t, low.BuildModel(node.Content[0], ¶meter)) + assert.NoError(t, parameter.Build(context.Background(), nil, node.Content[0], nil)) + return ¶meter + } + spec := "name: a\nin: query\nschema: {type: array}\n" + absent := build(spec) + explicitFalse := build(spec + "explode: false\n") + for _, tc := range []struct { + name string + left, right *v3.Parameter + changeType int + }{ + {"added", absent, explicitFalse, PropertyAdded}, + {"removed", explicitFalse, absent, PropertyRemoved}, + } { + t.Run(tc.name, func(t *testing.T) { + changes := CompareParameters(tc.left, tc.right) + if !assert.NotNil(t, changes) { + return + } + assert.Equal(t, 1, changes.TotalChanges()) + assert.Equal(t, 0, changes.TotalBreakingChanges()) + if assert.Len(t, changes.GetAllChanges(), 1) { + assert.Equal(t, "explode", changes.GetAllChanges()[0].Property) + assert.Equal(t, tc.changeType, changes.GetAllChanges()[0].ChangeType) + } + }) + } +} From 08cbbd2d6bbf53bc9fd42ab8cc59ddc18cac9110 Mon Sep 17 00:00:00 2001 From: Alex Castillo Date: Sat, 14 Nov 2026 14:19:14 -0400 Subject: [PATCH 2/2] fix: hash parameter explode when the node is present Use the same IsEmpty check as NewParameter so a key-only Explode reference is not treated as omitted. --- datamodel/low/v3/parameter.go | 2 +- datamodel/low/v3/parameter_test.go | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/datamodel/low/v3/parameter.go b/datamodel/low/v3/parameter.go index faedf866..a3b152cb 100644 --- a/datamodel/low/v3/parameter.go +++ b/datamodel/low/v3/parameter.go @@ -184,7 +184,7 @@ func (p *Parameter) Hash() uint64 { if p.Style.Value != "" { low.HashString(h, "style", p.Style.Value) } - if p.Explode.ValueNode != nil { + if !p.Explode.IsEmpty() { low.HashBool(h, p.Explode.Value) } h.WriteByte(low.HASH_PIPE) diff --git a/datamodel/low/v3/parameter_test.go b/datamodel/low/v3/parameter_test.go index 6974d7a4..7651c230 100644 --- a/datamodel/low/v3/parameter_test.go +++ b/datamodel/low/v3/parameter_test.go @@ -382,4 +382,13 @@ func TestParameter_Hash_ExplodePresence(t *testing.T) { assert.NotEqual(t, absent.Hash(), explicitFalse.Hash()) assert.NotEqual(t, absent.Hash(), explicitTrue.Hash()) assert.Equal(t, explicitTrue.Hash(), build(spec+"explode: true\n").Hash()) + + // Key node only, matching a built low parameter that NewParameter treats as present. + keyOnly := build(spec) + keyOnly.Explode = low.NodeReference[bool]{ + KeyNode: &yaml.Node{Kind: yaml.ScalarNode, Value: "explode"}, + Value: true, + } + assert.False(t, low.AreEqual(absent, keyOnly)) + assert.Equal(t, explicitTrue.Hash(), keyOnly.Hash()) }