diff --git a/src/lib/harvest.mjs b/src/lib/harvest.mjs index 879edec2..ba1c662d 100644 --- a/src/lib/harvest.mjs +++ b/src/lib/harvest.mjs @@ -18,6 +18,19 @@ // (#237 ยง3). It was retired with the standalone install (decision A in // docs/archive/2026-09-26-plan-issues-237-238-239-verification-and-decisions.md). // +// ruvnet/ruflo#3445 and ruvnet/ruflo#3444 track whether a released Ruflo lets +// this step promote skills again. @claude-flow/cli 3.48.0 (sha512-wClBcSuga09H +// vU/+Ipn07ejQVz8swJuNHoVfTKOwID/lUbXWEBq+CwCY0CDo+8iMSVZKEf4Accpc/CJYxRjv3w==) +// closes #3445: hooks post-task's feedback bridge now calls +// SkillLibrary.createSkill() instead of the nonexistent promote() +// (dist/src/memory/memory-bridge.js, gated on success && quality >= 0.9 && +// patterns.length). But #3444 is still open in that same release: +// agentdb_consolidate's own description now says it "returns unsupported when +// the installed controller is a no-op stub; no entries are promoted or +// compressed in that case." Harvest supplies neither a quality score nor +// patterns, and the paired consolidation step remains a no-op, so the skill +// step stays retired until #3444 closes too. +// // NEVER starts a daemon, NEVER backgrounds anything. `runner` is injectable so // `ak status --refresh=live --only harvest` can drive it against an isolated // temporary store. diff --git a/src/lib/hook-audit/agentic-dependency-constraints.json b/src/lib/hook-audit/agentic-dependency-constraints.json index bb7c2fd9..76817b8a 100644 --- a/src/lib/hook-audit/agentic-dependency-constraints.json +++ b/src/lib/hook-audit/agentic-dependency-constraints.json @@ -1546,12 +1546,13 @@ "mapping": "mapped", "kitImpact": { "refs": ["lane B1: harvest skill step retired"], "files": [] }, "adjustment": "If a released Ruflo promotes skills after tasks, reconsider the retired harvest skill step; until then it stays retired.", - "status": "fixed-unreleased", + "status": "dispatched", "constraintIds": [], "history": [ { "date": "2026-09-26", "event": "filed" }, { "date": "2026-09-26", "event": "registered" }, - { "date": "2026-09-27", "event": "closed", "note": "completed by PR 3462; not in 3.47.1" } + { "date": "2026-09-27", "event": "closed", "note": "completed by PR 3462; not in 3.47.1" }, + { "date": "2026-10-28", "event": "dispatched", "note": "verified against @claude-flow/cli 3.48.0 (sha512-wClBcSuga09HvU/+Ipn07ejQVz8swJuNHoVfTKOwID/lUbXWEBq+CwCY0CDo+8iMSVZKEf4Accpc/CJYxRjv3w==): hooks post-task's feedback bridge now calls SkillLibrary.createSkill() instead of the missing promote() (dist/src/memory/memory-bridge.js, gated on success && quality>=0.9 && patterns.length), closing this thread. The paired ruvnet/ruflo#3444 is still open in the same release (agentdb_consolidate still documents itself as a no-op stub), so the retired harvest skill step stays retired; ak dispatches this evidence plus a characterization test on branch upstream/ruvnet-ruflo-3445" } ] }, { diff --git a/tests/kit/agentdb-retirement.test.mjs b/tests/kit/agentdb-retirement.test.mjs index 29e4c266..910301c9 100644 --- a/tests/kit/agentdb-retirement.test.mjs +++ b/tests/kit/agentdb-retirement.test.mjs @@ -95,6 +95,19 @@ test('a legacy agentdb key is tolerated silently and preserved on save', async ( assert.equal('agentdb' in loadKitConfig(), false, 'fresh configs carry no agentdb default'); }); +// ruvnet/ruflo#3444 and ruvnet/ruflo#3445 track the two upstream gaps that +// retired the skill step (see harvest.mjs). @claude-flow/cli 3.48.0 closes +// #3445 โ€” SkillLibrary.createSkill() replaces the missing promote() โ€” but +// #3444 is unresolved: agentdb_consolidate still documents itself as a no-op +// stub. So harvest's record-outcome step must still send no quality score +// and no patterns; there is nothing yet for Ruflo to promote. +test('harvest sends no quality or patterns โ€” the skill step stays retired pending ruflo#3444', () => { + const [record] = harvest.planHarvest({ cwd: PROJECT }); + assert.deepEqual(record.args, ['hooks', 'post-task', '--task-id', 'ak-harvest', '--success', 'true']); + assert.ok(!record.args.includes('--quality'), 'no quality score to gate skill creation on'); + assert.ok(!record.args.includes('--patterns'), 'no patterns to promote'); +}); + test('the harvest plan runs only Ruflo verbs; distillation is an explicit opt-in', () => { const plain = harvest.planHarvest({ cwd: PROJECT }); assert.deepEqual(plain.map((s) => s.cmd), ['ruflo']);