From 40c2e68e768b3b8333c76ca7ccb4b1128886adfc Mon Sep 17 00:00:00 2001
From: Martin Brodbeck <martin@brodbeck-online.de>
Date: Sun, 13 Sep 2026 14:07:10 +0200
Subject: [PATCH] ddns-scripts: fix updating IPv6 for netcup: update to 2.8.5

Fixes #30387
Uses suggested fix from https://github.com/openwrt/packages/issues/30387#issuecomment-5652957954

Signed-off-by: Martin Brodbeck <martin@brodbeck-online.de>
---
 net/ddns-scripts/Makefile                     |  4 ++--
 .../files/usr/lib/ddns/update_netcup_com.sh   | 23 +++++++++++++------
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/net/ddns-scripts/Makefile b/net/ddns-scripts/Makefile
index 24af20b3a67001..35a4fae5575fae 100644
--- a/net/ddns-scripts/Makefile
+++ b/net/ddns-scripts/Makefile
@@ -7,8 +7,8 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=ddns-scripts
-PKG_VERSION:=2.8.4
-PKG_RELEASE:=4
+PKG_VERSION:=2.8.5
+PKG_RELEASE:=1
 
 PKG_LICENSE:=GPL-2.0
 
diff --git a/net/ddns-scripts/files/usr/lib/ddns/update_netcup_com.sh b/net/ddns-scripts/files/usr/lib/ddns/update_netcup_com.sh
index dfb3670b1d18f1..a31444918c04e5 100755
--- a/net/ddns-scripts/files/usr/lib/ddns/update_netcup_com.sh
+++ b/net/ddns-scripts/files/usr/lib/ddns/update_netcup_com.sh
@@ -43,7 +43,6 @@ __NETCUP_ENDPOINT="https://ccp.netcup.net/run/webservice/servers/endpoint.php?JS
 [ -z "$param_enc" ]     && write_log 14 "netcup DDNS: 'param_enc' (API key) not set"
 [ -z "$domain" ]        && write_log 14 "netcup DDNS: 'domain' (subdomain to update) not set"
 [ -z "$__IP" ]          && write_log 14 "netcup DDNS: __IP (current IP) not set by the framework"
-[ -z "$REGISTERED_IP" ] && write_log 14 "netcup DDNS: REGISTERED_IP not set by the framework"
 
 # Require an HTTPS-capable client — the netcup endpoint is HTTPS only.
 [ -z "$CURL_SSL" ] && [ -z "$WGET_SSL" ] && \
@@ -215,12 +214,22 @@ for __key in $__RECORD_KEYS; do
 
 	write_log 7 "netcup DDNS: examining record id=$__rec_id '$__rec_name' [$__rec_type] = '$__rec_destination'"
 
-	if [ "$__rec_type" = "$__RRTYPE" ] \
-	&& [ "$__rec_name" = "$__REC_HOSTNAME" ] \
-	&& [ "$__rec_destination" = "$REGISTERED_IP" ]; then
-		__MATCH_ID="$__rec_id"
-		write_log 7 "netcup DDNS: matched record id=$__MATCH_ID"
-		break
+	if [ "$__rec_type" = "$__RRTYPE" ]; then
+		# compare hostname only if type already matches
+		if [ "$__rec_name" = "$__REC_HOSTNAME" ]; then
+			# compare ip's
+			__rec_cmp="$__rec_destination"
+			[ "$__RRTYPE" = "AAAA" ] && expand_ipv6 "$__rec_destination" __rec_cmp
+			if [ "$__rec_cmp" != "$__IP" ]; then
+				__MATCH_ID="$__rec_id"
+				write_log 7 "netcup DDNS: need update for record id='$__MATCH_ID'"
+				break
+			else
+				json_cleanup
+				write_log 6 "netcup DDNS: no update required for host '$__REC_HOSTNAME'"
+				return 0
+			fi
+		fi
 	fi
 done