From 019048356c3d7d7001f8b18462682f971b5719bd Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 11:45:16 -0400 Subject: [PATCH 1/9] fix(sdk): without this the `enforcer` step fails it tries to find the tests jar from sdk and can't find it --- .github/workflows/checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index 7da2ff4bb..101fb2104 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -90,7 +90,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} BUF_INPUT_HTTPS_USERNAME: opentdf-bot BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} - run: mvn clean --batch-mode clean generate-sources + run: mvn clean --batch-mode clean install generate-sources - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work From e9d0fa6c35694dc2c26e3a808c50f6d5931c7e6a Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 11:52:16 -0400 Subject: [PATCH 2/9] Remove 'generate-sources' from Maven command --- .github/workflows/checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index 101fb2104..72950aa08 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -90,7 +90,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} BUF_INPUT_HTTPS_USERNAME: opentdf-bot BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} - run: mvn clean --batch-mode clean install generate-sources + run: mvn clean --batch-mode clean install - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work From 4e36f1a4d06851c3e66b17fd60ba5f7ca2d76f00 Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 13:16:26 -0400 Subject: [PATCH 3/9] Update checks.yaml --- .github/workflows/checks.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index 72950aa08..af92d7656 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -90,7 +90,10 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} BUF_INPUT_HTTPS_USERNAME: opentdf-bot BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} - run: mvn clean --batch-mode clean install + run: | + # we need the test jar installed so that the enforcer step that bans duplicate + # dependencies can get it + mvn clean --batch-mode clean install -Dmaven.enforcer.skip - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work From af08aac9ab2b778fc0610ba650d6611f9ff263a3 Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 13:17:07 -0400 Subject: [PATCH 4/9] Update Maven command to skip tests Skip tests during Maven build to speed up the process. --- .github/workflows/checks.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index af92d7656..a53aa23b3 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -92,8 +92,8 @@ jobs: BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} run: | # we need the test jar installed so that the enforcer step that bans duplicate - # dependencies can get it - mvn clean --batch-mode clean install -Dmaven.enforcer.skip + # dependencies can get it. this also generates the sources + mvn clean --batch-mode clean install -Dmaven.enforcer.skip -Dmaven.test.skip - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work From 36473ddd32709ef669407f86fbe25cc9524e37f1 Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 14:17:48 -0400 Subject: [PATCH 5/9] Refactor Maven commands in checks.yaml --- .github/workflows/checks.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index a53aa23b3..c03e3e5dc 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -90,17 +90,14 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} BUF_INPUT_HTTPS_USERNAME: opentdf-bot BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} - run: | - # we need the test jar installed so that the enforcer step that bans duplicate - # dependencies can get it. this also generates the sources - mvn clean --batch-mode clean install -Dmaven.enforcer.skip -Dmaven.test.skip + run: mvn clean --batch-mode clean generate-sources -Dmaven.enforcer.skip - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work mvn --batch-mode install -pl sdk-fips-bc -am \ -Dmaven.antrun.skip \ -Dmaven.test.skip - mvn --batch-mode test enforcer:enforce -P 'fips,!non-fips' \ + mvn --batch-mode install test enforcer:enforce -P 'fips,!non-fips' \ -Dmaven.antrun.skip - name: Tests with coverage and javadoc (non-fips) env: From 328739e59b45c80c9aa8d59cb4bbef80da79879b Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 14:27:52 -0400 Subject: [PATCH 6/9] Update .github/workflows/checks.yaml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- .github/workflows/checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index c03e3e5dc..e4ea18982 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -90,7 +90,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} BUF_INPUT_HTTPS_USERNAME: opentdf-bot BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} - run: mvn clean --batch-mode clean generate-sources -Dmaven.enforcer.skip + run: mvn clean --batch-mode clean generate-sources -Denforcer.skip - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work From 0dd305c6ed42ba5e93524b704934e0afae81f08b Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 14:41:28 -0400 Subject: [PATCH 7/9] don't shade here --- .github/workflows/checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index e4ea18982..d7d0ffb41 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -97,7 +97,7 @@ jobs: mvn --batch-mode install -pl sdk-fips-bc -am \ -Dmaven.antrun.skip \ -Dmaven.test.skip - mvn --batch-mode install test enforcer:enforce -P 'fips,!non-fips' \ + mvn --batch-mode test enforcer:enforce -P 'fips,!non-fips' \ -Dmaven.antrun.skip - name: Tests with coverage and javadoc (non-fips) env: From dab5b34d31b85c1f62903ab079cf82ec7dd04997 Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 15:18:27 -0400 Subject: [PATCH 8/9] Update Maven commands to skip enforcer checks --- .github/workflows/checks.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index d7d0ffb41..99421e3df 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -90,13 +90,14 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} BUF_INPUT_HTTPS_USERNAME: opentdf-bot BUF_INPUT_HTTPS_PASSWORD: ${{ secrets.PERSONAL_ACCESS_TOKEN_OPENTDF }} - run: mvn clean --batch-mode clean generate-sources -Denforcer.skip + run: mvn clean --batch-mode clean generate-sources -Dmaven.enforcer.skip - name: Tests and enforcer (fips) run: | # install the sdk-fips-bc jar so that FIPS mode tests work mvn --batch-mode install -pl sdk-fips-bc -am \ -Dmaven.antrun.skip \ - -Dmaven.test.skip + -Dmaven.test.skip \ + -Dmaven.enforcer.skip mvn --batch-mode test enforcer:enforce -P 'fips,!non-fips' \ -Dmaven.antrun.skip - name: Tests with coverage and javadoc (non-fips) From 35a0f8eb64ecb90e7941df5d8a3c4e09d929b653 Mon Sep 17 00:00:00 2001 From: Morgan Kleene Date: Fri, 2 Oct 2026 19:04:20 -0400 Subject: [PATCH 9/9] Update .github/workflows/checks.yaml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- .github/workflows/checks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index 99421e3df..34f9a7918 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -97,7 +97,7 @@ jobs: mvn --batch-mode install -pl sdk-fips-bc -am \ -Dmaven.antrun.skip \ -Dmaven.test.skip \ - -Dmaven.enforcer.skip + -Denforcer.skip mvn --batch-mode test enforcer:enforce -P 'fips,!non-fips' \ -Dmaven.antrun.skip - name: Tests with coverage and javadoc (non-fips)