Skip to content

Commit fc24f37

Browse files
author
Tang Chen
committed
Trivial: Remove useless return
If a function returns nothing, do not add return in the end. Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
1 parent 8787ad2 commit fc24f37

9 files changed

Lines changed: 0 additions & 13 deletions

File tree

openstackclient/common/clientmanager.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@ def setup_auth(self, required_scope=True):
199199

200200
self._auth_setup_completed = True
201201

202-
return
203-
204202
@property
205203
def auth_ref(self):
206204
"""Dereference will trigger an auth if it hasn't already"""

openstackclient/identity/v2_0/endpoint.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ def get_parser(self, prog_name):
8787
def take_action(self, parsed_args):
8888
identity_client = self.app.client_manager.identity
8989
identity_client.endpoints.delete(parsed_args.endpoint)
90-
return
9190

9291

9392
class ListEndpoint(command.Lister):

openstackclient/identity/v2_0/project.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ def take_action(self, parsed_args):
119119
project,
120120
)
121121
identity_client.tenants.delete(project_obj.id)
122-
return
123122

124123

125124
class ListProject(command.Lister):
@@ -222,7 +221,6 @@ def take_action(self, parsed_args):
222221
del kwargs['name']
223222

224223
identity_client.tenants.update(project.id, **kwargs)
225-
return
226224

227225

228226
class ShowProject(command.ShowOne):
@@ -317,4 +315,3 @@ def take_action(self, parsed_args):
317315
if key in kwargs:
318316
kwargs[key] = None
319317
identity_client.tenants.update(project.id, **kwargs)
320-
return

openstackclient/identity/v2_0/role.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ def take_action(self, parsed_args):
126126
role,
127127
)
128128
identity_client.roles.delete(role_obj.id)
129-
return
130129

131130

132131
class ListRole(command.Lister):

openstackclient/identity/v2_0/service.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ def take_action(self, parsed_args):
101101
identity_client = self.app.client_manager.identity
102102
service = common.find_service(identity_client, parsed_args.service)
103103
identity_client.services.delete(service.id)
104-
return
105104

106105

107106
class ListService(command.Lister):

openstackclient/identity/v2_0/token.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,3 @@ def take_action(self, parsed_args):
5555
identity_client = self.app.client_manager.identity
5656

5757
identity_client.tokens.delete(parsed_args.token)
58-
return

openstackclient/identity/v2_0/user.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ def take_action(self, parsed_args):
143143
user,
144144
)
145145
identity_client.users.delete(user_obj.id)
146-
return
147146

148147

149148
class ListUser(command.Lister):
@@ -330,7 +329,6 @@ def take_action(self, parsed_args):
330329
kwargs['enabled'] = False
331330

332331
identity_client.users.update(user.id, **kwargs)
333-
return
334332

335333

336334
class ShowUser(command.ShowOne):

openstackclient/network/v2/network.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,6 @@ def take_action(self, parsed_args):
338338
raise exceptions.CommandError(msg)
339339

340340
client.update_network(obj, **attrs)
341-
return
342341

343342

344343
class ShowNetwork(common.NetworkAndComputeShowOne):

openstackclient/network/v2/security_group.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ def take_action_network(self, client, parsed_args):
123123
# if there were no updates. Maintain this behavior and issue
124124
# the update.
125125
client.update_security_group(obj, **attrs)
126-
return
127126

128127
def take_action_compute(self, client, parsed_args):
129128
data = utils.find_resource(

0 commit comments

Comments
 (0)