Skip to content

Commit fbd48be

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Trivial: Remove unuseful comments for assertRaise() checking"
2 parents 2244915 + 15c9576 commit fbd48be

5 files changed

Lines changed: 0 additions & 16 deletions

File tree

openstackclient/tests/compute/v2/test_server.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ def test_server_create_no_options(self):
146146
('server_name', self.new_server.name),
147147
]
148148

149-
# Missing required args should bail here
150149
self.assertRaises(utils.ParserException, self.check_parser,
151150
self.cmd, arglist, verifylist)
152151

openstackclient/tests/network/v2/test_floating_ip.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ def test_create_no_options(self):
8888
arglist = []
8989
verifylist = []
9090

91-
# Missing required args should bail here
9291
self.assertRaises(tests_utils.ParserException, self.check_parser,
9392
self.cmd, arglist, verifylist)
9493

@@ -314,7 +313,6 @@ def test_create_no_options(self):
314313
arglist = []
315314
verifylist = []
316315

317-
# Missing required args should bail here
318316
self.assertRaises(tests_utils.ParserException, self.check_parser,
319317
self.cmd, arglist, verifylist)
320318

openstackclient/tests/network/v2/test_network.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ def test_create_no_options(self):
112112
arglist = []
113113
verifylist = []
114114

115-
# Missing required args should bail here
116115
self.assertRaises(tests_utils.ParserException, self.check_parser,
117116
self.cmd, arglist, verifylist)
118117

@@ -599,7 +598,6 @@ def test_show_no_options(self):
599598
arglist = []
600599
verifylist = []
601600

602-
# Missing required args should bail here
603601
self.assertRaises(tests_utils.ParserException, self.check_parser,
604602
self.cmd, arglist, verifylist)
605603

@@ -916,7 +914,6 @@ def test_show_no_options(self):
916914
arglist = []
917915
verifylist = []
918916

919-
# Missing required args should bail here
920917
self.assertRaises(tests_utils.ParserException, self.check_parser,
921918
self.cmd, arglist, verifylist)
922919

openstackclient/tests/network/v2/test_router.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def test_add_port_no_option(self):
4747
arglist = []
4848
verifylist = []
4949

50-
# Missing required args should bail here
5150
self.assertRaises(tests_utils.ParserException, self.check_parser,
5251
self.cmd, arglist, verifylist)
5352

@@ -88,7 +87,6 @@ def test_add_subnet_no_option(self):
8887
arglist = []
8988
verifylist = []
9089

91-
# Missing required args should bail here
9290
self.assertRaises(tests_utils.ParserException, self.check_parser,
9391
self.cmd, arglist, verifylist)
9492

@@ -154,7 +152,6 @@ def test_create_no_options(self):
154152
arglist = []
155153
verifylist = []
156154

157-
# Missing required args should bail here
158155
self.assertRaises(tests_utils.ParserException, self.check_parser,
159156
self.cmd, arglist, verifylist)
160157

@@ -335,7 +332,6 @@ def test_remove_port_no_option(self):
335332
arglist = []
336333
verifylist = []
337334

338-
# Missing required args should bail here
339335
self.assertRaises(tests_utils.ParserException, self.check_parser,
340336
self.cmd, arglist, verifylist)
341337

@@ -375,7 +371,6 @@ def test_remove_subnet_no_option(self):
375371
arglist = []
376372
verifylist = []
377373

378-
# Missing required args should bail here
379374
self.assertRaises(tests_utils.ParserException, self.check_parser,
380375
self.cmd, arglist, verifylist)
381376

@@ -475,7 +470,6 @@ def test_set_distributed_centralized(self):
475470
('distributed', False),
476471
]
477472

478-
# Missing required args should bail here
479473
self.assertRaises(tests_utils.ParserException, self.check_parser,
480474
self.cmd, arglist, verifylist)
481475

@@ -534,7 +528,6 @@ def test_set_route_clear_routes(self):
534528
('clear_routes', True),
535529
]
536530

537-
# Argument parse failing should bail here
538531
self.assertRaises(tests_utils.ParserException, self.check_parser,
539532
self.cmd, arglist, verifylist)
540533

@@ -591,7 +584,6 @@ def test_show_no_options(self):
591584
arglist = []
592585
verifylist = []
593586

594-
# Missing required args should bail here
595587
self.assertRaises(tests_utils.ParserException, self.check_parser,
596588
self.cmd, arglist, verifylist)
597589

openstackclient/tests/network/v2/test_subnet_pool.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ def test_create_no_options(self):
109109
arglist = []
110110
verifylist = []
111111

112-
# Missing required args should bail here
113112
self.assertRaises(tests_utils.ParserException, self.check_parser,
114113
self.cmd, arglist, verifylist)
115114

@@ -624,7 +623,6 @@ def test_show_no_options(self):
624623
arglist = []
625624
verifylist = []
626625

627-
# Missing required args should bail here
628626
self.assertRaises(tests_utils.ParserException, self.check_parser,
629627
self.cmd, arglist, verifylist)
630628

0 commit comments

Comments
 (0)