Skip to content

Commit f0e64eb

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Refactor TestRemoveProjectImage with FakeImage class"
2 parents 11be59d + 69be96a commit f0e64eb

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

openstackclient/tests/image/v2/test_image.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -727,12 +727,10 @@ class TestRemoveProjectImage(TestImage):
727727
def setUp(self):
728728
super(TestRemoveProjectImage, self).setUp()
729729

730+
self._image = image_fakes.FakeImage.create_one_image()
730731
# This is the return value for utils.find_resource()
731-
self.images_mock.get.return_value = fakes.FakeResource(
732-
None,
733-
copy.deepcopy(image_fakes.IMAGE),
734-
loaded=True,
735-
)
732+
self.images_mock.get.return_value = self._image
733+
736734
self.project_mock.get.return_value = fakes.FakeResource(
737735
None,
738736
copy.deepcopy(identity_fakes.PROJECT),
@@ -749,31 +747,31 @@ def setUp(self):
749747

750748
def test_remove_project_image_no_options(self):
751749
arglist = [
752-
image_fakes.image_id,
750+
self._image.id,
753751
identity_fakes.project_id,
754752
]
755753
verifylist = [
756-
('image', image_fakes.image_id),
754+
('image', self._image.id),
757755
('project', identity_fakes.project_id),
758756
]
759757
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
760758

761759
result = self.cmd.take_action(parsed_args)
762760

763761
self.image_members_mock.delete.assert_called_with(
764-
image_fakes.image_id,
762+
self._image.id,
765763
identity_fakes.project_id,
766764
)
767765
self.assertIsNone(result)
768766

769767
def test_remove_project_image_with_options(self):
770768
arglist = [
771-
image_fakes.image_id,
769+
self._image.id,
772770
identity_fakes.project_id,
773771
'--project-domain', identity_fakes.domain_id,
774772
]
775773
verifylist = [
776-
('image', image_fakes.image_id),
774+
('image', self._image.id),
777775
('project', identity_fakes.project_id),
778776
('project_domain', identity_fakes.domain_id),
779777
]
@@ -782,7 +780,7 @@ def test_remove_project_image_with_options(self):
782780
result = self.cmd.take_action(parsed_args)
783781

784782
self.image_members_mock.delete.assert_called_with(
785-
image_fakes.image_id,
783+
self._image.id,
786784
identity_fakes.project_id,
787785
)
788786
self.assertIsNone(result)

0 commit comments

Comments
 (0)