Skip to content

Commit d66e666

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Replace assertEqual(None, *) with assertIsNone in tests"
2 parents e590597 + fe7d2d1 commit d66e666

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

openstackclient/tests/identity/v3/test_identity_provider.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -638,5 +638,5 @@ def prepare(self):
638638

639639
# expect take_action() to return (None, None) as
640640
# neither --enable nor --disable was specified
641-
self.assertEqual(None, columns)
642-
self.assertEqual(None, data)
641+
self.assertIsNone(columns)
642+
self.assertIsNone(data)

openstackclient/tests/network/v2/test_network.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def test_delete(self):
301301
result = self.cmd.take_action(parsed_args)
302302

303303
self.network.delete_network.assert_called_with(self._network)
304-
self.assertEqual(None, result)
304+
self.assertIsNone(result)
305305

306306

307307
class TestListNetwork(TestNetwork):
@@ -443,7 +443,7 @@ def test_set_this(self):
443443
result = self.cmd.take_action(parsed_args)
444444

445445
self.network.update_network.assert_called_with(self._network)
446-
self.assertEqual(None, result)
446+
self.assertIsNone(result)
447447

448448
def test_set_that(self):
449449
self._network.is_dirty = True
@@ -463,7 +463,7 @@ def test_set_that(self):
463463
result = self.cmd.take_action(parsed_args)
464464

465465
self.network.update_network.assert_called_with(self._network)
466-
self.assertEqual(None, result)
466+
self.assertIsNone(result)
467467

468468
def test_set_nothing(self):
469469
self._network.is_dirty = False

openstackclient/tests/network/v2/test_router.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_delete(self):
115115

116116
result = self.cmd.take_action(parsed_args)
117117
self.network.delete_router.assert_called_with(self._router)
118-
self.assertEqual(None, result)
118+
self.assertIsNone(result)
119119

120120

121121
class TestListRouter(TestRouter):
@@ -235,7 +235,7 @@ def test_set_this(self):
235235
'name': 'noob',
236236
}
237237
self.network.update_router.assert_called_with(self._router, **attrs)
238-
self.assertEqual(None, result)
238+
self.assertIsNone(result)
239239

240240
def test_set_that(self):
241241
arglist = [
@@ -257,7 +257,7 @@ def test_set_that(self):
257257
'distributed': False,
258258
}
259259
self.network.update_router.assert_called_with(self._router, **attrs)
260-
self.assertEqual(None, result)
260+
self.assertIsNone(result)
261261

262262
def test_set_distributed_centralized(self):
263263
arglist = [

0 commit comments

Comments
 (0)