Skip to content

Commit d4fb5ce

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Trivial clean up: do not use plural form in command arguments."
2 parents cb28cd9 + 0ee5527 commit d4fb5ce

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

openstackclient/compute/v2/server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ class DeleteServer(command.Command):
607607
def get_parser(self, prog_name):
608608
parser = super(DeleteServer, self).get_parser(prog_name)
609609
parser.add_argument(
610-
'servers',
610+
'server',
611611
metavar='<server>',
612612
nargs="+",
613613
help=_('Server(s) to delete (name or ID)'),
@@ -622,7 +622,7 @@ def get_parser(self, prog_name):
622622
@utils.log_method(log)
623623
def take_action(self, parsed_args):
624624
compute_client = self.app.client_manager.compute
625-
for server in parsed_args.servers:
625+
for server in parsed_args.server:
626626
server_obj = utils.find_resource(
627627
compute_client.servers, server)
628628
compute_client.servers.delete(server_obj.id)

openstackclient/tests/compute/v2/test_server.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def test_server_delete_no_options(self):
311311
compute_fakes.server_id,
312312
]
313313
verifylist = [
314-
('servers', [compute_fakes.server_id]),
314+
('server', [compute_fakes.server_id]),
315315
]
316316
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
317317

@@ -328,7 +328,7 @@ def test_server_delete_wait_ok(self, mock_wait_for_delete):
328328
compute_fakes.server_id, '--wait'
329329
]
330330
verifylist = [
331-
('servers', [compute_fakes.server_id]),
331+
('server', [compute_fakes.server_id]),
332332
]
333333
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
334334

@@ -351,7 +351,7 @@ def test_server_delete_wait_fails(self, mock_wait_for_delete):
351351
compute_fakes.server_id, '--wait'
352352
]
353353
verifylist = [
354-
('servers', [compute_fakes.server_id]),
354+
('server', [compute_fakes.server_id]),
355355
]
356356
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
357357

0 commit comments

Comments
 (0)