Use is_public to set access of volume type

Currently the 'public' and 'private' keys does not work
when creating volume type, 'is_public' should be used.

Change-Id: If34a66053ea6c192882a1b9d8bbb1d3666be3f83
Closes-bug: 1520115

Author: Xi Yang

openstackclient/tests/volume/v2/test_type.py

@@ -73,7 +73,7 @@ def test_type_create_public(self):
         self.types_mock.create.assert_called_with(
             volume_fakes.type_name,
             description=volume_fakes.type_description,
-            public=True,
+            is_public=True,
         )
 
         collist = (
@@ -93,7 +93,7 @@ def test_type_create_private(self):
         arglist = [
             volume_fakes.type_name,
             "--description", volume_fakes.type_description,
-            "--private"
+            "--private",
         ]
         verifylist = [
             ("name", volume_fakes.type_name),
@@ -107,7 +107,7 @@ def test_type_create_private(self):
         self.types_mock.create.assert_called_with(
             volume_fakes.type_name,
             description=volume_fakes.type_description,
-            private=True,
+            is_public=False,
         )
 
         collist = (

openstackclient/volume/v2/volume_type.py

@@ -73,9 +73,9 @@ def take_action(self, parsed_args):
 
         kwargs = {}
         if parsed_args.public:
-            kwargs['public'] = True
+            kwargs['is_public'] = True
         if parsed_args.private:
-            kwargs['private'] = True
+            kwargs['is_public'] = False
 
         volume_type = volume_client.volume_types.create(
             parsed_args.name,