Skip to content

Commit c5a55d1

Browse files
committed
User FakeFlavor in TestServerResize.
Change-Id: Iac9b4583befaa4eb79ec59c39b97c613884ef2f7 Implements: blueprint improve-flavor-unit-test
1 parent db516b2 commit c5a55d1

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

openstackclient/tests/compute/v2/test_server.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -666,11 +666,8 @@ def setUp(self):
666666
self.servers_mock.revert_resize.return_value = None
667667

668668
# This is the return value for utils.find_resource()
669-
self.flavors_get_return_value = fakes.FakeResource(
670-
None,
671-
copy.deepcopy(compute_fakes.FLAVOR),
672-
loaded=True,
673-
)
669+
self.flavors_get_return_value = \
670+
compute_fakes.FakeFlavor.create_one_flavor()
674671
self.flavors_mock.get.return_value = self.flavors_get_return_value
675672

676673
# Get the command object to test
@@ -700,11 +697,11 @@ def test_server_resize_no_options(self):
700697

701698
def test_server_resize(self):
702699
arglist = [
703-
'--flavor', compute_fakes.flavor_id,
700+
'--flavor', self.flavors_get_return_value.id,
704701
self.server.id,
705702
]
706703
verifylist = [
707-
('flavor', compute_fakes.flavor_id),
704+
('flavor', self.flavors_get_return_value.id),
708705
('confirm', False),
709706
('revert', False),
710707
('server', self.server.id),
@@ -718,7 +715,7 @@ def test_server_resize(self):
718715
self.server.id,
719716
)
720717
self.flavors_mock.get.assert_called_with(
721-
compute_fakes.flavor_id,
718+
self.flavors_get_return_value.id,
722719
)
723720

724721
self.servers_mock.resize.assert_called_with(

0 commit comments

Comments
 (0)