Merge "Support "server list" searching by both flavor name and ID."

Author: Jenkins

doc/source/command-objects/server.rst

@@ -216,7 +216,7 @@ List servers
 
 .. option:: --flavor <flavor>
 
-    Search by flavor ID
+    Search by flavor (name or ID)
 
 .. option:: --image <image>
 

openstackclient/compute/v2/server.py

@@ -712,7 +712,7 @@ def get_parser(self, prog_name):
         parser.add_argument(
             '--flavor',
             metavar='<flavor>',
-            help=_('Search by flavor'),
+            help=_('Search by flavor (name or ID)'),
         )
         parser.add_argument(
             '--image',
@@ -789,14 +789,21 @@ def take_action(self, parsed_args):
                 parsed_args.user_domain,
             ).id
 
+        # Nova only supports list servers searching by flavor ID. So if a
+        # flavor name is given, map it to ID.
+        flavor_id = None
+        if parsed_args.flavor:
+            flavor_id = utils.find_resource(compute_client.flavors,
+                                            parsed_args.flavor).id
+
         search_opts = {
             'reservation_id': parsed_args.reservation_id,
             'ip': parsed_args.ip,
             'ip6': parsed_args.ip6,
             'name': parsed_args.name,
             'instance_name': parsed_args.instance_name,
             'status': parsed_args.status,
-            'flavor': parsed_args.flavor,
+            'flavor': flavor_id,
             'image': parsed_args.image,
             'host': parsed_args.host,
             'tenant_id': project_id,