Skip to content

Commit b5f10f4

Browse files
committed
Fix SSL/TLS verification for network commands
The network commands ignored the --insecure and --os-cacert options and OS_CACERT environment variable which prevented them from properly completing SSL/TLS verification. This resulted in the network commands failing with "An SSL error occurred." Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1 Closes-Bug: #1560157
1 parent 9f2e703 commit b5f10f4

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

openstackclient/network/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131

3232
def make_client(instance):
3333
"""Returns a network proxy"""
34-
conn = connection.Connection(authenticator=instance.session.auth)
34+
conn = connection.Connection(authenticator=instance.session.auth,
35+
verify=instance.session.verify)
3536
LOG.debug('Connection: %s', conn)
3637
LOG.debug('Network client initialized using OpenStack SDK: %s',
3738
conn.network)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
fixes:
3+
- Fixed SSL/TLS verification for Network v2 commands. The commands
4+
were ignoring the ``--insecure`` and ``--os-cacert`` options and
5+
the ``OS_CACERT`` environment variable which caused them to fail
6+
with ``An SSL error occurred.`` when authenticating using SSL/TLS.
7+
[Bug `1560157 <https://bugs.launchpad.net/python-openstackclient/+bug/1560157>`_]

0 commit comments

Comments
 (0)