Merge "Add name option to 'port set'"

Author: Jenkins

doc/source/command-objects/port.rst

@@ -130,6 +130,7 @@ Set port properties
         [--binding-profile <binding-profile>]
         [--host-id <host-id>]
         [--enable | --disable]
+        [--name <name>]
         <port>
 
 .. option:: --fixed-ip subnet=<subnet>,ip-address=<ip-address>
@@ -168,6 +169,10 @@ Set port properties
 
     Disable port
 
+.. option:: --name
+
+    Set port name
+
 .. _port_set-port:
 .. describe:: <port>
 

openstackclient/network/v2/port.py

@@ -97,10 +97,11 @@ def _get_attrs(client_manager, parsed_args):
     if parsed_args.host:
         attrs['binding:host_id'] = parsed_args.host
 
+    # It is possible that name is not updated during 'port set'
+    if parsed_args.name is not None:
+        attrs['name'] = str(parsed_args.name)
     # The remaining options do not support 'port set' command, so they require
     # additional check
-    if 'name' in parsed_args and parsed_args.name is not None:
-        attrs['name'] = str(parsed_args.name)
     if 'mac_address' in parsed_args and parsed_args.mac_address is not None:
         attrs['mac_address'] = parsed_args.mac_address
     if 'network' in parsed_args and parsed_args.network is not None:
@@ -342,6 +343,10 @@ def get_parser(self, prog_name):
             action='store_true',
             help='Disable port',
         )
+        parser.add_argument(
+            '--name',
+            metavar="<name>",
+            help=('Set port name'))
         parser.add_argument(
             'port',
             metavar="<port>",

openstackclient/tests/network/v2/test_port.py

@@ -319,13 +319,15 @@ def test_set_that(self):
             '--vnic-type', 'macvtap',
             '--binding-profile', 'foo=bar',
             '--host', 'binding-host-id-xxxx',
+            '--name', 'newName',
             self._port.name,
         ]
         verifylist = [
             ('enable', True),
             ('vnic_type', 'macvtap'),
             ('binding_profile', {'foo': 'bar'}),
             ('host', 'binding-host-id-xxxx'),
+            ('name', 'newName')
         ]
 
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@@ -336,6 +338,7 @@ def test_set_that(self):
             'binding:vnic_type': 'macvtap',
             'binding:profile': {'foo': 'bar'},
             'binding:host_id': 'binding-host-id-xxxx',
+            'name': 'newName',
         }
         self.network.update_port.assert_called_once_with(self._port, **attrs)
         self.assertIsNone(result)

releasenotes/notes/add-name-to-port-set-eefa081225bf8b49.yaml

@@ -0,0 +1,4 @@
+---
+features:
+  - |
+    Port name can now be updated using ``port set``