Skip to content

Commit a80ccd8

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Use assertTrue/False instead of assertEqual(T/F)"
2 parents ee0fb4a + a56fc34 commit a80ccd8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

openstackclient/tests/common/test_logs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def test_init(self, warning_filter, getLogger, handle):
137137
self.cliff_log.setLevel.assert_called_with(logging.ERROR)
138138
self.stevedore_log.setLevel.assert_called_with(logging.ERROR)
139139
self.iso8601_log.setLevel.assert_called_with(logging.ERROR)
140-
self.assertEqual(False, configurator.dump_trace)
140+
self.assertFalse(configurator.dump_trace)
141141

142142
@mock.patch('logging.getLogger')
143143
@mock.patch('openstackclient.common.logs.set_warning_filter')
@@ -149,7 +149,7 @@ def test_init_no_debug(self, warning_filter, getLogger):
149149

150150
warning_filter.assert_called_with(logging.DEBUG)
151151
self.requests_log.setLevel.assert_called_with(logging.DEBUG)
152-
self.assertEqual(True, configurator.dump_trace)
152+
self.assertTrue(configurator.dump_trace)
153153

154154
@mock.patch('logging.FileHandler')
155155
@mock.patch('logging.getLogger')
@@ -199,4 +199,4 @@ def test_configure(self, formatter, warning_filter, getLogger, handle):
199199
self.root_logger.addHandler.assert_called_with(file_logger)
200200
file_logger.setFormatter.assert_called_with(mock_formatter)
201201
file_logger.setLevel.assert_called_with(logging.INFO)
202-
self.assertEqual(False, configurator.dump_trace)
202+
self.assertFalse(configurator.dump_trace)

0 commit comments

Comments
 (0)