Skip to content

Commit 8f40259

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Remove links from federation related commands in identity v3"
2 parents c55fdb6 + 070fa50 commit 8f40259

3 files changed

Lines changed: 11 additions & 12 deletions

File tree

‎openstackclient/identity/v3/federation_protocol.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ def take_action(self, parsed_args):
6161
# user.
6262
info['identity_provider'] = parsed_args.identity_provider
6363
info['mapping'] = info.pop('mapping_id')
64+
info.pop('links', None)
6465
return zip(*sorted(six.iteritems(info)))
6566

6667

@@ -179,4 +180,5 @@ def take_action(self, parsed_args):
179180
parsed_args.identity_provider, parsed_args.federation_protocol)
180181
info = dict(protocol._info)
181182
info['mapping'] = info.pop('mapping_id')
183+
info.pop('links', None)
182184
return zip(*sorted(six.iteritems(info)))

‎openstackclient/identity/v3/identity_provider.py‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ def take_action(self, parsed_args):
6565
id=parsed_args.identity_provider_id,
6666
description=parsed_args.description,
6767
enabled=parsed_args.enabled)
68-
info = {}
69-
info.update(idp._info)
70-
return zip(*sorted(six.iteritems(info)))
68+
69+
idp._info.pop('links', None)
70+
return zip(*sorted(six.iteritems(idp._info)))
7171

7272

7373
class DeleteIdentityProvider(command.Command):
@@ -176,6 +176,5 @@ def take_action(self, parsed_args):
176176
identity_client.federation.identity_providers,
177177
parsed_args.identity_provider)
178178

179-
info = {}
180-
info.update(identity_provider._info)
181-
return zip(*sorted(six.iteritems(info)))
179+
identity_provider._info.pop('links', None)
180+
return zip(*sorted(six.iteritems(identity_provider._info)))

‎openstackclient/identity/v3/mapping.py‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,8 @@ def take_action(self, parsed_args):
107107
mapping_id=parsed_args.mapping,
108108
rules=rules)
109109

110-
info = {}
111-
info.update(mapping._info)
112-
return zip(*sorted(six.iteritems(info)))
110+
mapping._info.pop('links', None)
111+
return zip(*sorted(six.iteritems(mapping._info)))
113112

114113

115114
class DeleteMapping(command.Command):
@@ -204,6 +203,5 @@ def take_action(self, parsed_args):
204203

205204
mapping = identity_client.federation.mappings.get(parsed_args.mapping)
206205

207-
info = {}
208-
info.update(mapping._info)
209-
return zip(*sorted(six.iteritems(info)))
206+
mapping._info.pop('links', None)
207+
return zip(*sorted(six.iteritems(mapping._info)))

0 commit comments

Comments
 (0)